Repository listings are truncated when searching #1296

New Issue

Open

opened 2023-09-03 20:15:52 +00:00 by mpfaff · 1 comment

mpfaff commented

2023-09-03 20:15:52 +00:00

# Describe your matter briefly

The lazy-loaded listings on the Repositories, My Repositories, and user profile Repositories screens conflicts with the search function. In particular, the search function only searches the already loaded items, and use of the search field, even without entering anything, prevents any futher items from being displayed (although it seems like they are loaded) until the content of the search field is updated.

What did you expect?

When searching, if more items are loaded by the app, the filtered item list should be updated automatically.
When searching, more items should be loaded (presumably via paginated requests to the instance?) until either there are no more or there is a full page of matching items matches. If automatically stopping once a full page is loaded is not feasible, then loading all items up front would be an acceptable alternative.

Some additional details

The version of Gitea you are using: 1.20.3+0
The version of GitNex you are using: 5.1.1 / 511
Source of installation (Play Store, F-Droid, APK): F-Droid
Current android version and phone model/manufacturer: Android 13
The type of certificate your instance is using (self-signed, signed): signed
How you used to log in (via password or token): Token

I carefully read the contribution guidelines.

## # Describe your matter briefly The lazy-loaded listings on the Repositories, My Repositories, and user profile Repositories screens conflicts with the search function. In particular, the search function only searches the already loaded items, and use of the search field, even without entering anything, prevents any futher items from being displayed (although it seems like they are loaded) until the content of the search field is updated. ##### What did you expect? --- - When searching, if more items are loaded by the app, the filtered item list should be updated automatically. - When searching, more items should be loaded (presumably via paginated requests to the instance?) until either there are no more or there is a full page of matching items matches. If automatically stopping once a full page is loaded is not feasible, then loading all items up front would be an acceptable alternative. ##### Some additional details --- * The version of **Gitea** you are using: 1.20.3+0 * The version of **GitNex** you are using: 5.1.1 / 511 * Source of installation (Play Store, F-Droid, APK): F-Droid * Current android version and phone model/manufacturer: Android 13 * The type of certificate your instance is using (self-signed, signed): signed * How you used to log in (via password or token): Token <br> - [x] I carefully read the [contribution guidelines](https://codeberg.org/gitnex/GitNex/wiki/Contributing). <br>

mpfaff changed title from ~~Repository listing is truncated~~ to Repository listings are truncated when searching

2023-09-03 20:16:08 +00:00

mmarif commented

2023-09-04 02:46:10 +00:00

Owner

Thanks for taking your time to explain this.

This is the default searchview behaviour of Android. And yes, as of now it will only search for the loaded repositories.

We are planning to move to a live API search like an issue/pr search. That way you get what you are looking for. The time we implemented this for issues, repos endpoint does not provide a param to search for. I will check again for 1.20 if there is any change now.

This was discussed long ago, not sure if there is an open issue for it. I will check on it.

Thanks for taking your time to explain this. This is the default searchview behaviour of Android. And yes, as of now it will only search for the loaded repositories. We are planning to move to a live API search like an issue/pr search. That way you get what you are looking for. The time we implemented this for issues, repos endpoint does not provide a param to search for. I will check again for 1.20 if there is any change now. This was discussed long ago, not sure if there is an open issue for it. I will check on it.