[Pull] Version Check before try to Login

6543 commented

2020-06-03 17:06:23 +00:00

Member

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/147

Merged with: d14ecd9c68

--- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/147 Merged with: d14ecd9c6893398a8f9a3edd325fdd9ab4179ca7

6543 added this to the 2.3.0 milestone 2020-06-03 17:06:23 +00:00

6543 added the

🎯 Enhancement

label 2020-06-03 17:06:23 +00:00

6543 closed this issue

2020-06-03 17:06:23 +00:00

6543 self-assigned this 2020-06-03 17:07:03 +00:00

mmarif commented

2020-06-03 17:07:04 +00:00

Owner

I will be removing the version call from About screen in the future, it will be part of Accounts table. But that's for later.

Yes, it does not need token.

I will be removing the version call from About screen in the future, it will be part of Accounts table. But that's for later. Yes, it does not need token.

mmarif commented

2020-06-03 17:07:24 +00:00

Owner

@6543 I am planning to release 2.2.0 tomorrow, will you be able to finish it by then?

Otherwise we can push it to the next release.

@6543 I am planning to release 2.2.0 tomorrow, will you be able to finish it by then? Otherwise we can push it to the next release.

6543 commented

2020-06-03 17:07:44 +00:00

Author

Member

@mmarif I'll have time on the weekend ...

6543 commented

2020-06-03 17:08:04 +00:00

Author

Member

@mmarif when you have an guilty login at witch point i get the first api calls?

6543 commented

2020-06-03 17:08:24 +00:00

Author

Member

@mmarif we schould use merge+squash to have a smaler git repo in long therme?

mmarif commented

2020-06-03 17:08:45 +00:00

Owner

when you have an guilty login at witch point i get the first api calls?

All the magic happen inside login() function which call letTheUserIn() API call function.
But for version check, it should happen before the actual API login call. Once the user tap the login button, 1st thing we check and show the error about the version. If all good, proceed to the next step. So in login() you can do the check and return with error when version is old.

we schould use merge+squash to have a smaler git repo in long therme?

Yes, we should to make the repo compact.

> when you have an guilty login at witch point i get the first api calls? All the magic happen inside `login()` function which call `letTheUserIn()` API call function. But for version check, it should happen before the actual API login call. Once the user tap the login button, 1st thing we check and show the error about the version. If all good, proceed to the next step. So in `login()` you can do the check and return with error when version is old. > we schould use merge+squash to have a smaler git repo in long therme? Yes, we should to make the repo compact.

6543 commented

2020-06-03 17:09:05 +00:00

Author

Member

last commit shows the function i get this error: https://pastebin.com/ZXj0tYUG

... working to get RetrofitClient send a syncron call

last commit shows the function i get this error: https://pastebin.com/ZXj0tYUG ... working to get RetrofitClient send a syncron call

mmarif commented

2020-06-03 17:09:25 +00:00

Owner

I haven't check the code yet. But if the api call is outside, you can put it inside lettheuserin call.

mmarif commented

2020-06-03 17:09:45 +00:00

Owner

If it is done from your side, I can take it from here to make it work.

6543 commented

2020-06-03 17:10:05 +00:00

Author

Member

Ok I'll improve VersionTest and then I let you try to bring it to live ... if i didnt found a solution untill then ;)

6543 commented

2020-06-03 17:10:25 +00:00

Author

Member

@mmarif Its yours ;)

VersionTest works as it should now

@mmarif Its yours ;) VersionTest works as it should now

mmarif commented

2020-06-03 17:10:45 +00:00

Owner

@6543 Thanks, I will take it from here.

mmarif commented

2020-06-03 17:11:06 +00:00

Owner

@6543 it's done. You can check from your side now. After your testing can merge.

6543 commented

2020-06-03 17:11:26 +00:00

Author

Member

Great thanks!

6543 commented

2020-06-03 17:11:46 +00:00

Author

Member

nice works fine!!

6543 commented

2020-06-03 17:12:06 +00:00

Author

Member

you ony catch the UNSUPPORTED_OLD but i think this is fine for the purpose of this PR ...

should we cleanup strings of unused one or leave it for later usage ?

you ony catch the UNSUPPORTED_OLD but i think this is fine for the purpose of this PR ... should we cleanup strings of unused one or leave it for later usage ?

mmarif commented

2020-06-03 17:12:26 +00:00

Owner

Yes, we only need unsupported old. We can keep the strinngs as is for later use.

6543 commented

2020-06-03 17:12:46 +00:00

Author

Member

I'll make a smal cleanup ...

mmarif commented

2020-06-03 17:13:07 +00:00

Owner

Ok, I will wait for it.

6543 commented

2020-06-03 17:13:27 +00:00

Author

Member

OK I have looked throu and cleanup is not nessesary but i had two changes - if they are ok for you then we can merge :)

6543 commented

2020-06-03 17:13:47 +00:00

Author

Member

@mmarif can yu squath-merge ?

mmarif commented

2020-06-03 17:14:07 +00:00

Owner

@6543 Ok, I will squash.

New Gitea version detected! Please UPDATE GitNex!, how we know what version of GitNex user have to tell them to update?
We only check for Gitea versions.

Maybe I am missing something here, can you tell how it will work?

@6543 Ok, I will squash. `New Gitea version detected! Please UPDATE GitNex!`, how we know what version of GitNex user have to tell them to update? We only check for Gitea versions. Maybe I am missing something here, can you tell how it will work?

mmarif commented

2020-06-03 17:14:27 +00:00

Owner

So if I am on gitea.com, I will be seeing that message. Am I right?

6543 commented

2020-06-03 17:14:47 +00:00

Author

Member

for others to read: answer: no ;)

[Pull] Version Check before try to Login #147