App crashes when accessing empty repository #154

New Issue

Closed

opened 2020-06-03 17:25:20 +00:00 by 6543 · 15 comments

6543 commented

2020-06-03 17:25:20 +00:00

Member

Created By: @otterz

Description - describe the bug / feature / suggestion in brief :

App crashes when accessing empty repository.

Expected behaviour - describe what should be the expected result :

Display "Empty repository" or "No files"

GitNex version : 2.2.0 build 70

Gitea version : 1.9.3

Android version : 9

Screenshots - if any:

None

Logs - if any :

Can be provided if necessary.

Created By: @otterz #### Description - describe the bug / feature / suggestion in brief : App crashes when accessing empty repository. #### Expected behaviour - describe what should be the expected result : Display "Empty repository" or "No files" #### GitNex version : 2.2.0 build 70 #### Gitea version : 1.9.3 #### Android version : 9 #### Screenshots - if any: None #### Logs - if any : Can be provided if necessary.

6543 added the

🐛 Bug

🪜 Upstream

labels 2020-06-03 17:25:21 +00:00

6543 closed this issue

2020-06-03 17:25:21 +00:00

mmarif commented

2020-06-03 17:26:01 +00:00

Owner

Thank you @otterz for the report.

Let me confirm, so the repository you access is empty(no files at all) which crash the app?

Thank you @otterz for the report. Let me confirm, so the repository you access is empty(no files at all) which crash the app?

6543 commented

2020-06-03 17:26:21 +00:00

Author

Member

Created By: @otterz

Yes, it's a fresh and empty repository with no data.

Created By: @otterz Yes, it's a fresh and empty repository with no data.

mmarif commented

2020-06-03 17:26:41 +00:00

Owner

I did some quick tests on empty repository, and yes the app crash but not because of the empty files list. But because of the API 500 internal server which it should not return.

Although, I will fix this from the app side. Would you help create an issue in Gitea repository too, so they can fix this. I will chime in and provide necessary details where necessary.

I did some quick tests on empty repository, and yes the app crash but not because of the empty files list. But because of the API `500 internal server` which it should not return. Although, I will fix this from the app side. Would you help create an issue in Gitea repository too, so they can fix this. I will chime in and provide necessary details where necessary.

mmarif commented

2020-06-03 17:27:02 +00:00

Owner

@6543 can you help with this in the upstream Gitea repo. The contents API return 500 when repository is empty.

6543 commented

2020-06-03 17:27:22 +00:00

Author

Member

@mmarif so now we need release tag 2.2.1 :=)

mmarif commented

2020-06-03 17:27:42 +00:00

Owner

Yes, soon will be available.

About the API error, the status code is 500 with the following error. To me status code should be different and when repo is empty, just return the empty files object.

{
  "message": "object does not exist [id: master, rel_path: ]",
  "url": "https://try.gitea.io/api/swagger"
}

Yes, soon will be available. About the API error, the status code is 500 with the following error. To me status code should be different and when repo is empty, just return the empty files object. ``` { "message": "object does not exist [id: master, rel_path: ]", "url": "https://try.gitea.io/api/swagger" } ```

6543 commented

2020-06-03 17:28:02 +00:00

Author

Member

https://github.com/go-gitea/gitea/issues/8582