ReUse strings #169

Closed
opened 2020-06-03 21:42:20 +00:00 by 6543 · 7 comments
Member

reduce redundancy at string.xml

reduce redundancy at string.xml
6543 added this to the 2.3.0 milestone 2020-06-03 21:42:20 +00:00
6543 added the
🌐 Translation
label 2020-06-03 21:42:20 +00:00
6543 closed this issue 2020-06-03 21:42:20 +00:00
6543 self-assigned this 2020-06-03 21:43:00 +00:00
Author
Member

@mmarif sthings like "cancle" or "ok" should have a general identyfier to reuse in different dialogs and so on

@mmarif sthings like "cancle" or "ok" should have a general identyfier to reuse in different dialogs and so on
Owner

Thanks, you are right. Common strings should be not be repeated.

Thanks, you are right. Common strings should be not be repeated.
Owner

Actually the strings.xml file has some of them already. Last time I added, but we need to make sure it does not repeat like I did in version check. 😄

I will remove them in the token PR.

<!-- generic copy -->
    <string name="okButton">OK</string>
    <string name="doneButton">Done</string>
    <string name="cancelButton">Cancel</string>
    <string name="genericError">Something went wrong, please try again</string>
    <string name="apiNotFound">This request needs higher Gitea version than the one installed. Please upgrade your instance to the latest version of Gitea.</string>
    <string name="noDataFound">No data found</string>
    <string name="addButton">Add</string>
    <string name="removeButton">Remove</string>
    <string name="authorizeError">You are not authorized to perform this action.</string>
    <string name="menuContentDesc">Menu</string>
    <string name="menuEditText">Edit</string>
    <string name="menuDeleteText">Delete</string>
    <string name="colorfulBulletSpan" translatable="false">\u0020\u0020\u0020\u25CF\u0020\u0020\u0020</string>
    <string name="modifiedText">edited</string>
    <string name="saveButton">Save</string>
    <string name="defaultFilename" translatable="false">README.md</string>
    <string name="defaultFilenameText" translatable="false">README</string>
    <string name="nameText">Name</string>
    <string name="descriptionText">Description</string>
    <string name="websiteText">Website</string>
    <string name="locationText">Location</string>
    <string name="characters255Limit">Max 255 characters</string>
    <string name="emptyFields">All fields are required</string>
    <!-- generic copy -->
Actually the strings.xml file has some of them already. Last time I added, but we need to make sure it does not repeat like I did in version check. :smile: I will remove them in the token PR. ``` <!-- generic copy --> <string name="okButton">OK</string> <string name="doneButton">Done</string> <string name="cancelButton">Cancel</string> <string name="genericError">Something went wrong, please try again</string> <string name="apiNotFound">This request needs higher Gitea version than the one installed. Please upgrade your instance to the latest version of Gitea.</string> <string name="noDataFound">No data found</string> <string name="addButton">Add</string> <string name="removeButton">Remove</string> <string name="authorizeError">You are not authorized to perform this action.</string> <string name="menuContentDesc">Menu</string> <string name="menuEditText">Edit</string> <string name="menuDeleteText">Delete</string> <string name="colorfulBulletSpan" translatable="false">\u0020\u0020\u0020\u25CF\u0020\u0020\u0020</string> <string name="modifiedText">edited</string> <string name="saveButton">Save</string> <string name="defaultFilename" translatable="false">README.md</string> <string name="defaultFilenameText" translatable="false">README</string> <string name="nameText">Name</string> <string name="descriptionText">Description</string> <string name="websiteText">Website</string> <string name="locationText">Location</string> <string name="characters255Limit">Max 255 characters</string> <string name="emptyFields">All fields are required</string> <!-- generic copy --> ```
Author
Member

I'll take care of crowdin after PR ...

I'll take care of crowdin after PR ...
Owner

@6543 does this issue still need a PR to remove/add the strings?

@6543 does this issue still need a PR to remove/add the strings?
Author
Member

I think if we move to mouch strings around now we will lose a lot of translations & generate a lot of work 👎 so I'll close this

I think if we move to mouch strings around now we will lose a lot of translations & generate a lot of work :-1: so I'll close this
Owner

Yes, I agree.

Yes, I agree.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#169
No description provided.