#169 ReUse strings

Closed
opened 7 months ago by 6543 · 7 comments
6543 commented 7 months ago

reduce redundancy at string.xml

reduce redundancy at string.xml
6543 self-assigned this 7 months ago
6543 added the
Translation
label 7 months ago
6543 commented 7 months ago
Poster

@mmarif sthings like “cancle” or “ok” should have a general identyfier to reuse in different dialogs and so on

@mmarif sthings like "cancle" or "ok" should have a general identyfier to reuse in different dialogs and so on
mmarif commented 7 months ago
Owner

Thanks, you are right. Common strings should be not be repeated.

Thanks, you are right. Common strings should be not be repeated.
mmarif commented 7 months ago
Owner

Actually the strings.xml file has some of them already. Last time I added, but we need to make sure it does not repeat like I did in version check. 😄

I will remove them in the token PR.

<!-- generic copy -->
    <string name="okButton">OK</string>
    <string name="doneButton">Done</string>
    <string name="cancelButton">Cancel</string>
    <string name="genericError">Something went wrong, please try again</string>
    <string name="apiNotFound">This request needs higher Gitea version than the one installed. Please upgrade your instance to the latest version of Gitea.</string>
    <string name="noDataFound">No data found</string>
    <string name="addButton">Add</string>
    <string name="removeButton">Remove</string>
    <string name="authorizeError">You are not authorized to perform this action.</string>
    <string name="menuContentDesc">Menu</string>
    <string name="menuEditText">Edit</string>
    <string name="menuDeleteText">Delete</string>
    <string name="colorfulBulletSpan" translatable="false">\u0020\u0020\u0020\u25CF\u0020\u0020\u0020</string>
    <string name="modifiedText">edited</string>
    <string name="saveButton">Save</string>
    <string name="defaultFilename" translatable="false">README.md</string>
    <string name="defaultFilenameText" translatable="false">README</string>
    <string name="nameText">Name</string>
    <string name="descriptionText">Description</string>
    <string name="websiteText">Website</string>
    <string name="locationText">Location</string>
    <string name="characters255Limit">Max 255 characters</string>
    <string name="emptyFields">All fields are required</string>
    <!-- generic copy -->
Actually the strings.xml file has some of them already. Last time I added, but we need to make sure it does not repeat like I did in version check. :smile: I will remove them in the token PR. ``` <!-- generic copy --> <string name="okButton">OK</string> <string name="doneButton">Done</string> <string name="cancelButton">Cancel</string> <string name="genericError">Something went wrong, please try again</string> <string name="apiNotFound">This request needs higher Gitea version than the one installed. Please upgrade your instance to the latest version of Gitea.</string> <string name="noDataFound">No data found</string> <string name="addButton">Add</string> <string name="removeButton">Remove</string> <string name="authorizeError">You are not authorized to perform this action.</string> <string name="menuContentDesc">Menu</string> <string name="menuEditText">Edit</string> <string name="menuDeleteText">Delete</string> <string name="colorfulBulletSpan" translatable="false">\u0020\u0020\u0020\u25CF\u0020\u0020\u0020</string> <string name="modifiedText">edited</string> <string name="saveButton">Save</string> <string name="defaultFilename" translatable="false">README.md</string> <string name="defaultFilenameText" translatable="false">README</string> <string name="nameText">Name</string> <string name="descriptionText">Description</string> <string name="websiteText">Website</string> <string name="locationText">Location</string> <string name="characters255Limit">Max 255 characters</string> <string name="emptyFields">All fields are required</string> <!-- generic copy --> ```
6543 commented 7 months ago
Poster

I’ll take care of crowdin after PR ...

I'll take care of crowdin after PR ...
mmarif commented 6 months ago
Owner

@6543 does this issue still need a PR to remove/add the strings?

@6543 does this issue still need a PR to remove/add the strings?
6543 commented 6 months ago
Poster

I think if we move to mouch strings around now we will lose a lot of translations & generate a lot of work 👎 so I’ll close this

I think if we move to mouch strings around now we will lose a lot of translations & generate a lot of work :-1: so I'll close this
6543 closed this issue 6 months ago
mmarif commented 6 months ago
Owner

Yes, I agree.

Yes, I agree.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.