More Specific token name #179

New Issue

Closed

opened 2020-06-03 21:57:40 +00:00 by 6543 · 5 comments

6543 commented

2020-06-03 21:57:40 +00:00

Member

if https://github.com/go-gitea/gitea/pull/7135 is merged ... GitNex will have problem with mulit device support!

-> we sould use token-name based on "GitNex-" or something like that ...

if https://github.com/go-gitea/gitea/pull/7135 is merged ... GitNex will have problem with mulit device support! -> we sould use token-name based on "GitNex-"<deviceID> or something like that ...

6543 added the

🚀 Improvement

label 2020-06-03 21:57:40 +00:00

6543 closed this issue

2020-06-03 21:57:40 +00:00

6543 self-assigned this 2020-06-03 21:58:20 +00:00

mmarif was assigned by 6543

2020-06-03 21:58:20 +00:00

mmarif commented

2020-06-03 21:58:21 +00:00

Owner

Thanks for the heads up on this.

How about update/refresh the token instead of straight throwing an error?, From the code it looks like it will not allow you to create or update token with the same name anymore.

Update token is more relevant in this case.

Thanks for the heads up on this. How about update/refresh the token instead of straight throwing an error?, From the code it looks like it will not allow you to create or update token with the same name anymore. Update token is more relevant in this case.

mmarif commented

2020-06-03 21:58:41 +00:00

Owner

Or maybe I am wrong as the token does not expire.

GitNex will have problem with mulit device support!

Yes, need to think about it.

Or maybe I am wrong as the token does not expire. > GitNex will have problem with mulit device support! Yes, need to think about it.

6543 commented

2020-06-03 21:59:01 +00:00

Author

Member

I'll take a look at this - doesn't sound time consuming ...

I'll take a look at this - doesn't sound time consuming ...

6543 commented

2020-06-03 21:59:21 +00:00

Author

Member

I made a draft PR #184

I made a draft PR #184

mmarif commented

2020-06-03 21:59:41 +00:00

Owner

Close via #184

Close via #184

6543 referenced this issue

2020-06-03 22:06:10 +00:00

[Pull] tocken name with Device ID #184

Sign in to join this conversation.

No Label

⌚ Major-release

⌚ Minor-release

⛏️ Breaking

➡️ Frontport

➡️ Needs-frontport

💭 Brainstorming

🔭 Cannot-reproduce

💬 Discussion

📄 Documentation

🎯 Enhancement

🩹 External-dependecy

👋 Good-first-issue

🤾 Google-play

🔙 Has-backport

🚀 Improvement

🚨 Investigate

🔙 Needs-backport

🧺 Needs-cleanup

📡 Needs-feedback

📈 Performance

📌 Priority-critical

📌 Priority-high

📍 Priority-low

📍 Priority-medium

🔙 Regression

💡 Suggestion

🌐 Translation

🙇‍♂️ Needs-help

🛰️ API-dependency

🛡️ Blocked

🗒️ Changelog

🗄️ Repository

🗓️ Summary

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#179

No description provided.