[File Viewer] Support pdf files #181

New Issue

Closed

opened 2020-06-03 22:00:44 +00:00 by mmarif · 10 comments

mmarif commented

2020-06-03 22:00:44 +00:00

Owner

Came up in issue #175

mmarif added this to the 2.4.0 milestone 2020-06-03 22:00:44 +00:00

mmarif added the

🎉 Feature

label 2020-06-03 22:00:44 +00:00

mmarif closed this issue

2020-06-03 22:00:44 +00:00

6543 commented

2020-06-03 22:01:25 +00:00

Member

@s4ne here it is ;)

6543 commented

2020-06-03 22:01:45 +00:00

Member

Created By: @s4ne

Wow, thank you so much! (:

Created By: @s4ne Wow, thank you so much! (:

6543 commented

2020-06-03 22:02:05 +00:00

Member

@s4ne suscribe to this issue to stay informed ;)

at the moment this wont happen automaticaly

@s4ne suscribe to this issue to stay informed ;) at the moment this wont happen automaticaly

mmarif commented

2020-06-03 22:02:25 +00:00

Author

Owner

Tested this library, works like a charm but the size is big minus for me.

https://github.com/barteksc/AndroidPdfViewer

APK size FAQ

https://github.com/barteksc/AndroidPdfViewer#why-resulting-apk-is-so-big

I have a test branch on local system for pdf files and the interesting part is the generated APK have bunch of heavy libraries now which made it around 23MB in size. That's huge by the standard of GitNex which is around 4MB right now. Tested this library, works like a charm but the size is big minus for me. https://github.com/barteksc/AndroidPdfViewer APK size FAQ https://github.com/barteksc/AndroidPdfViewer#why-resulting-apk-is-so-big

6543 commented

2020-06-03 22:02:45 +00:00

Member

https://f-droid.org/en/packages/org.sufficientlysecure.viewer/ -> 9MB

two options: use other apps do display files
or find a lighweight lib @mmarif

https://f-droid.org/en/packages/org.sufficientlysecure.viewer/ -> 9MB two options: use other apps do display files or find a lighweight lib @mmarif

mmarif commented

2020-06-03 22:03:05 +00:00

Author

Owner

It depends on the library used. I am still looking for best solution though.

If you find any, please share here.

It depends on the library used. I am still looking for best solution though. If you find any, please share here.

mmarif commented

2020-06-03 22:03:25 +00:00

Author

Owner

use other apps do display files or find a lighweight lib

I am looking for lightweight lib to include in the app. Otherwise use other app like Document viewer to view the files after download.

But priority is to include in the app. 😄

> use other apps do display files or find a lighweight lib I am looking for lightweight lib to include in the app. Otherwise use other app like Document viewer to view the files after download. But priority is to include in the app. :smile:

6543 commented

2020-06-03 22:03:45 +00:00

Member

Created By: @lcnittl

I hope this fits this issue: Do you think it is possible to initiate a download for binaries that cannot be shown inside the app (I am thinking of pdf (as long as there is no in-app preview), eps, docx, etc)? Then the OS can take care of it.

Probably worth another issue, but could this also allow LFS support (currently the pointer is shown in plain text with no option to download the raw file)

Created By: @lcnittl I hope this fits this issue: Do you think it is possible to initiate a _download_ for binaries that cannot be shown inside the app (I am thinking of pdf (as long as there is no in-app preview), eps, docx, etc)? Then the OS can take care of it. Probably worth another issue, but could this also allow LFS support (currently the pointer is shown in plain text with no option to download the _raw_ file)

6543 commented

2020-06-03 22:04:05 +00:00

Member

@lcnittl create a new issue for this

mmarif commented

2020-06-03 22:04:26 +00:00

Author

Owner

@lcnittl I totally agree to download files. More from me is here https://gitea.com/gitnex/GitNex/issues/254

On PDF, as I could not find any other library so I will stick with the feature rich PDF library. It will make the app size little bigger but I beleive it is worth it.

@lcnittl I totally agree to download files. More from me is here https://gitea.com/gitnex/GitNex/issues/254 On PDF, as I could not find any other library so I will stick with the feature rich PDF library. It will make the app size little bigger but I beleive it is worth it.

mmarif referenced this issue

2020-06-04 00:12:52 +00:00

[Pull] Support pdf files in file viewer #259