#181 [File Viewer] Support pdf files

Stängd
öppnade 5 månader sedan av mmarif · 10 kommentarer
mmarif kommenterad 5 månader sedan

Came up in issue #175

Came up in issue #175
mmarif added the
Feature
label 5 månader sedan
6543 kommenterad 5 månader sedan
Deltagare

@s4ne here it is ;)

@s4ne here it is ;)
s4ne kommenterad 5 månader sedan

Wow, thank you so much! (:

Wow, thank you so much! (:
6543 kommenterad 5 månader sedan
Deltagare

@s4ne suscribe to this issue to stay informed ;)

at the moment this wont happen automaticaly

@s4ne suscribe to this issue to stay informed ;) at the moment this wont happen automaticaly
mmarif kommenterad 5 månader sedan
Ägare

I have a test branch on local system for pdf files and the interesting part is the generated APK have bunch of heavy libraries now which made it around 23MB in size. That’s huge by the standard of GitNex which is around 4MB right now.

Tested this library, works like a charm but the size is big minus for me.

https://github.com/barteksc/AndroidPdfViewer

APK size FAQ

https://github.com/barteksc/AndroidPdfViewer#why-resulting-apk-is-so-big

I have a test branch on local system for pdf files and the interesting part is the generated APK have bunch of heavy libraries now which made it around 23MB in size. That's huge by the standard of GitNex which is around 4MB right now. Tested this library, works like a charm but the size is big minus for me. https://github.com/barteksc/AndroidPdfViewer APK size FAQ https://github.com/barteksc/AndroidPdfViewer#why-resulting-apk-is-so-big
6543 kommenterad 5 månader sedan
Deltagare

https://f-droid.org/en/packages/org.sufficientlysecure.viewer/ -> 9MB

two options: use other apps do display files or find a lighweight lib @mmarif

https://f-droid.org/en/packages/org.sufficientlysecure.viewer/ -> 9MB two options: use other apps do display files or find a lighweight lib @mmarif
mmarif kommenterad 5 månader sedan
Ägare

It depends on the library used. I am still looking for best solution though.

If you find any, please share here.

It depends on the library used. I am still looking for best solution though. If you find any, please share here.
mmarif kommenterad 5 månader sedan
Ägare

use other apps do display files or find a lighweight lib

I am looking for lightweight lib to include in the app. Otherwise use other app like Document viewer to view the files after download.

But priority is to include in the app. :smile:

> use other apps do display files or find a lighweight lib I am looking for lightweight lib to include in the app. Otherwise use other app like Document viewer to view the files after download. But priority is to include in the app. :smile:

I hope this fits this issue: Do you think it is possible to initiate a download for binaries that cannot be shown inside the app (I am thinking of pdf (as long as there is no in-app preview), eps, docx, etc)? Then the OS can take care of it.

Probably worth another issue, but could this also allow LFS support (currently the pointer is shown in plain text with no option to download the raw file)

I hope this fits this issue: Do you think it is possible to initiate a _download_ for binaries that cannot be shown inside the app (I am thinking of pdf (as long as there is no in-app preview), eps, docx, etc)? Then the OS can take care of it. Probably worth another issue, but could this also allow LFS support (currently the pointer is shown in plain text with no option to download the _raw_ file)
6543 kommenterad 2 månader sedan
Deltagare

@lcnittl create a new issue for this

@lcnittl create a new issue for this
mmarif kommenterad 2 månader sedan
Ägare

@lcnittl I totally agree to download files. More from me is here #254

On PDF, as I could not find any other library so I will stick with the feature rich PDF library. It will make the app size little bigger but I beleive it is worth it.

@lcnittl I totally agree to download files. More from me is here https://gitea.com/gitnex/GitNex/issues/254 On PDF, as I could not find any other library so I will stick with the feature rich PDF library. It will make the app size little bigger but I beleive it is worth it.
mmarif lade till denna till milstolpe 2.4.0 2 månader sedan
Logga in för att delta i denna konversation.
Ingen Milsten
No Assignees
4 Deltagare
Förfallodatum

Inget förfallodatum satt.

Beroenden

This issue currently doesn't have any dependencies.

Laddar…
Avbryt
Spara
Det finns inget innehåll än.