[Pull] Offline mode #190

New Issue

Closed

opened 2020-06-03 22:15:40 +00:00 by mmarif · 19 comments

mmarif commented

2020-06-03 22:15:40 +00:00

Owner

Closes #186

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/190

Merged with: b6c0e94ee9

Closes #186 --- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/190 Merged with: b6c0e94ee9afef02eb400e7f2724d66844ae862e

mmarif added this to the 2.3.0 milestone 2020-06-03 22:15:40 +00:00

mmarif added the

🎉 Feature

label 2020-06-03 22:15:40 +00:00

mmarif closed this issue

2020-06-03 22:15:40 +00:00

mmarif was assigned by 6543

2020-06-03 22:16:21 +00:00

6543 commented

2020-06-03 22:16:21 +00:00

Member

So RetroFit has already a cache function ...

mmarif commented

2020-06-03 22:16:41 +00:00

Author

Owner

Yes, it has using okhttp as interceptor.

6543 commented

2020-06-03 22:17:01 +00:00

Member

@mmarif it doesnt cache repo lists (stared repos, my repos, ...) and user avatars

but files if opend before work offline now (if you stay in a repo) 👍

@mmarif it doesnt cache repo lists (stared repos, my repos, ...) and user avatars but files if opend before work offline now (if you stay in a repo) :+1:

mmarif commented

2020-06-03 22:17:21 +00:00

Author

Owner

What process you carried out to test.

You should have network when open the app and browse around the pages so the app can cache the contents. After that turn off network and you will be able to see the cached contents.

What process you carried out to test. You should have network when open the app and browse around the pages so the app can cache the contents. After that turn off network and you will be able to see the cached contents.

6543 commented

2020-06-03 22:17:42 +00:00

Member

@mmarif yes this works but offline mode in my definition is, once you cached the files, you should be able to close the app, switch off internet and then browse cached repos

mmarif commented

2020-06-03 22:18:02 +00:00

Author

Owner

Not sure why its not working for you. I have made a video a while ago. Check if its what you want.

https://peertube.social/videos/watch/000a8348-b180-47d4-8775-4b924f80d7c1

Not sure why its not working for you. I have made a video a while ago. Check if its what you want. https://peertube.social/videos/watch/000a8348-b180-47d4-8775-4b924f80d7c1

6543 commented

2020-06-03 22:18:22 +00:00

Member

@mmarif - the cache is only used if contend has fully loaded (was my first problem)

Second:

@mmarif - the cache is only used if contend has fully loaded (was my first problem) Second:

6543 commented

2020-06-03 22:18:42 +00:00

Member

Test Device: pisikal, android 9.0.9

6543 commented

2020-06-03 22:19:02 +00:00

Member

Org avatars too

6543 commented

2020-06-03 22:19:22 +00:00

Member

I'll test again ...

mmarif commented

2020-06-03 22:19:42 +00:00

Author

Owner

@6543 how was your test?

6543 commented

2020-06-03 22:20:02 +00:00

Member

One thing still not work ...

6543 commented

2020-06-03 22:20:23 +00:00

Member

ONLINE mode:

Without	With PR

Tested with: emulated Android & physical device

ONLINE mode: Without | With PR ---- | ---- ![](https://user-images.githubusercontent.com/24977596/68765499-328ad900-061d-11ea-946c-a4059ea888cb.png) | ![](https://user-images.githubusercontent.com/24977596/68765497-30c11580-061d-11ea-97bb-b34265ce1e7c.png) Tested with: emulated Android & physical device

mmarif commented

2020-06-03 22:20:43 +00:00

Author

Owner

So the name does not show in the Online mode in this PR, am I right?

Do you have full name in your profile saved bdw?

So the name does not show in the Online mode in this PR, am I right? Do you have full name in your profile saved bdw?

6543 commented

2020-06-03 22:21:03 +00:00

Member

Do you have full name in your profile saved bdw?

> Do you have full name in your profile saved bdw? No

6543 commented

2020-06-03 22:21:23 +00:00

Member

{
    "login": "6543",
    "full_name": "",
    "avatar_url": "https://gitea.com/user/avatar/6543/-1",
    "language": "",
    "is_admin": false,
    "username": "6543"
}

...

```json { "login": "6543", "full_name": "", "avatar_url": "https://gitea.com/user/avatar/6543/-1", "language": "", "is_admin": false, "username": "6543" } ``` ...

mmarif commented

2020-06-03 22:21:43 +00:00

Author

Owner

I haven't checked that part of the code yet, but can you add full name and see if it is working.

I will check after that to make sure it pick username/login if full name is empty.

I haven't checked that part of the code yet, but can you add full name and see if it is working. I will check after that to make sure it pick username/login if full name is empty.

6543 commented

2020-06-03 22:22:03 +00:00

Member

@mmarif checked

you are right - this text field has no fallback to login name!

@mmarif checked you are right - this text field has no fallback to login name!

6543 commented

2020-06-03 22:22:23 +00:00

Member

@mmarif done -> fc27f7c73d

@mmarif done -> fc27f7c73dab90933671998e6d7509bf2ebd65d2