API call of asignees #196

New Issue

Closed

opened 2020-06-03 22:33:16 +00:00 by 6543 · 4 comments

6543 commented

2020-06-03 22:33:16 +00:00

Member

"assignee": "string" is deprecated

use "assignees": [ "string" ] instead

-> use at creat issue and more?

`"assignee": "string"` is deprecated use `"assignees": [ "string" ]` instead -> use at creat issue and more?

6543 added this to the 2.4.0 milestone 2020-06-03 22:33:16 +00:00

6543 added the

🪒 Refactor

label 2020-06-03 22:33:16 +00:00

6543 closed this issue

2020-06-03 22:33:16 +00:00

6543 self-assigned this 2020-06-03 22:33:56 +00:00

mmarif commented

2020-06-03 22:33:57 +00:00

Owner

@6543 assignee is removed from the APIs?

Which version of Gitea will have this in effect?

If you check the Issues model, it have both assignee and assignees.

https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/models/Issues.java

At most it will effect creating new issue because the assignee object is required.

@6543 `assignee` is removed from the APIs? Which version of Gitea will have this in effect? If you check the Issues model, it have both assignee and assignees. https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/models/Issues.java At most it will effect creating new issue because the assignee object is required.

6543 commented

2020-06-03 22:34:17 +00:00

Author

Member

It wont be removed - it's not recomend to use it ...

I rewrote the function who parse this ... gitea/#8873

And noticed that assignee is only for backwarts compatibilety ...

So:

switch to assignees only
asign the current user when creating a issue should be optional (noticed at debugging ...)
- current user should be selectable at assignees list
- remove default asign ...

It wont be removed - it's not recomend to use it ... I rewrote the function who parse this ... [gitea/#8873](https://github.com/go-gitea/gitea/pull/8873) And noticed that assignee is only for backwarts compatibilety ... So: * [ ] switch to `assignees` only * [ ] asign the current user when creating a issue should be optional (noticed at debugging ...) - current user should be selectable at assignees list - remove default asign ...

mmarif commented

2020-06-03 22:34:37 +00:00

Owner

It need to be implemented that way to not break the current flow for old versions as that PR is merged to 1.11 and assignee is required for old versions(even it should not as you mentioned).

But it is not really a required thing at this moment. If we don't implement it until 1.11 release, anything will break?

We can make it optional, but somehow we need to know the API accept it as optional not mandatory.

asign the current user when creating a issue should be optional

This is the important bit because Gitea until 1.10 make it mandatory if I am not mistaken.

It need to be implemented that way to not break the current flow for old versions as that PR is merged to 1.11 and assignee is required for old versions(even it should not as you mentioned). But it is not really a required thing at this moment. If we don't implement it until 1.11 release, anything will break? We can make it optional, but somehow we need to know the API accept it as optional not mandatory. > asign the current user when creating a issue should be optional This is the important bit because Gitea until 1.10 make it mandatory if I am not mistaken.

6543 commented

2020-06-03 22:34:57 +00:00

Author

Member

I'll test it ... and make a PR