[Pull] Repository PR List #198

New Issue

Closed

opened 2020-06-03 22:36:19 +00:00 by mmarif · 10 comments

mmarif commented

2020-06-03 22:36:19 +00:00

Owner

Will close #8

PR list
Single pr view
DIff view

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/198

Merged with: 9f5eceff0e

Will close #8 - [x] PR list - [x] Single pr view - [x] DIff view --- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/198 Merged with: 9f5eceff0e0c7dad755ce90d048c3842b5de49a5

mmarif added this to the 2.3.0 milestone 2020-06-03 22:36:19 +00:00

mmarif added the

🎉 Feature

label 2020-06-03 22:36:19 +00:00

mmarif closed this issue

2020-06-03 22:36:20 +00:00

mmarif was assigned by 6543

2020-06-03 22:37:00 +00:00

6543 commented

2020-06-03 22:37:00 +00:00

Member

If you dont have JSON Obj "assignee" gitea API ignore this ...
-> less redundancy ...
you get the same info + more from "assignees"

If you dont have JSON Obj "assignee" gitea API ignore this ... -> less redundancy ... you get the same info + more from "assignees" related to https://gitea.com/gitnex/GitNex/issues/196

mmarif commented

2020-06-03 22:37:20 +00:00

Author

Owner

@6543 Sure, no problem. I will remove that part as it's not needed at this point.

Only thing I am worried is when creating new PR(future work) old versions of Gitea does not force assignee as mandatory. Then it will be a problem that time.

@6543 Sure, no problem. I will remove that part as it's not needed at this point. Only thing I am worried is when creating new PR(future work) old versions of Gitea does not force assignee as mandatory. Then it will be a problem that time.

6543 commented

2020-06-03 22:37:40 +00:00

Member

I think since 1.10.0 is out + 1.9.x support assignees and 1.8.x or below is riscy to use (securety ...) and the api stucture is not the same! (https://github.com/go-gitea/gitea/tree/release/v1.9/modules/structs) vs (https://github.com/go-gitea/gitea/tree/release/v1.8/modules/structs) we can drop this for next release I dont like to support 1.8.x and below! and 1.11.0 is on the way because a lot of refactoring has happend the next majior release is going out fast ...

I think since 1.10.0 is out + 1.9.x support assignee**s** and 1.8.x or below is riscy to use (securety ...) and the api stucture is not the same! (https://github.com/go-gitea/gitea/tree/release/v1.9/modules/structs) vs (https://github.com/go-gitea/gitea/tree/release/v1.8/modules/structs) we can drop this for next release I dont like to support 1.8.x and below! and 1.11.0 is on the way because a lot of refactoring has happend the next majior release is going out fast ...

mmarif commented

2020-06-03 22:38:01 +00:00

Author

Owner

@6543 I have removed assignee from model.

This PR is ready for testing.

Things to note:

Single PR comments view is not part of this PR. Only list of PRs.

Edit: There is not much difference of issue view and pr view, so will add single view for pr later in this PR.

@6543 I have removed assignee from model. This PR is ready for testing. Things to note: - Single PR comments view is not part of this PR. Only list of PRs. Edit: There is not much difference of issue view and pr view, so will add single view for pr later in this PR.

6543 commented

2020-06-03 22:38:21 +00:00

Member

think two things have to implemented to be usefull again:

PR single view
PR count on the top of the tab (like at issues)

optional

unified way to display closed issues/PR
- closed issues have it's own tab
- closed PR are not visible anymore

think two things have to implemented to be usefull again: * [ ] PR single view * [ ] PR count on the top of the tab (like at issues) optional * [ ] unified way to display closed issues/PR - closed issues have it's own tab - closed PR are not visible anymore

mmarif commented

2020-06-03 22:38:41 +00:00

Author

Owner

Yes, I will add single view.

I forgot about the count, thanks for the reminder.

Closed pr, will add in another pr.

Yes, I will add single view. I forgot about the count, thanks for the reminder. Closed pr, will add in another pr.

mmarif commented

2020-06-03 22:39:01 +00:00

Author

Owner

Adding counter is very tricky for PRs as the repo info does not provide the counter. And PR API return paged records.

Maybe adding it to the API /api/v1/repos/OWNER/REPO is best?

"open_pr_counter" : 2

Adding counter is very tricky for PRs as the repo info does not provide the counter. And PR API return paged records. Maybe adding it to the API `/api/v1/repos/OWNER/REPO` is best? ``` "open_pr_counter" : 2 ```

6543 commented

2020-06-03 22:39:21 +00:00

Member

@mmarif I'll look into this (PR counter)