[Pull] Refactor assignee(s) API calls #199

New Issue

Closed

opened 2020-06-03 22:40:23 +00:00 by 6543 · 11 comments

6543 commented

2020-06-03 22:40:23 +00:00

Member

close https://gitea.com/gitnex/GitNex/issues/196

remove assignee
add user to the "new issue" assignees dialog

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/199

Merged with: 3f4db112b1

close https://gitea.com/gitnex/GitNex/issues/196 * [x] remove assignee * [x] add user to the "new issue" assignees dialog --- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/199 Merged with: 3f4db112b19b7335d38f147a4d806df07b0bd1f7

6543 added this to the 2.4.0 milestone 2020-06-03 22:40:23 +00:00

6543 added the

🪒 Refactor

label 2020-06-03 22:40:23 +00:00

6543 closed this issue

2020-06-03 22:40:23 +00:00

6543 self-assigned this 2020-06-03 22:41:04 +00:00

6543 commented

2020-06-03 22:41:04 +00:00

Author

Member

@mmarif ready to review

mmarif commented

2020-06-03 22:41:24 +00:00

Owner

I have just tried to create new issue and the app crashes with error. I am on 1.9.x.

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mian.gitnex/org.mian.gitnex.activities.CreateIssueActivity}: java.lang.NumberFormatException: For input string: "mmarif"

Error line listOfAssignees.add(new MultiSelectModel(Integer.valueOf(loginUid), loginFullName)); in CreateIssueActivity.

I can create an account for you on my instance if you want to test on it.

I have just tried to create new issue and the app crashes with error. I am on 1.9.x. `java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mian.gitnex/org.mian.gitnex.activities.CreateIssueActivity}: java.lang.NumberFormatException: For input string: "mmarif"` Error line `listOfAssignees.add(new MultiSelectModel(Integer.valueOf(loginUid), loginFullName));` in CreateIssueActivity. I can create an account for you on my instance if you want to test on it.

6543 commented

2020-06-03 22:41:44 +00:00

Author

Member

I can create an account for you on my instance if you want to test on it.

Ok 👍

> I can create an account for you on my instance if you want to test on it. Ok :+1:

mmarif commented

2020-06-03 22:42:04 +00:00

Owner

Tested on 1.10 and have the same effect. Crash.

mmarif commented

2020-06-03 22:42:25 +00:00

Owner

I am thinking of releasing 2.3.0 after adding #10 . Do you think we can still merge this PR after your rework? otherwise can push to next release.

6543 commented

2020-06-03 22:42:45 +00:00

Author

Member

I have just tried to create new issue and the app crashes with error. I am on 1.9.x.

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mian.gitnex/org.mian.gitnex.activities.CreateIssueActivity}: java.lang.NumberFormatException: For input string: "mmarif"

Error line listOfAssignees.add(new MultiSelectModel(Integer.valueOf(loginUid), loginFullName)); in CreateIssueActivity.

I can create an account for you on my instance if you want to test on it.

I looked at the error-msg again ... I think this has nothing to do with the gitea-instance.

I add the loged in user to the list of users you can select to assign. and use loginUid as user.ID but it looks like the thyniyDB stores the loginName rather than the ID in this field

> I have just tried to create new issue and the app crashes with error. I am on 1.9.x. > > `java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mian.gitnex/org.mian.gitnex.activities.CreateIssueActivity}: java.lang.NumberFormatException: For input string: "mmarif"` > > Error line `listOfAssignees.add(new MultiSelectModel(Integer.valueOf(loginUid), loginFullName));` in CreateIssueActivity. > > I can create an account for you on my instance if you want to test on it. I looked at the error-msg again ... I think this has nothing to do with the gitea-instance. I add the loged in user to the list of users you can select to assign. and use loginUid as user.ID but it looks like the thyniyDB stores the loginName rather than the ID in this field

mmarif commented

2020-06-03 22:43:05 +00:00

Owner

I think this has nothing to do with the gitea-instance.

Yes, it maybe unrelated to the version of Gitea.

but it looks like the thyniyDB stores the loginName rather than the ID in this field

I actually forgot what is stored in tinyDB. 😵

But if you have time to fix this, let me know I will test when it's ready. 👍

> I think this has nothing to do with the gitea-instance. Yes, it maybe unrelated to the version of Gitea. > but it looks like the thyniyDB stores the loginName rather than the ID in this field I actually forgot what is stored in tinyDB. :dizzy_face: But if you have time to fix this, let me know I will test when it's ready. :thumbsup:

6543 commented

2020-06-03 22:43:25 +00:00

Author

Member

@mmarif we realy need a documentation of the ThinyDB :/