Skip version check if api is restricted #213

New Issue

6543 · 2020-06-03T22:59:07Z

6543 commented

2020-06-03 22:59:07 +00:00

Created By: @Unpublished

Description - describe the bug / feature / suggestion in brief :

After pressing login, the button keeps saying "Processing..."

Expected behaviour - describe what should be the expected result :

I can login :)

GitNex version :

master

Possible solution: https://gitea.com/Unpublished/GitNex/src/branch/allowRestrictedApi

Created By: @Unpublished #### Description - describe the bug / feature / suggestion in brief : After pressing login, the button keeps saying "Processing..." #### Expected behaviour - describe what should be the expected result : I can login :) #### GitNex version : master Possible solution: https://gitea.com/Unpublished/GitNex/src/branch/allowRestrictedApi

6543 added this to the 2.3.0 milestone 2020-06-03 22:59:07 +00:00

6543 added the

🚀 Improvement

label 2020-06-03 22:59:07 +00:00

6543 closed this issue

2020-06-03 22:59:07 +00:00

mmarif commented

2020-06-03 22:59:48 +00:00

Thank you for opening the issue.

Skip version check if api is restricted

You mean if the version api is restricted?

If yes, then your proposed solution will work.

Thank you for opening the issue. > Skip version check if api is restricted You mean if the version api is restricted? If yes, then your proposed solution will work.

6543 commented

2020-06-03 23:00:08 +00:00

Created By: @Unpublished

I think the complete api is restricted until login because of REQUIRE_SIGNIN_VIEW in app.ini.

Okay, I'll open a PR :)

Created By: @Unpublished I think the complete api is restricted until login because of `REQUIRE_SIGNIN_VIEW` in `app.ini`. Okay, I'll open a PR :)

6543 commented

2020-06-03 23:00:28 +00:00

@Unpublished by default gitea GET /version api NOT need a login!

@Unpublished by default gitea `GET /version` api NOT need a login!

mmarif commented

2020-06-03 23:00:48 +00:00

@Unpublished so after adding your solution, you can login and everything works?

Is your server public? can share the URL with us. Otherwise you can join the discord chat if you have an account there.

https://discord.gg/kuQZ6D

@Unpublished so after adding your solution, you can login and everything works? Is your server public? can share the URL with us. Otherwise you can join the discord chat if you have an account there. https://discord.gg/kuQZ6D

6543 commented

2020-06-03 23:01:08 +00:00

Created By: @Unpublished

by default gitea GET /version api NOT need a login!

Right, because REQUIRE_SIGNIN_VIEW defaults to false.

so after adding your solution, you can login and everything works

Yep, everything works with this solution.

Is your server public?

No it's local, I hope one of you has a server where he can set REQUIRE_SIGNIN_VIEW to true temporarily. If you need it to verify my PR.

Created By: @Unpublished > by default gitea GET /version api NOT need a login! Right, because [`REQUIRE_SIGNIN_VIEW`](https://docs.gitea.io/en-us/config-cheat-sheet/) defaults to false. > so after adding your solution, you can login and everything works Yep, everything works with this solution. > Is your server public? No it's local, I hope one of you has a server where he can set `REQUIRE_SIGNIN_VIEW` to true temporarily. If you need it to verify my PR.

mmarif commented

2020-06-03 23:01:28 +00:00

No it’s local, I hope one of you has a server where he can set REQUIRE_SIGNIN_VIEW to true temporarily. If you need it to verify my PR.

It's fine as this PR is not going to break anything. It will still work.

I did not know that REQUIRE_SIGNIN_VIEW also restrict version api. Good to know if thats the case.

> No it’s local, I hope one of you has a server where he can set REQUIRE_SIGNIN_VIEW to true temporarily. If you need it to verify my PR. It's fine as this PR is not going to break anything. It will still work. I did not know that `REQUIRE_SIGNIN_VIEW` also restrict version api. Good to know if thats the case.

6543 referenced this issue

2020-06-03 23:02:32 +00:00

[Pull] Allow login if api is restricted via REQUIRE_SIGNIN_VIEW #215

Sign in to join this conversation.