Show only issues in issues list #224

New Issue

Closed

opened 2020-06-03 23:21:10 +00:00 by mmarif · 6 comments

mmarif commented

2020-06-03 23:21:10 +00:00

Owner

Currently the recyclerview remove the records if it is related to PR in issues list. Scrolling should be smooth without the need to feel the rearrangement.

It affects open closed issues list.

Currently the recyclerview remove the records if it is related to PR in issues list. Scrolling should be smooth without the need to feel the rearrangement. It affects open closed issues list.

mmarif added this to the 2.5.0 milestone 2020-06-03 23:21:10 +00:00

mmarif added the

🚀 Improvement

label 2020-06-03 23:21:10 +00:00

mmarif closed this issue

2020-06-03 23:21:11 +00:00

mmarif was assigned by 6543

2020-06-03 23:21:51 +00:00

6543 self-assigned this 2020-06-03 23:21:51 +00:00

mmarif commented

2020-06-03 23:21:51 +00:00

Author

Owner

https://gitea.com/api/v1/repos/gitnex/Gitnex/issues?page=1state=open

"pull_request": {
      "merged": false,
      "merged_at": null
    },

Why?, because currently issues list screen show pr also. I have removed them in the app, but it created other problems in the adapter. It rearrange the list and it looks clunky.

Issues API : return only issues
PR API : return only prs

Check the issues list in the app, and you will see what I am talking about.

If you have any other solution, please share.

@6543 by any chance pull requests can be removed from issues list API. There is also pull requests API which do provide list of PRs. So there is no need to add same pull requests data to issues list API. https://gitea.com/api/v1/repos/gitnex/Gitnex/issues?page=1state=open ``` "pull_request": { "merged": false, "merged_at": null }, ``` Why?, because currently issues list screen show pr also. I have removed them in the app, but it created other problems in the adapter. It rearrange the list and it looks clunky. Issues API : return only issues PR API : return only prs Check the issues list in the app, and you will see what I am talking about. If you have any other solution, please share.

mmarif commented

2020-06-03 23:22:12 +00:00

Author

Owner

This is what I introduced in 2.3.0 release, but it had its own problems(mentioned above).

https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/adapters/IssuesAdapter.java#L171

This is what I introduced in 2.3.0 release, but it had its own problems(mentioned above). https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/adapters/IssuesAdapter.java#L171

6543 commented

2020-06-03 23:22:32 +00:00

Member

it is not as simple as it looks like :(

mmarif commented

2020-06-03 23:22:52 +00:00

Author

Owner

Not simple from Gitea side you mean?

I haven't dig to the code/db schema yet, but what I guess there is a field which may store the type(either issue or pr). Then in the query part can filter records by that type like how it is done in pr api.

I maybe wrong though.

Not simple from Gitea side you mean? I haven't dig to the code/db schema yet, but what I guess there is a field which may store the type(either issue or pr). Then in the query part can filter records by that type like how it is done in pr api. I maybe wrong though.

6543 commented

2020-06-03 23:23:12 +00:00

Member

of course in gitea it is easy ... but the api dont export the flag

6543 commented

2020-06-03 23:23:32 +00:00

Member

issue := models.Issue{...}
fmt.Println("bool value: %t", issue.IsPull)

``` issue := models.Issue{...} fmt.Println("bool value: %t", issue.IsPull) ```

mmarif referenced this issue

2020-06-03 23:29:22 +00:00

[Revert] Revert back showing only issues #231

mmarif referenced this issue

2020-06-04 00:56:29 +00:00

[Pull] Show only issues #294

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#224

No description provided.