Use pagination option of API calls #278

New Issue

Open

opened 2020-06-04 00:44:48 +00:00 by 6543 · 11 comments

6543 commented

2020-06-04 00:44:48 +00:00

Member

Need Gitea 1.12 and above.

repos (my repos, repos by org, all user repos, starred repos) [have pagination]
issues [have pagination]
pull requests [have pagination]
commits [have pagination]
branches (don't have pagination?)
milestones [have pagination] #384
organizations [have pagination]
Admin Users [have pagination]
Releases [have pagination] #1002
Explore repos [have pagination] #979
Explore issues [have pagination] #979
Notifications [have pagination] #979
Followers(user profile screen) [have pagination] #979
Following(user profile screen) [have pagination] #979

Need Gitea 1.12 and above. - [x] repos (my repos, repos by org, all user repos, starred repos) [have pagination] - [x] issues [have pagination] - [x] pull requests [have pagination] - [x] commits [have pagination] - [ ] branches (don't have pagination?) - [x] milestones [have pagination] #384 - [x] organizations [have pagination] - [x] Admin Users [have pagination] - [x] Releases [have pagination] #1002 - [x] Explore repos [have pagination] #979 - [x] Explore issues [have pagination] #979 - [x] Notifications [have pagination] #979 - [x] Followers(user profile screen) [have pagination] #979 - [x] Following(user profile screen) [have pagination] #979

6543 added the

🎯 Enhancement

label 2020-06-04 00:44:48 +00:00

6543 commented

2020-06-04 00:45:29 +00:00

Author

Member

came up in #273 and usable with gitea 1.12.0 -> https://github.com/go-gitea/gitea/pull/9452

mmarif commented

2020-06-04 00:45:49 +00:00

Owner

Issues, closed issues, PRs already using pagination.

Only repositories and organization does not have implementation yet.

Issues, closed issues, PRs already using pagination. Only repositories and organization does not have implementation yet.

mmarif referenced this issue

2020-06-04 05:14:33 +00:00

[Pull] Optimize fragments, add filters, fix search and clean up #439

mmarif added this to the 4.0.0 milestone 2021-06-13 18:30:14 +00:00

mmarif self-assigned this 2021-06-13 18:30:19 +00:00

mmarif modified the milestone from 4.0.0 to 4.1.0

2021-08-02 17:26:34 +00:00

mmarif referenced this issue

2021-09-23 11:49:31 +00:00

Refactors and clean up #979

mmarif referenced this issue from a commit

2021-09-29 09:29:40 +00:00

Refactors and clean up (#979)

mmarif modified the milestone from 4.1.0 to 4.2.0

2021-10-05 15:22:53 +00:00

6543 commented

2021-12-17 20:00:19 +00:00

Author

Member

branches do have pagination at least from >= v1.16.0 I'm sure with

👍 1

mmarif modified the milestone from 4.2.0 to 4.3.0

2022-02-12 15:20:02 +00:00

mmarif referenced a pull request that will close this issue

2022-03-16 16:04:52 +00:00

Use paginations #1089

mmarif referenced this issue from a commit

2022-04-04 08:00:54 +00:00

Use paginations (#1089)

mmarif closed this issue

2022-04-04 08:00:54 +00:00

mmarif closed this issue

2022-04-04 08:00:55 +00:00

qwerty287 reopened this issue

2022-04-04 08:04:38 +00:00

qwerty287 commented

2022-04-04 08:04:49 +00:00

Contributor

There are still some things not using this
We can look at tea4j-autodeploy once merged to find them (just examples: label selection lists, branch selection)

There are still some things not using this We can look at tea4j-autodeploy once merged to find them (just examples: label selection lists, branch selection)

mmarif modified the milestone from 4.3.0 to 4.4.0

2022-04-16 12:26:08 +00:00

6543 commented

2022-04-23 17:21:21 +00:00

Author

Member

auto got merged :)

👍 1

qwerty287 commented

2022-05-20 15:28:10 +00:00

Contributor

You can easily find usages which really ignore pagination by running grep -r "null, null)" app/src/main/java/org/mian/gitnex. Outputs right now for me:

app/src/main/java/org/mian/gitnex/actions/LabelsActions.java:                   .issueListLabels(repoOwner, repoName, null, null);
app/src/main/java/org/mian/gitnex/actions/LabelsActions.java:                                           .orgListLabels(repoOwner, null, null);
app/src/main/java/org/mian/gitnex/helpers/ssl/MemorizingTrustManager.java:                      keyStore.load(null, null);
app/src/main/java/org/mian/gitnex/activities/CreateReleaseActivity.java:                .repoListBranches(repoOwner, repoName, null, null);
app/src/main/java/org/mian/gitnex/activities/CreateLabelActivity.java:                              organizationLabelsViewModel.loadOrgLabelsList(getIntent().getStringExtra("orgName"), ctx, null, null);
app/src/main/java/org/mian/gitnex/activities/LoginActivity.java:                        call = RetrofitClient.getApiInterface(ctx, instanceUrl.toString(), credential, null).userGetTokens(loginOTP, loginUid, null, null);
app/src/main/java/org/mian/gitnex/activities/LoginActivity.java:                        call = RetrofitClient.getApiInterface(ctx, instanceUrl.toString(), credential, null).userGetTokens(loginUid, null, null);
app/src/main/java/org/mian/gitnex/activities/CreateFileActivity.java:                .repoListBranches(repoOwner, repoName, null, null);
app/src/main/java/org/mian/gitnex/activities/RepoDetailActivity.java:                   .repoListBranches(repository.getOwner(), repository.getName(), null, null);
app/src/main/java/org/mian/gitnex/activities/CreatePullRequestActivity.java:                    .repoListBranches(repoOwner, repoName, null, null);
app/src/main/java/org/mian/gitnex/fragments/OrganizationTeamInfoMembersFragment.java:                   .orgListTeamMembers(team.getId(), null, null);
app/src/main/java/org/mian/gitnex/viewmodels/OrganizationLabelsViewModel.java:                  .orgListLabels(owner, null, null);
app/src/main/java/org/mian/gitnex/viewmodels/LabelsViewModel.java:                .issueListLabels(owner, repo, null, null);
app/src/main/java/org/mian/gitnex/viewmodels/CollaboratorsViewModel.java:                .repoListCollaborators(owner, repo, null, null);
app/src/main/java/org/mian/gitnex/viewmodels/MembersByOrgViewModel.java:                .orgListMembers(owner, null, null);
app/src/main/java/org/mian/gitnex/viewmodels/RepoWatchersViewModel.java:                .repoListSubscribers(repoOwner, repoName, null, null);
app/src/main/java/org/mian/gitnex/viewmodels/TeamsByOrgViewModel.java:                .orgListTeams(orgName, null, null);
app/src/main/java/org/mian/gitnex/viewmodels/IssueCommentsViewModel.java:                .issueGetComments(owner, repo, (long) index, null, null);
app/src/main/java/org/mian/gitnex/viewmodels/RepoStargazersViewModel.java:                .repoListStargazers(repoOwner, repoName, null, null);
app/src/main/java/org/mian/gitnex/views/ReactionList.java:                                                      .issueGetIssueReactions(repoOwner, repoName, (long) id, null, null)
app/src/main/java/org/mian/gitnex/views/ReactionSpinner.java:                                   .issueGetIssueReactions(repoOwner, repoName, (long) id, null, null)
app/src/main/java/org/mian/gitnex/adapters/TeamsByOrgAdapter.java:                  .orgListTeamMembers(currentItem.getId(), null, null)

Only the one in app/src/main/java/org/mian/gitnex/helpers/ssl/MemorizingTrustManager.java is not an API call.
However, there might be more endpoints that use variables but do not change them. These one you can't find with grep 🙃.

You can easily find usages which really ignore pagination by running `grep -r "null, null)" app/src/main/java/org/mian/gitnex`. Outputs right now for me: ``` app/src/main/java/org/mian/gitnex/actions/LabelsActions.java: .issueListLabels(repoOwner, repoName, null, null); app/src/main/java/org/mian/gitnex/actions/LabelsActions.java: .orgListLabels(repoOwner, null, null); app/src/main/java/org/mian/gitnex/helpers/ssl/MemorizingTrustManager.java: keyStore.load(null, null); app/src/main/java/org/mian/gitnex/activities/CreateReleaseActivity.java: .repoListBranches(repoOwner, repoName, null, null); app/src/main/java/org/mian/gitnex/activities/CreateLabelActivity.java: organizationLabelsViewModel.loadOrgLabelsList(getIntent().getStringExtra("orgName"), ctx, null, null); app/src/main/java/org/mian/gitnex/activities/LoginActivity.java: call = RetrofitClient.getApiInterface(ctx, instanceUrl.toString(), credential, null).userGetTokens(loginOTP, loginUid, null, null); app/src/main/java/org/mian/gitnex/activities/LoginActivity.java: call = RetrofitClient.getApiInterface(ctx, instanceUrl.toString(), credential, null).userGetTokens(loginUid, null, null); app/src/main/java/org/mian/gitnex/activities/CreateFileActivity.java: .repoListBranches(repoOwner, repoName, null, null); app/src/main/java/org/mian/gitnex/activities/RepoDetailActivity.java: .repoListBranches(repository.getOwner(), repository.getName(), null, null); app/src/main/java/org/mian/gitnex/activities/CreatePullRequestActivity.java: .repoListBranches(repoOwner, repoName, null, null); app/src/main/java/org/mian/gitnex/fragments/OrganizationTeamInfoMembersFragment.java: .orgListTeamMembers(team.getId(), null, null); app/src/main/java/org/mian/gitnex/viewmodels/OrganizationLabelsViewModel.java: .orgListLabels(owner, null, null); app/src/main/java/org/mian/gitnex/viewmodels/LabelsViewModel.java: .issueListLabels(owner, repo, null, null); app/src/main/java/org/mian/gitnex/viewmodels/CollaboratorsViewModel.java: .repoListCollaborators(owner, repo, null, null); app/src/main/java/org/mian/gitnex/viewmodels/MembersByOrgViewModel.java: .orgListMembers(owner, null, null); app/src/main/java/org/mian/gitnex/viewmodels/RepoWatchersViewModel.java: .repoListSubscribers(repoOwner, repoName, null, null); app/src/main/java/org/mian/gitnex/viewmodels/TeamsByOrgViewModel.java: .orgListTeams(orgName, null, null); app/src/main/java/org/mian/gitnex/viewmodels/IssueCommentsViewModel.java: .issueGetComments(owner, repo, (long) index, null, null); app/src/main/java/org/mian/gitnex/viewmodels/RepoStargazersViewModel.java: .repoListStargazers(repoOwner, repoName, null, null); app/src/main/java/org/mian/gitnex/views/ReactionList.java: .issueGetIssueReactions(repoOwner, repoName, (long) id, null, null) app/src/main/java/org/mian/gitnex/views/ReactionSpinner.java: .issueGetIssueReactions(repoOwner, repoName, (long) id, null, null) app/src/main/java/org/mian/gitnex/adapters/TeamsByOrgAdapter.java: .orgListTeamMembers(currentItem.getId(), null, null) ``` Only the one in app/src/main/java/org/mian/gitnex/helpers/ssl/MemorizingTrustManager.java is not an API call. However, there might be more endpoints that use variables but do not change them. These one you can't find with `grep` 🙃.

qwerty287 modified the milestone from 4.4.0 to 4.5.0

2022-06-30 09:43:25 +00:00

qwerty287 commented

2022-06-30 09:51:08 +00:00

Contributor

There are at least three more you can find with grep -r "1, 50)" app/src/main/java/org/mian/gitnex:

app/src/main/java/org/mian/gitnex/activities/RepoDetailActivity.java:                   .issueGetMilestonesList(repository.getOwner(), repository.getName(), "open", null, 1, 50);
app/src/main/java/org/mian/gitnex/activities/CreateRepoActivity.java:                .orgListCurrentUserOrgs(1, 50);
app/src/main/java/org/mian/gitnex/adapters/TeamRepositoriesAdapter.java:                                .orgListTeamRepos((long) teamId, 1, 50);

There are at least three more you can find with `grep -r "1, 50)" app/src/main/java/org/mian/gitnex`: ``` app/src/main/java/org/mian/gitnex/activities/RepoDetailActivity.java: .issueGetMilestonesList(repository.getOwner(), repository.getName(), "open", null, 1, 50); app/src/main/java/org/mian/gitnex/activities/CreateRepoActivity.java: .orgListCurrentUserOrgs(1, 50); app/src/main/java/org/mian/gitnex/adapters/TeamRepositoriesAdapter.java: .orgListTeamRepos((long) teamId, 1, 50); ```

6543 commented

2022-07-02 16:06:53 +00:00

Author

Member

that sounds like this issue is near to be resolved completly 🎉

that sounds like this issue is near to be resolved completly :tada:

qwerty287 commented

2022-07-03 06:01:30 +00:00

Contributor

@6543 it looks like you didn't see #278 (comment) and #278 (comment)

@6543 it looks like you didn't see https://codeberg.org/gitnex/GitNex/issues/278#issuecomment-520698 and https://codeberg.org/gitnex/GitNex/issues/278#issuecomment-455717

6543 commented

2022-07-03 11:22:14 +00:00

Author

Member

I thought #278 (comment) was an update to #278 (comment) ...

I thought https://codeberg.org/gitnex/GitNex/issues/278#issuecomment-520698 was an update to https://codeberg.org/gitnex/GitNex/issues/278#issuecomment-455717 ...

qwerty287 commented

2022-07-03 13:25:47 +00:00

Contributor

Unfortunately not, it's an extension.

😆 1

mmarif removed this from the 4.5.0 milestone 2022-08-31 03:39:33 +00:00