[Pull] Repository Commits #308

New Issue

Closed

opened 2020-06-04 01:09:08 +00:00 by mmarif · 8 comments

mmarif commented

2020-06-04 01:09:08 +00:00

Owner

Will close #13

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/308

Merged with: 0f9025f925

Will close #13 --- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/308 Merged with: 0f9025f9254f2b80920a65a2c5092040c04c4010

mmarif added this to the 2.5.0 milestone 2020-06-04 01:09:08 +00:00

mmarif added the

🎉 Feature

label 2020-06-04 01:09:08 +00:00

mmarif closed this issue

2020-06-04 01:09:08 +00:00

mmarif was assigned by 6543

2020-06-04 01:09:48 +00:00

mmarif commented

2020-06-04 01:09:49 +00:00

Author

Owner

Screenshot of commits list

mmarif commented

2020-06-04 01:10:09 +00:00

Author

Owner

@6543 Used your adivce to remove Commits tab. It's now under branch and have separate activity for listing them.

6543 commented

2020-06-04 01:10:29 +00:00

Member

First checks: looks good but I need more time ...

6543 commented

2020-06-04 01:10:49 +00:00

Member

By the way: a future impruvement: instead of the browser link for the "single commit diff view" we could add a single-commit-view ... but this is realy outside of scope of this pull-request (it gets to heavy)

mmarif commented

2020-06-04 01:11:09 +00:00

Author

Owner

a future impruvement: instead of the browser link for the “single commit diff view” we could add a single-commit-view

Do you mean something like fileviewer or diff view?

> a future impruvement: instead of the browser link for the “single commit diff view” we could add a single-commit-view Do you mean something like fileviewer or diff view?

mmarif commented

2020-06-04 01:11:29 +00:00

Author

Owner

looks good but I need more time

No worries, take your time.

> looks good but I need more time No worries, take your time.

6543 commented

2020-06-04 01:11:49 +00:00

Member

there was a lot of unrelated refactor in it too :/ - but I hope I didn't missed something. It works on my side and I didn't found something while read throu the diff 👍

there was a lot of unrelated refactor in it too :/ - but I hope I didn't missed something. It works on my side and I didn't found something while read throu the diff :+1:

mmarif commented

2020-06-04 01:12:09 +00:00

Author

Owner

Yes few unrelated changes but was working on it, so thought no harm to improve them. :)