[New] Trust and accept self signed certificate #316
Labels
No Label
⌚ Major-release
⌚ Minor-release
⚔️ Wontfix
⚙️ CI
⛏️ Breaking
✨ Duplicate
❌ Invalid
❓ Question
❤️ Support
➡️ Frontport
➡️ Needs-frontport
🔙 Backport
💭 Brainstorming
🐛 Bug
🔭 Cannot-reproduce
🧺 Cleanup
🧾 Confirmed
💬 Discussion
📄 Documentation
🎯 Enhancement
🩹 External-dependecy
📱 F-droid
🎉 Feature
👋 Good-first-issue
🤾 Google-play
🔙 Has-backport
🚀 Improvement
🚨 Investigate
🌠 Long-term
🔙 Needs-backport
🧺 Needs-cleanup
📡 Needs-feedback
📈 Performance
📌 Priority-critical
📌 Priority-high
📍 Priority-low
📍 Priority-medium
🥑 Ready
🪒 Refactor
🔙 Regression
📸 Release
🔒 Security
💡 Suggestion
🧪 Testing
🌐 Translation
💻 UI/UX
🪜 Upstream
🟦 Website
🙇♂️ Needs-help
🛰️ API-dependency
🛡️ Blocked
🏗️ Build
🗒️ Changelog
🗄️ Repository
🗓️ Summary
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitnex/GitNex#316
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description - describe the bug / feature / suggestion in brief :
Maybe related to #263
After entering my credentials (username and password) on the LoginActivity and pressing the button "LOGIN" it turns grey and just says "PROCESSING". Nothing is happening afterwards. It just stays grey.
I should probably mention that my gitea server is running on port 3000 without any domain name (only ip adress).
Expected behaviour - describe what should be the expected result :
A successful login.
GitNex version : 2.5.0-dev (Occurs on F-Droid release, too)
Gitea version : 1.11.3
Android version : 7.1.1
Screenshots - if any:
none
Logs - if any :
This exception does not occur, when adding
implementation 'org.conscrypt:conscrypt-android:2.2.1'
to gradle.But now it comes up with another exception:
I think the last exception has something to do with my ssl certificate.
Are you able to implement a solution, where the user can manually trust certificates?
I would suggest using an AlertDialog with the following options:
@anonTree1417 GitNex dont work with self created certificates at the moment ...
... as you already guess :/
I would say: at first detect and catch this error and show a usefull information to the user would be helpfull ...
and as a feature acepting souch certs ...
I would love to create a pull request to solve these issues, but unfortunately I am not really familiar with OkHttp and Retrofit.
If you have time why not try it 👍 :)
I could try to make some changes in a new branch, but i cant promise to get it fully functional.
Thanks @anonTree1417 for opening this issue.
As you guessed already and mentioned by @6543 that it is self signed cert issue. GitNex at current time does not support self signed certs.
We do welcome PRs and you can give it a try.
I am also going to update the issue title and labels.
I will give it a try, but that can take some time.
No rush, take your time.
@mmarif It's working now. The last thing to do is cleaning everything up.
@anonTree1417 Great work. Hope to see the PR soon. :)
@mmarif How do i create a new branch? I dont have any permissions.
@anonTree1417 to create a pull request:
Ok, thank you.
@anonTree1417 if you need more help: https://discord.gg/qphrQ3k you can chat with us on discord