[Pull] Adjusting proportions of issue labels. #325

New Issue

Closed

opened 2020-06-04 02:13:54 +00:00 by opyale · 18 comments

opyale commented

2020-06-04 02:13:54 +00:00

Member

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/325

Merged with: b46ad33dd3

--- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/325 Merged with: b46ad33dd3fec3c284b00de940d287d690e23cfa

opyale added this to the 2.5.0 milestone 2020-06-04 02:13:54 +00:00

opyale added the

🎯 Enhancement

label 2020-06-04 02:13:54 +00:00

opyale closed this issue

2020-06-04 02:13:54 +00:00

opyale commented

2020-06-04 02:14:34 +00:00

Author

Member

original is empty: https://gitea.com/gitnex/GitNex/pulls/325#issuecomment-109755

mmarif commented

2020-06-04 02:14:55 +00:00

Owner

Can you apply the same to labels fragment screen and see how it look like because of new width(25).

My other concern is font size(30 is small) for smaller screen. The label will become too small. If it's fine there I have no issue with it.

Can you apply the same to labels fragment screen and see how it look like because of new width(25). My other concern is font size(30 is small) for smaller screen. The label will become too small. If it's fine there I have no issue with it.

opyale commented

2020-06-04 02:15:15 +00:00

Author

Member

Can you apply the same to labels fragment screen [...]

I still dont get it. Which fragment do you mean?

> Can you apply the same to labels fragment screen [...] I still dont get it. Which fragment do you mean?

mmarif commented

2020-06-04 02:15:35 +00:00

Owner

This file, https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/adapters/LabelsAdapter.java

Repository Labels tab.

This file, https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/adapters/LabelsAdapter.java Repository Labels tab.

opyale commented

2020-06-04 02:15:55 +00:00

Author

Member

Ah, okay.

opyale commented

2020-06-04 02:16:15 +00:00

Author

Member

When applying same size to adapter:

opyale commented

2020-06-04 02:16:35 +00:00

Author

Member

When increasing size in adapter:

opyale commented

2020-06-04 02:16:55 +00:00

Author

Member

Should i increase the font size?

mmarif commented

2020-06-04 02:17:15 +00:00

Owner

My suggestions:

Keep the width as is
keep the height as is
Font size keep between 32 to 36
For round cornors 10 is fine

My suggestions: - Keep the width as is - keep the height as is - Font size keep between 32 to 36 - For round cornors 10 is fine

mmarif commented

2020-06-04 02:17:36 +00:00

Owner

Also apply to adapter.

opyale commented

2020-06-04 02:17:56 +00:00

Author

Member

I don't think that keeping width and height will look good with a small font size, but i can make a screenshot.

opyale commented

2020-06-04 02:18:16 +00:00

Author

Member

This were the proportions we started with (font size = 32). I think those labels are a little bit to big, they don't fit the overall text size.

opyale commented

2020-06-04 02:18:36 +00:00

Author

Member

For reference (screenshot of official github app):

mmarif commented

2020-06-04 02:18:56 +00:00

Owner

Yea, smaller looks better.

Can you apply the changes to adapter(all changes you made). Want to try.

Yea, smaller looks better. Can you apply the changes to adapter(all changes you made). Want to try.

opyale commented

2020-06-04 02:19:16 +00:00

Author

Member

22010d953a Done.

22010d953af7d91da19175d9e7ed1647e87f7592 Done.

opyale commented

2020-06-04 02:19:36 +00:00

Author

Member

original is empty: https://gitea.com/gitnex/GitNex/pulls/325#issuecomment-109904

mmarif commented

2020-06-04 02:19:56 +00:00

Owner

Looks good.

opyale commented

2020-06-04 02:20:16 +00:00

Author

Member

Thanks.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#325

No description provided.