[Extend] Issue Subscribtion #356
Labels
No Label
⌚ Major-release
⌚ Minor-release
⚔️ Wontfix
⚙️ CI
⛏️ Breaking
✨ Duplicate
❌ Invalid
❓ Question
❤️ Support
➡️ Frontport
➡️ Needs-frontport
🔙 Backport
💭 Brainstorming
🐛 Bug
🔭 Cannot-reproduce
🧺 Cleanup
🧾 Confirmed
💬 Discussion
📄 Documentation
🎯 Enhancement
🩹 External-dependecy
📱 F-droid
🎉 Feature
👋 Good-first-issue
🤾 Google-play
🔙 Has-backport
🚀 Improvement
🚨 Investigate
🌠 Long-term
🔙 Needs-backport
🧺 Needs-cleanup
📡 Needs-feedback
📈 Performance
📌 Priority-critical
📌 Priority-high
📍 Priority-low
📍 Priority-medium
🥑 Ready
🪒 Refactor
🔙 Regression
📸 Release
🔒 Security
💡 Suggestion
🧪 Testing
🌐 Translation
💻 UI/UX
🪜 Upstream
🟦 Website
🙇♂️ Needs-help
🛰️ API-dependency
🛡️ Blocked
🏗️ Build
🗒️ Changelog
🗄️ Repository
🗓️ Summary
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitnex/GitNex#356
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
code ref: https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/fragments/BottomSheetSingleIssueFragment.java#L256
if https://github.com/go-gitea/gitea/pull/10967 is merged gitea >= v1.12.0 will have an api if a user has subscribed to an issue, so we dont have to guess.
https://github.com/go-gitea/gitea/pull/10967 got merged ...
GET /repos/{owner}/{repo}/issues/{index}/subscriptions/check
now return a WatchInfo
Can we add
dismiss
now for the bottomsheet?Does it need 1.12 to work(dismiss)?
what do you mean with dismiss ?
Normally once the action is done, the bottomsheet is dismissed(closed). Check the other bottomsheet entries. But for subscribe it's not the case, it just stays there.
ah sure we can add it there too
but then we dont have to make things Visible/Hidden after an action ...
That's the problem here. Last time I tried to hide the subscribe/unsubscribe but as there is no definite flag set like close/reopen issue. That way easy to hide/show and dismiss the sheet.
The new API(watchInfo?) I thought will have this flag we can use to hide/show and at the same time able to dismiss the sheet.
let me code it ...
@mmarif done -> #445 (6d4e02629dd821c656da2b549791ed385f5af7e2)