[Extend] Issue Subscribtion #356

Closed
opened 2020-06-04 03:12:26 +00:00 by 6543 · 9 comments
Member

code ref: https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/fragments/BottomSheetSingleIssueFragment.java#L256

if https://github.com/go-gitea/gitea/pull/10967 is merged gitea >= v1.12.0 will have an api if a user has subscribed to an issue, so we dont have to guess.

code ref: https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/fragments/BottomSheetSingleIssueFragment.java#L256 if https://github.com/go-gitea/gitea/pull/10967 is merged gitea >= v1.12.0 will have an api if a user has subscribed to an issue, so we dont have to guess.
6543 added this to the 3.0.0 milestone 2020-06-04 03:12:26 +00:00
6543 added the
🎯 Enhancement
label 2020-06-04 03:12:26 +00:00
6543 closed this issue 2020-06-04 03:12:26 +00:00
6543 self-assigned this 2020-06-04 03:13:06 +00:00
Author
Member

https://github.com/go-gitea/gitea/pull/10967 got merged ...

GET /repos/{owner}/{repo}/issues/{index}/subscriptions/check
now return a WatchInfo

https://github.com/go-gitea/gitea/pull/10967 got merged ... `GET /repos/{owner}/{repo}/issues/{index}/subscriptions/check` now return a **WatchInfo**
Owner

Can we add dismiss now for the bottomsheet?

Does it need 1.12 to work(dismiss)?

Can we add `dismiss` now for the bottomsheet? Does it need 1.12 to work(dismiss)?
Author
Member

what do you mean with dismiss ?

what do you mean with dismiss ?
Owner

Normally once the action is done, the bottomsheet is dismissed(closed). Check the other bottomsheet entries. But for subscribe it's not the case, it just stays there.

Normally once the action is done, the bottomsheet is dismissed(closed). Check the other bottomsheet entries. But for subscribe it's not the case, it just stays there.
Author
Member

ah sure we can add it there too

ah sure we can add it there too
Author
Member

but then we dont have to make things Visible/Hidden after an action ...

but then we dont have to make things Visible/Hidden after an action ...
Owner

but then we dont have to make things Visible/Hidden after an action

That's the problem here. Last time I tried to hide the subscribe/unsubscribe but as there is no definite flag set like close/reopen issue. That way easy to hide/show and dismiss the sheet.

The new API(watchInfo?) I thought will have this flag we can use to hide/show and at the same time able to dismiss the sheet.

> but then we dont have to make things Visible/Hidden after an action That's the problem here. Last time I tried to hide the subscribe/unsubscribe but as there is no definite flag set like close/reopen issue. That way easy to hide/show and dismiss the sheet. The new API(watchInfo?) I thought will have this flag we can use to hide/show and at the same time able to dismiss the sheet.
Author
Member

let me code it ...

let me code it ...
Author
Member

@mmarif done -> #445 (6d4e02629dd821c656da2b549791ed385f5af7e2)

@mmarif done -> #445 (6d4e02629dd821c656da2b549791ed385f5af7e2)
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#356
No description provided.