gitnex/GitNex

Fork 37

[Pull] Replacing bottom sheet item by floating action button. #360

New issue

Closed

opened 2020-06-04 03:22:55 +00:00 by opyale · 9 comments

opyale commented

2020-06-04 03:22:55 +00:00

Member

Adding a floating action button for adding comments on an issue

Closes #336

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/360

Merged with: 7387c29077

Adding a floating action button for adding comments on an issue Closes #336 --- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/360 Merged with: 7387c29077551836f98d1520beda18a4547a5565

opyale added this to the 2.5.0 milestone 2020-06-04 03:22:55 +00:00

opyale added the

🚀 Improvement

💻 UI/UX

labels 2020-06-04 03:22:55 +00:00

opyale closed this issue

2020-06-04 03:22:56 +00:00

mmarif commented

2020-06-04 03:23:36 +00:00

Owner

Also while scrolling the button should hide like other screens.

opyale commented

2020-06-04 03:23:56 +00:00

Author

Member

Also while scrolling the button should hide like other screens.

I dont think this would be great for user experience (e.g. user wants to reply and has already scrolled down to the latest message).

> Also while scrolling the button should hide like other screens. I dont think this would be great for user experience (e.g. user wants to reply and has already scrolled down to the latest message).

mmarif commented

2020-06-04 03:24:16 +00:00

Owner

I dont think this would be great for user experience (e.g. user wants to reply and has already scrolled down to the latest message).

Maybe I was not clear here.

It is good UX to not show things where it is not necessary. When scrolling it's not good this button should get in the way.
While reach at the end you may have not noticed, every comment has three dotted menu to tap. This button if not hidden will hide that.

Check how it is implemented in repositories screen. While srolling down, it will hide, but if you stop somewhere and move a little up, the button apears. Same should be done here.

> I dont think this would be great for user experience (e.g. user wants to reply and has already scrolled down to the latest message). Maybe I was not clear here. 1. It is good UX to not show things where it is not necessary. When scrolling it's not good this button should get in the way. 2. While reach at the end you may have not noticed, every comment has three dotted menu to tap. This button if not hidden will hide that. Check how it is implemented in repositories screen. While srolling down, it will hide, but if you stop somewhere and move a little up, the button apears. Same should be done here.

opyale commented

2020-06-04 03:24:36 +00:00

Author

Member

Check how it is implemented in repositories screen. While srolling down, it will hide, but if you stop somewhere and move a little up, the button apears. Same should be done here.

Ah, i misunderstood you. I thought you wanted that the fab is only visible when the user is at the top of the screen.

> Check how it is implemented in repositories screen. While srolling down, it will hide, but if you stop somewhere and move a little up, the button apears. Same should be done here. Ah, i misunderstood you. I thought you wanted that the fab is only visible when the user is at the top of the screen.

6543 commented

2020-06-04 03:24:57 +00:00

Member

I'm for hiding too :)

opyale commented

2020-06-04 03:25:17 +00:00

Author

Member

@mmarif

Ok, i've talked with 6543. The fab doesn't even hide in "My repositorys". This is definitely a bug. Since it isn't working officially, it wont make any sense to include that feature in this PR. If it is working officially, i will apply these changes.

@mmarif Ok, i've talked with 6543. The fab doesn't even hide in "My repositorys". This is definitely a bug. Since it isn't working officially, it wont make any sense to include that feature in this PR. If it is working officially, i will apply these changes.

mmarif commented

2020-06-04 03:25:37 +00:00

Owner

@opyale not sure why it should not work for you guys. I have posted a video in maintainers group to check this func out.

Maybe this will help

https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/fragments/MyRepositoriesFragment.java#L119

@opyale not sure why it should not work for you guys. I have posted a video in maintainers group to check this func out. Maybe this will help https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/fragments/MyRepositoriesFragment.java#L119

opyale commented

2020-06-04 03:25:57 +00:00

Author

Member

@mmarif Please check if it works with 4aa67ca789

@mmarif Please check if it works with 4aa67ca7896bd5851767df85d07af7ced5b8fc00

mmarif commented

2020-06-04 03:26:17 +00:00

Owner

Unfortunately this will not work as there is a scrollview in this.

But it's ok I am going to merge this and will send a quick PR to fix this.

Unfortunately this will not work as there is a scrollview in this. But it's ok I am going to merge this and will send a quick PR to fix this.