[Pull] Refactor commits #452

New Issue

Closed

opened 2020-06-04 05:38:57 +00:00 by mmarif · 5 comments

mmarif commented

2020-06-04 05:38:57 +00:00

Owner

Closes #440

Right now it will crash for whatever reason of using ?attr/ which is really annoying.

I had this issue last time, can't remember how I fixed it.

If you remove the custom attr from list_commits.xml, it will work. Atleast it's the case on my side.

Edit: fixed the crash.

Original Pull att :https://gitea.com/gitnex/GitNex/pulls/452

Merged with: 195bfc8fe2

Closes #440 Right now it will crash for whatever reason of using `?attr/` which is really annoying. I had this issue last time, can't remember how I fixed it. If you remove the custom attr from list_commits.xml, it will work. Atleast it's the case on my side. **Edit: fixed the crash.** --- Original Pull att :https://gitea.com/gitnex/GitNex/pulls/452 Merged with: 195bfc8fe244e8a3c67c3b7b9e31e9f5762ffa87

mmarif added this to the 3.0.0 milestone 2020-06-04 05:38:57 +00:00

mmarif added the

🚀 Improvement

🪒 Refactor

labels 2020-06-04 05:38:57 +00:00

mmarif closed this issue

2020-06-04 05:38:57 +00:00

mmarif was assigned by 6543

2020-06-04 05:39:37 +00:00

6543 commented

2020-06-04 05:39:38 +00:00

Member

@mmarif -> 5807faed81

@mmarif -> 5807faed81138e48887813d95199c3f401aec469

opyale commented

2020-06-04 05:39:58 +00:00

Member

@mmarif

Right now it will crash for whatever reason of using ?attr/ which is really annoying.

I know this may be too late, but i think youre passing the wrong context to the adapter when using getApplicationContext().

new CommitsAdapter(getApplicationContext())

Try passing CommitsActivity.this instead. It should work fine.

@mmarif > Right now it will crash for whatever reason of using ?attr/ which is really annoying. I know this may be too late, but i think youre passing the wrong context to the adapter when using getApplicationContext(). ``` new CommitsAdapter(getApplicationContext()) ``` Try passing ``CommitsActivity.this`` instead. It should work fine.

mmarif commented

2020-06-04 05:40:18 +00:00

Author

Owner

I know this may be too late, but i think youre passing the wrong context to the adapter when using getApplicationContext().

Yes, that's true I was passing the wrong context. Sometime just too many things to take care of. 😄

> I know this may be too late, but i think youre passing the wrong context to the adapter when using getApplicationContext(). Yes, that's true I was passing the wrong context. Sometime just too many things to take care of. :smile:

mmarif commented

2020-06-04 05:40:38 +00:00

Author

Owner

@mmarif -> 5807faed81

I saw you used < in somewhere, I guess in the mainactivity. That should also be changed?

> @mmarif -> 5807faed81 I saw you used `<` in somewhere, I guess in the mainactivity. That should also be changed?

6543 commented

2020-06-04 05:40:58 +00:00

Member

@mmarif THIS is a other task - I'll look at all version checks in my refactor - just give me some time - I have a longer and longer ToDo list :(

this here is ready so I'll merge 🚀

@mmarif THIS is a other task - I'll look at all version checks in my refactor - just give me some time - I have a longer and longer ToDo list :( this here is ready so I'll merge :rocket: