[New] register links/urls handler #65

Closed
opened 2020-06-03 14:32:37 +00:00 by 6543 · 14 comments
Member

I dont now if this is the official description (title) but what i mean:

GitNex can be chosen if you klick on a link wich the domain is known to be a gitea instance by gitnex (like you klik on a youtube link and newpipe can be choosen to open it, or normal web browser ..)

I dont now if this is the official description (title) but what i mean: GitNex can be chosen if you klick on a link wich the domain is known to be a gitea instance by gitnex (like you klik on a youtube link and newpipe can be choosen to open it, or normal web browser ..)
6543 added the
🎉 Feature
label 2020-06-03 14:32:37 +00:00
Author
Member
  • issue/PR link opens issue/PR
  • file link opens file (need file function first)
  • release page ...
  • unknowen link start gitnex and schow a message that this is no link it can handle jet ...
* [ ] issue/PR link opens issue/PR * [ ] file link opens file (need file function first) * [ ] release page ... * [ ] unknowen link start gitnex and schow a message that this is no link it can handle jet ...
Owner

A bit complicated but doable.

A bit complicated but doable.
Author
Member

I know but just leave it for later development :)

Lable prio 3 ;)

I know but just leave it for later development :) Lable prio 3 ;)
Owner

Yup, will implement at later times.

Can you reproduce this #66 ?

Yup, will implement at later times. Can you reproduce this #66 ?
Author
Member
notes: * https://proandroiddev.com/best-practices-for-deeplinking-in-android-1dc1ea060c0c * https://github.com/airbnb/DeepLinkDispatch

@ildar that’s #65

Ahh! No "URL" word, no "intent" word. That's why I couldn't find this.

> @ildar that’s #65 Ahh! No "URL" word, no "intent" word. That's why I couldn't find this.
mmarif changed title from [New] register link handler to [New] register links/urls handler 2020-09-12 07:03:55 +00:00
mmarif added this to the 3.3.0 milestone 2020-10-15 07:41:45 +00:00
mmarif self-assigned this 2020-10-15 07:42:28 +00:00

I'm sorry, this is bad.
first gitnex catches all those URLs it can't handle. then it hangs with a black screen and endless progress line.

> <data scheme="https" host="*"/> I'm sorry, this is bad. first gitnex catches all those URLs it can't handle. then it hangs with a black screen and endless progress line.
Author
Member

@ildar there already went a few bugfixes in ... this func is only released as RC on F-Droid ...

@mmarif and I didn't found a good way to only catch specific urls dynamicaly
they have to be written into AndroidManifest.xml witch is static

register link handler dymamicaly would be nice - do you know a solution?

@ildar there already went a few bugfixes in ... this func is only released as RC on F-Droid ... @mmarif and I didn't found a good way to only catch specific urls dynamicaly they have to be written into `AndroidManifest.xml` witch is static register link handler dymamicaly would be nice - do you know a solution?
Owner

@ildar It was RC release to get feedback, you can always rollback to stable version on F-droid or switch from beta on play store.

first gitnex catches all those URLs it can’t handle

That's the problem when working with applications like Gitea where there is no specific specifications of URL definitions. Anyone can use any sort of URL style. That is the reason we implemented to catch all URLs. But there are checks if it is Gitea instance or not etc. We can restrict to few popular ones, but the question is is that all users want?. I have no problem by just adding few popular ones instead of catch all.

then it hangs with a black screen and endless progress line.

This is fixed. Try build from master if you want.

@6543 Yes, we can't modify/change AndroidManifest.xml during runtime.

register link handler dymamicaly would be nice

Yes, I would love to hear from others if they know any solution to this.

@ildar It was RC release to get feedback, you can always rollback to stable version on F-droid or switch from beta on play store. > first gitnex catches all those URLs it can’t handle That's the problem when working with applications like Gitea where there is no specific specifications of URL definitions. Anyone can use any sort of URL style. That is the reason we implemented to catch all URLs. But there are checks if it is Gitea instance or not etc. We can restrict to few popular ones, but the question is is that all users want?. I have no problem by just adding few popular ones instead of catch all. > then it hangs with a black screen and endless progress line. This is fixed. Try build from master if you want. @6543 Yes, we can't modify/change `AndroidManifest.xml` during runtime. > register link handler dymamicaly would be nice Yes, I would love to hear from others if they know any solution to this.

@mmarif , https://gitlab.com/Commit451/LabCoat/-/issues/377#note_177540506
You could follow his path OR ask @nomadlabs to add support of GitNex into his app.

@mmarif , https://gitlab.com/Commit451/LabCoat/-/issues/377#note_177540506 You could follow his path OR ask @nomadlabs to add support of GitNex into his app.
Owner

@ildar

You could follow his path

We are already doing it the same way except with catch all instead of adding few popular ones, which most Android apps do anwyay.

ask @nomadlabs to add support of GitNex into his app.

Which means ask the user to install another app for just one functionality which GitNex can handle by itself.

We are reviewing our approach to this, and we may remove catch all and add popular ones to start with. Do share if you know any pupolar instance with atleast 100 active users.

@ildar > You could follow his path We are already doing it the same way except with catch all instead of adding few popular ones, which most Android apps do anwyay. > ask @nomadlabs to add support of GitNex into his app. Which means ask the user to install another app for just one functionality which GitNex can handle by itself. We are reviewing our approach to this, and we may remove catch all and add popular ones to start with. Do share if you know any pupolar instance with atleast 100 active users.

and we may remove catch all and add popular ones

This is absolutely mandatory. You may have a different experience but in my Android 7 EVERY time I open ANY URL I get this: #65 (comment)

Please fix ASAP.

BTW,

@ildar there already went a few bugfixes in ... this func is only released as RC on F-Droid ...

RC versions are now default on F-Droid so you potentially may end up with many negative UX with them.

> and we may remove catch all and add popular ones This is absolutely mandatory. You may have a different experience but in my Android 7 EVERY time I open ANY URL I get this: https://codeberg.org/gitnex/GitNex/issues/65#issuecomment-130139 Please fix ASAP. BTW, > @ildar there already went a few bugfixes in ... this func is only released as RC on F-Droid ... RC versions are now default on F-Droid so you potentially may end up with many negative UX with them.
Owner

Please fix ASAP.

This is fixed now. #758

RC versions are now default on F-Droid so you potentially may end up with many negative UX with them.

Yes, we are aware of that. F-droid allow last three active installations, and we keep RC releases to minimum(except in few cases like this release, we will release another RC becasue of huge changes in code base) to allow users to rollback to last stable version.

The next RC we hope will have all the fixes.

> Please fix ASAP. This is fixed now. #758 > RC versions are now default on F-Droid so you potentially may end up with many negative UX with them. Yes, we are aware of that. F-droid allow last three active installations, and we keep RC releases to minimum(except in few cases like this release, we will release another RC becasue of huge changes in code base) to allow users to rollback to last stable version. The next RC we hope will have all the fixes.

This is fixed now. #758

👍 ! I like it

> This is fixed now. #758 👍 ! I like it
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#65
No description provided.