Version Check before try to Login #147
No reviewers
Labels
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
No Milestone
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitnex/GitNex#147
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "version-check"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
6543 referenced this pull request2019-10-14 12:10:31 +00:00
I will be removing the version call from About screen in the future, it will be part of Accounts table. But that's for later.
Yes, it does not need token.
@6543 I am planning to release 2.2.0 tomorrow, will you be able to finish it by then?
Otherwise we can push it to the next release.
@mmarif I'll have time on the weekend ...
@mmarif when you have an guilty login at witch point i get the first api calls?
@mmarif we schould use merge+squash to have a smaler git repo in long therme?
All the magic happen inside
login()
function which callletTheUserIn()
API call function.But for version check, it should happen before the actual API login call. Once the user tap the login button, 1st thing we check and show the error about the version. If all good, proceed to the next step. So in
login()
you can do the check and return with error when version is old.Yes, we should to make the repo compact.
last commit shows the function i get this error: https://pastebin.com/ZXj0tYUG
... working to get RetrofitClient send a syncron call
I haven't check the code yet. But if the api call is outside, you can put it inside lettheuserin call.
If it is done from your side, I can take it from here to make it work.
Ok I'll improve VersionTest and then I let you try to bring it to live ... if i didnt found a solution untill then ;)
@mmarif Its yours ;)
VersionTest works as it should now
@6543 Thanks, I will take it from here.
@6543 it's done. You can check from your side now. After your testing can merge.
Great thanks!
nice works fine!!
you ony catch the UNSUPPORTED_OLD but i think this is fine for the purpose of this PR ...
should we cleanup strings of unused one or leave it for later usage ?
Yes, we only need unsupported old. We can keep the strinngs as is for later use.
I'll make a smal cleanup ...
Ok, I will wait for it.
OK I have looked throu and cleanup is not nessesary but i had two changes - if they are ok for you then we can merge :)
@mmarif can yu squath-merge ?
[WIP] Version Check before try to Loginto Version Check before try to Login@6543 Ok, I will squash.
New Gitea version detected! Please UPDATE GitNex!
, how we know what version of GitNex user have to tell them to update?We only check for Gitea versions.
Maybe I am missing something here, can you tell how it will work?
So if I am on gitea.com, I will be seeing that message. Am I right?
for others to read: answer: no ;)