Offline mode #190

@mmarif it doesnt cache repo lists (stared repos, my repos, ...) and user avatars but files if opend before work offline now (if you stay in a repo) :+1:

mmarif commented

2019-11-06 05:29:55 +00:00

What process you carried out to test.

You should have network when open the app and browse around the pages so the app can cache the contents. After that turn off network and you will be able to see the cached contents.

What process you carried out to test. You should have network when open the app and browse around the pages so the app can cache the contents. After that turn off network and you will be able to see the cached contents.

6543 commented

2019-11-06 11:26:15 +00:00

@mmarif yes this works but offline mode in my definition is, once you cached the files, you should be able to close the app, switch off internet and then browse cached repos

mmarif commented

2019-11-06 11:32:21 +00:00

Not sure why its not working for you. I have made a video a while ago. Check if its what you want.

https://peertube.social/videos/watch/000a8348-b180-47d4-8775-4b924f80d7c1

Not sure why its not working for you. I have made a video a while ago. Check if its what you want. https://peertube.social/videos/watch/000a8348-b180-47d4-8775-4b924f80d7c1

6543 commented

2019-11-06 16:05:58 +00:00

@mmarif - the cache is only used if contend has fully loaded (was my first problem)

Second:

@mmarif - the cache is only used if contend has fully loaded (was my first problem) Second:

Screenshot_20191106-170105_1.jpg

26 KiB

Screenshot_20191106-170114_1.jpg

45 KiB

6543 commented

2019-11-06 16:06:51 +00:00

Test Device: pisikal, android 9.0.9

6543 commented

2019-11-06 16:26:12 +00:00

Org avatars too

Screenshot_20191106-171154_1.jpg

40 KiB

6543 commented

2019-11-07 12:14:07 +00:00

I'll test again ...

mmarif commented

2019-11-13 09:59:22 +00:00

@6543 how was your test?

6543 commented

2019-11-13 12:52:41 +00:00

One thing still not work ...

6543 commented

2019-11-13 12:55:59 +00:00

ONLINE mode:

Without	With PR

Tested with: emulated Android & physical device

ONLINE mode: Without | With PR ---- | ---- ![](https://user-images.githubusercontent.com/24977596/68765499-328ad900-061d-11ea-946c-a4059ea888cb.png) | ![](https://user-images.githubusercontent.com/24977596/68765497-30c11580-061d-11ea-97bb-b34265ce1e7c.png) Tested with: emulated Android & physical device

mmarif commented

2019-11-13 13:52:50 +00:00

So the name does not show in the Online mode in this PR, am I right?

Do you have full name in your profile saved bdw?

So the name does not show in the Online mode in this PR, am I right? Do you have full name in your profile saved bdw?

👍 1

6543 commented

2019-11-13 14:09:00 +00:00

Do you have full name in your profile saved bdw?

No

> Do you have full name in your profile saved bdw? No

6543 commented

2019-11-13 14:09:46 +00:00

{
    "login": "6543",
    "full_name": "",
    "avatar_url": "https://gitea.com/user/avatar/6543/-1",
    "language": "",
    "is_admin": false,
    "username": "6543"
}

...

```json { "login": "6543", "full_name": "", "avatar_url": "https://gitea.com/user/avatar/6543/-1", "language": "", "is_admin": false, "username": "6543" } ``` ...

mmarif commented

2019-11-13 14:15:56 +00:00

I haven't checked that part of the code yet, but can you add full name and see if it is working.

I will check after that to make sure it pick username/login if full name is empty.

I haven't checked that part of the code yet, but can you add full name and see if it is working. I will check after that to make sure it pick username/login if full name is empty.

6543 commented

2019-11-13 14:53:28 +00:00

@mmarif checked

you are right - this text field has no fallback to login name!

@mmarif checked you are right - this text field has no fallback to login name!

6543 commented

2019-11-13 15:00:17 +00:00

@mmarif done -> fc27f7c73d

@mmarif done -> fc27f7c73dab90933671998e6d7509bf2ebd65d2

👍 1

6543 approved these changes 2019-11-13 15:01:00 +00:00

Dismissed