gitnex/GitNex
gitnex/GitNex
Archived
14
58
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

Refactor assignee(s) API calls #199

Merged
mmarif merged 5 commits from refactor_issues_call into master 2020-02-24 18:50:56 +00:00
Conversation 11 Commits 5 Files Changed 6 +12 -55
6543 commented 2019-11-15 14:10:21 +00:00
Member
Copy Link

close #196

  • remove assignee
  • add user to the "new issue" assignees dialog
close https://gitea.com/gitnex/GitNex/issues/196 * [x] remove assignee * [x] add user to the "new issue" assignees dialog
6543 added the
Refactor
 label 2019-11-15 14:10:29 +00:00
6543 added this to the 2.3.0 milestone 2019-11-15 14:10:33 +00:00
6543 self-assigned this 2019-11-16 01:53:46 +00:00
6543 commented 2019-11-17 18:12:22 +00:00
Author
Member
Copy Link

@mmarif ready to review

@mmarif ready to review
6543 changed title from [WIP] Refactor assignee(s) API calls to Refactor assignee(s) API calls 2019-11-17 18:12:29 +00:00
6543 added the
LGTM-need
 label 2019-11-17 18:12:38 +00:00
mmarif commented 2019-11-17 20:38:19 +00:00
Owner
Copy Link

I have just tried to create new issue and the app crashes with error. I am on 1.9.x.

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mian.gitnex/org.mian.gitnex.activities.CreateIssueActivity}: java.lang.NumberFormatException: For input string: "mmarif"

Error line listOfAssignees.add(new MultiSelectModel(Integer.valueOf(loginUid), loginFullName)); in CreateIssueActivity.

I can create an account for you on my instance if you want to test on it.

I have just tried to create new issue and the app crashes with error. I am on 1.9.x. `java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mian.gitnex/org.mian.gitnex.activities.CreateIssueActivity}: java.lang.NumberFormatException: For input string: "mmarif"` Error line `listOfAssignees.add(new MultiSelectModel(Integer.valueOf(loginUid), loginFullName));` in CreateIssueActivity. I can create an account for you on my instance if you want to test on it.
6543 commented 2019-11-18 06:20:48 +00:00
Author
Member
Copy Link

I can create an account for you on my instance if you want to test on it.

Ok 👍

> I can create an account for you on my instance if you want to test on it. Ok :+1:
mmarif commented 2019-11-18 09:51:21 +00:00
Owner
Copy Link

Tested on 1.10 and have the same effect. Crash.

Tested on 1.10 and have the same effect. Crash.
mmarif commented 2019-11-25 12:15:52 +00:00
Owner
Copy Link

I am thinking of releasing 2.3.0 after adding #10 . Do you think we can still merge this PR after your rework? otherwise can push to next release.

I am thinking of releasing 2.3.0 after adding #10 . Do you think we can still merge this PR after your rework? otherwise can push to next release.
6543 modified the milestone from 2.3.0 to 2.4.0 2019-11-27 14:59:02 +00:00
6543 commented 2020-02-03 00:06:46 +00:00
Author
Member
Copy Link

I have just tried to create new issue and the app crashes with error. I am on 1.9.x.

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mian.gitnex/org.mian.gitnex.activities.CreateIssueActivity}: java.lang.NumberFormatException: For input string: "mmarif"

Error line listOfAssignees.add(new MultiSelectModel(Integer.valueOf(loginUid), loginFullName)); in CreateIssueActivity.

I can create an account for you on my instance if you want to test on it.

I looked at the error-msg again ... I think this has nothing to do with the gitea-instance.

I add the loged in user to the list of users you can select to assign. and use loginUid as user.ID but it looks like the thyniyDB stores the loginName rather than the ID in this field

> I have just tried to create new issue and the app crashes with error. I am on 1.9.x. > > `java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mian.gitnex/org.mian.gitnex.activities.CreateIssueActivity}: java.lang.NumberFormatException: For input string: "mmarif"` > > Error line `listOfAssignees.add(new MultiSelectModel(Integer.valueOf(loginUid), loginFullName));` in CreateIssueActivity. > > I can create an account for you on my instance if you want to test on it. I looked at the error-msg again ... I think this has nothing to do with the gitea-instance. I add the loged in user to the list of users you can select to assign. and use loginUid as user.ID but it looks like the thyniyDB stores the loginName rather than the ID in this field
mmarif commented 2020-02-03 14:42:25 +00:00
Owner
Copy Link

I think this has nothing to do with the gitea-instance.

Yes, it maybe unrelated to the version of Gitea.

but it looks like the thyniyDB stores the loginName rather than the ID in this field

I actually forgot what is stored in tinyDB. 😵

But if you have time to fix this, let me know I will test when it's ready. 👍

> I think this has nothing to do with the gitea-instance. Yes, it maybe unrelated to the version of Gitea. > but it looks like the thyniyDB stores the loginName rather than the ID in this field I actually forgot what is stored in tinyDB. :dizzy_face: But if you have time to fix this, let me know I will test when it's ready. :thumbsup:
🎉 1
6543 commented 2020-02-03 15:58:35 +00:00
Author
Member
Copy Link

@mmarif we realy need a documentation of the ThinyDB :/

@mmarif we realy need a documentation of the ThinyDB :/
6543 commented 2020-02-08 18:23:34 +00:00
Author
Member
Copy Link

@mmarif I think i found the bug ... can you test it again?

PS: it worked for me because my username contain only numbers ...

@mmarif I think i found the bug ... can you test it again? PS: it worked for me because my username contain only numbers ...
6543 commented 2020-02-21 14:43:14 +00:00
Author
Member
Copy Link

ping @mmarif

ping @mmarif
mmarif commented 2020-02-24 18:50:09 +00:00
Owner
Copy Link

@6543 Thank you. It works now!

@6543 Thank you. It works now!
mmarif added
LGTM-done
 and removed
LGTM-need
 labels 2020-02-24 18:50:22 +00:00
mmarif referenced this issue from a commit 2020-02-24 18:50:54 +00:00
Refactor assignee(s) API calls (#199) Merge branch 'master' into refactor_issues_call Remove credits, add donators (#268) Merge branch 'master' into 264-remove-credits Merge pull request 'Support for c header files' (#266) from 265-files-support-in-file-viewer into master Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/266 Remove credits, add donators support for c header files Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/268 Merge pull request 'Support for c header files' (#266) from 265-files-support-in-file-viewer into master Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/266 support for c header files fix Merge branch 'master' into refactor_issues_call Support pdf files in file viewer (#259) auto convert EOL this fix it for me fix layout implement support for pdf files in file viewer Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/259 Reviewed-by: 6543 <6543@noreply.gitea.io> Make DueDate optional on MilestoneCreaton (#252) Merge branch 'master' into milestone-DueDate-optional_240 add check again if gitea is older than 1.10.0 ... Crowdin [2020-01-04] + add Latvian (#253) update Translators add Latvian update Crowdin Co-authored-by: 6543 <6543@obermui.de> make DueDate optional on MilestoneCreaton Co-authored-by: 6543 <6543@obermui.de> Crowdin [2020-01-04] + add Latvian (#253) update Translators add Latvian update Crowdin Co-authored-by: 6543 <6543@obermui.de> Merge branch '51-custom-fonts' of gitnex/GitNex into master Reviewed-by: 6543 <6543@noreply.gitea.io> Implement across the whole app Implementation of custom fonts app wide Merge branch 'crowdin_2019-12-25' of gitnex/GitNex into master add user to the “new issue” assignees dialog refactor.start() update from crowdin Merge branch 'backport-243' of gitnex/GitNex into master backport url slashes fix Merge branch 'fix-238' of gitnex/GitNex into master fix Merge branch 'backport-235' of gitnex/GitNex into master backport fix #235 Merge branch 'backport-232' of gitnex/GitNex into master show all issues and prs Merge branch '206-repos-in-explore-screen' of gitnex/GitNex into master Load default list of explore repositories Merge branch '225-backport' of gitnex/GitNex into master copy and support files backport - #225 Merge branch '226-backport' of gitnex/GitNex into master fix alignments backport Co-authored-by: M M Arif <mmarif@swatian.com> Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/199
mmarif closed this pull request 2020-02-24 18:50:56 +00:00
6543 deleted branch refactor_issues_call 2020-02-24 21:31:08 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Priority-high

   
Accepting-merge-requests

   
API

   
API-dependency

   
Backport

   
Blocked

   
Brainstorming

   
Breaking

Breaking change

  
Bug

   
Changelog

   
CI

   
Cleanup

   
Confirmed

   
Discussion

   
Documentation

   
Duplicate

   
Enhancement

   
External-dependecy

   
F-droid

   
Feature

   
Google-play

   
Improvement

   
Invalid

   
Investigate

   
LGTM-done

legitimation approved

  
LGTM-need

one approval required

  
Long-term

   
Major-release

   
Minor-release

   
Needs-cleanup

   
Needs-feedback

   
Needs-help

   
Priority-critical

   
Priority-low

   
Priority-medium

   
Question

   
Ready

Ready for testing

  
Refactor

   
Regression

   
Release

   
Repository

[Repository] Issues and PRs related to the app repo

  
Security

   
Suggestion

   
Support

   
Testing

   
Translation

   
UI/UX

   
Upstream

   
Website

[Website] Issues and PRs related to the app website

  
WIP
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
Milestone
Clear milestone
No items
No Milestone
2.4.0
Assignees
Clear assignees
No Assignees
6543
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#199
No description provided.
Delete Branch "refactor_issues_call"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?