gitnex/GitNex
gitnex/GitNex
Archived
14
58
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

Allow login if api is restricted via REQUIRE_SIGNIN_VIEW #215

Merged
mmarif merged 1 commits from Unpublished/GitNex:allowRestrictedApi into master 2019-11-27 20:06:32 +00:00
Conversation 3 Commits 1 Files Changed 1 +13 -12
Unpublished commented 2019-11-27 19:09:37 +00:00
Contributor
Copy Link

Fixes #213

Fixes #213
mmarif added the
Improvement
 label 2019-11-27 19:17:07 +00:00
mmarif added this to the 2.3.0 milestone 2019-11-27 19:17:15 +00:00
mmarif commented 2019-11-27 19:22:02 +00:00
Owner
Copy Link

Few things,

All the import lines are removed and added back again including empty lines. You can revert it back to the original.

Push the else if statement next line.

}
else if (loginType == 2) { // token
Few things, All the import lines are removed and added back again including empty lines. You can revert it back to the original. Push the `else if` statement next line. ``` } else if (loginType == 2) { // token ```
Unpublished commented 2019-11-27 19:28:51 +00:00
Author
Contributor
Copy Link

Sure, done :)

Sure, done :)
👍 1
6543 added the
LGTM-need
 label 2019-11-27 19:43:28 +00:00
6543 approved these changes 2019-11-27 19:44:33 +00:00
Dismissed
6543 left a comment
Member

I'm ok with this - it also remove dedundant code

I'm ok with this - it also remove dedundant code
6543 added
LGTM-done
 and removed
LGTM-need
 labels 2019-11-27 20:03:40 +00:00
6543 commented 2019-11-27 20:03:56 +00:00
Member
Copy Link

tested on my instance too @mmarif

tested on my instance too @mmarif
👍 2
mmarif closed this pull request 2019-11-27 20:06:32 +00:00
Unpublished deleted branch allowRestrictedApi 2019-11-27 20:36:01 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Priority-high

   
Accepting-merge-requests

   
API

   
API-dependency

   
Backport

   
Blocked

   
Brainstorming

   
Breaking

Breaking change

  
Bug

   
Changelog

   
CI

   
Cleanup

   
Confirmed

   
Discussion

   
Documentation

   
Duplicate

   
Enhancement

   
External-dependecy

   
F-droid

   
Feature

   
Google-play

   
Improvement

   
Invalid

   
Investigate

   
LGTM-done

legitimation approved

  
LGTM-need

one approval required

  
Long-term

   
Major-release

   
Minor-release

   
Needs-cleanup

   
Needs-feedback

   
Needs-help

   
Priority-critical

   
Priority-low

   
Priority-medium

   
Question

   
Ready

Ready for testing

  
Refactor

   
Regression

   
Release

   
Repository

[Repository] Issues and PRs related to the app repo

  
Security

   
Suggestion

   
Support

   
Testing

   
Translation

   
UI/UX

   
Upstream

   
Website

[Website] Issues and PRs related to the app website

  
WIP
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
Milestone
Clear milestone
No items
No Milestone
2.3.0
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#215
No description provided.
Delete Branch "Unpublished/GitNex:allowRestrictedApi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?