#252 Make DueDate optional on MilestoneCreaton

Merged
mmarif merged 4 commits from 6543/GitNex:milestone-DueDate-optional_240 into master 1 week ago
6543 commented 2 weeks ago

fix #240

fix #240
6543 added this to the 2.4.0 milestone 2 weeks ago
6543 added the
Improvement
label 2 weeks ago
6543 added the
LGTM-need
label 2 weeks ago
6543 commented 2 weeks ago
Poster

@mmarif can you test if this works on your old instance too?

@mmarif can you test if this works on your old instance too?
mmarif commented 2 weeks ago
Owner

I am on 1.10 now. Does it work on 1.10?

I am on 1.10 now. Does it work on 1.10?
6543 commented 2 weeks ago
Poster

it does (tested on 1.10.1)

it does (tested on 1.10.1)
mmarif commented 2 weeks ago
Owner

So it need to be tested on 1.9. Any one you know have 1.9?

So it need to be tested on 1.9. Any one you know have 1.9?
6543 commented 2 weeks ago
Poster

no i dont

no i dont
6543 commented 2 weeks ago
Poster

1.9.x should not be used anyway .. insecure

1.9.x should not be used anyway .. insecure
mmarif commented 2 weeks ago
Owner

Agree, should not be used. But we still support 1.9 and if user has crashes then they will complain.

I will setup 1.9 instance on my server. Will need some time.

Agree, should not be used. But we still support 1.9 and if user has crashes then they will complain. I will setup 1.9 instance on my server. Will need some time.
6543 commented 2 weeks ago
Poster

@mmarif did it worked?

otherwhise i can add a version check and let gitea deside when a due-date is required?

@mmarif did it worked? otherwhise i can add a version check and let gitea deside when a due-date is required?
mmarif commented 2 weeks ago
Owner

I haven't setup the instance yet. Quite busy with other stuff.

If you can make it version specific based on user gitea version, that will work too.

I haven't setup the instance yet. Quite busy with other stuff. If you can make it version specific based on user gitea version, that will work too.
6543 commented 2 weeks ago
Poster

@mmarif in general we could use version check for features wich are new in version X/Y …

-> f5d0d4e389

for example the (emoji-)Reaction API is available in 1.11.0 and higher …

@mmarif in general we could use version check for features wich are new in version X/Y ... -> f5d0d4e389f1ac36533117c38c3f3175161e99b9 for example the (emoji-)Reaction API is available in 1.11.0 and higher ...
6543 commented 1 week ago
Poster

@mmarif this PR is ready and waiting for your review :)

@mmarif this PR is ready and waiting for your review :)
mmarif removed the
LGTM-need
label 1 week ago
mmarif added the
LGTM-done
label 1 week ago
mmarif deleted branch milestone-DueDate-optional_240 1 week ago
The pull request has been merged as ec62e3cebf.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.