Make DueDate optional on MilestoneCreaton #252

Merged
mmarif merged 3 commits from 6543/GitNex:milestone-DueDate-optional_240 into master 2020-01-14 12:52:37 +00:00
Member

fix #240

fix #240
6543 added this to the 2.4.0 milestone 2020-01-02 15:01:43 +00:00
6543 added the
Improvement
LGTM-need
labels 2020-01-02 15:01:43 +00:00
Author
Member

@mmarif can you test if this works on your old instance too?

@mmarif can you test if this works on your old instance too?
Owner

I am on 1.10 now. Does it work on 1.10?

I am on 1.10 now. Does it work on 1.10?
Author
Member

it does (tested on 1.10.1)

it does (tested on 1.10.1)
Owner

So it need to be tested on 1.9. Any one you know have 1.9?

So it need to be tested on 1.9. Any one you know have 1.9?
Author
Member

no i dont

no i dont
Author
Member

1.9.x should not be used anyway .. insecure

1.9.x should not be used anyway .. insecure
Owner

Agree, should not be used. But we still support 1.9 and if user has crashes then they will complain.

I will setup 1.9 instance on my server. Will need some time.

Agree, should not be used. But we still support 1.9 and if user has crashes then they will complain. I will setup 1.9 instance on my server. Will need some time.
Author
Member

@mmarif did it worked?

otherwhise i can add a version check and let gitea deside when a due-date is required?

@mmarif did it worked? otherwhise i can add a version check and let gitea deside when a due-date is required?
Owner

I haven't setup the instance yet. Quite busy with other stuff.

If you can make it version specific based on user gitea version, that will work too.

I haven't setup the instance yet. Quite busy with other stuff. If you can make it version specific based on user gitea version, that will work too.
Author
Member

@mmarif in general we could use version check for features wich are new in version X/Y ...

-> f5d0d4e389

for example the (emoji-)Reaction API is available in 1.11.0 and higher ...

@mmarif in general we could use version check for features wich are new in version X/Y ... -> f5d0d4e389f1ac36533117c38c3f3175161e99b9 for example the (emoji-)Reaction API is available in 1.11.0 and higher ...
Author
Member

@mmarif this PR is ready and waiting for your review :)

@mmarif this PR is ready and waiting for your review :)
mmarif added
LGTM-done
and removed
LGTM-need
labels 2020-01-14 12:52:01 +00:00
mmarif closed this pull request 2020-01-14 12:52:37 +00:00
mmarif deleted branch milestone-DueDate-optional_240 2020-01-14 12:53:08 +00:00
mmarif referenced this issue from a commit 2020-02-24 18:50:55 +00:00
Refactor assignee(s) API calls (#199) Merge branch 'master' into refactor_issues_call Remove credits, add donators (#268) Merge branch 'master' into 264-remove-credits Merge pull request 'Support for c header files' (#266) from 265-files-support-in-file-viewer into master Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/266 Remove credits, add donators support for c header files Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/268 Merge pull request 'Support for c header files' (#266) from 265-files-support-in-file-viewer into master Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/266 support for c header files fix Merge branch 'master' into refactor_issues_call Support pdf files in file viewer (#259) auto convert EOL this fix it for me fix layout implement support for pdf files in file viewer Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/259 Reviewed-by: 6543 <6543@noreply.gitea.io> Make DueDate optional on MilestoneCreaton (#252) Merge branch 'master' into milestone-DueDate-optional_240 add check again if gitea is older than 1.10.0 ... Crowdin [2020-01-04] + add Latvian (#253) update Translators add Latvian update Crowdin Co-authored-by: 6543 <6543@obermui.de> make DueDate optional on MilestoneCreaton Co-authored-by: 6543 <6543@obermui.de> Crowdin [2020-01-04] + add Latvian (#253) update Translators add Latvian update Crowdin Co-authored-by: 6543 <6543@obermui.de> Merge branch '51-custom-fonts' of gitnex/GitNex into master Reviewed-by: 6543 <6543@noreply.gitea.io> Implement across the whole app Implementation of custom fonts app wide Merge branch 'crowdin_2019-12-25' of gitnex/GitNex into master add user to the “new issue” assignees dialog refactor.start() update from crowdin Merge branch 'backport-243' of gitnex/GitNex into master backport url slashes fix Merge branch 'fix-238' of gitnex/GitNex into master fix Merge branch 'backport-235' of gitnex/GitNex into master backport fix #235 Merge branch 'backport-232' of gitnex/GitNex into master show all issues and prs Merge branch '206-repos-in-explore-screen' of gitnex/GitNex into master Load default list of explore repositories Merge branch '225-backport' of gitnex/GitNex into master copy and support files backport - #225 Merge branch '226-backport' of gitnex/GitNex into master fix alignments backport Co-authored-by: M M Arif <mmarif@swatian.com> Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/199
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#252
No description provided.