#259 Support pdf files in file viewer

Merged
mmarif merged 4 commits from 181-pdf-support into master 2 weeks ago
mmarif commented 3 weeks ago

Will close #181

Will close #181
mmarif added this to the 2.4.0 milestone 3 weeks ago
mmarif added the
Feature
label 3 weeks ago
mmarif self-assigned this 3 weeks ago
mmarif added the
LGTM-need
label 3 weeks ago
6543 commented 3 weeks ago
Collaborator

@mmarif I added a commit and this should be good for now (the issue with hiding pdf stuff sometimes)

I also tested the parametrs but as it is now it is the best in my opinion :)

@mmarif I added a commit and this should be good for now (the issue with hiding pdf stuff sometimes) I also tested the parametrs but as it is now it is the best in my opinion :)
6543 approved these changes 3 weeks ago
:rocket:
6543 removed the
LGTM-need
label 3 weeks ago
6543 added the
LGTM-done
label 3 weeks ago
mmarif commented 3 weeks ago
Owner

@6543 should be ok then. Bdw the last line in your commit is required?

Also I am not getting emails from gitea anymore, is it the same for you?

@6543 should be ok then. Bdw the last line in your commit is required? Also I am not getting emails from gitea anymore, is it the same for you?
6543 commented 3 weeks ago
Collaborator

@mmarif you are right! about the mails I'll report

and about the EOL formation I'll add a .gitattribute witch should take care of it (windows<->unix eol) but I think each file should end with a EOL (IDEs normlay add it to the sourcecode)

@mmarif you are right! about the mails I'll report and about the EOL formation I'll add a `.gitattribute` witch should take care of it (windows<->unix eol) but I think each file should end with a EOL (IDEs normlay add it to the sourcecode)
mmarif deleted branch 181-pdf-support 2 weeks ago

Reviewers

6543 approved these changes 3 weeks ago
The pull request has been merged as 1293e8be27.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.