gitnex/GitNex
gitnex/GitNex
Archived
14
57
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

Theme and Icons #260

Merged
mmarif merged 15 commits from light-theme into master 2020-03-08 13:52:34 +00:00
Conversation 9 Commits 15 Files Changed 214 +7 -19
4 changed files with 7 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 900b060c31 - Show all commits

5
app/src/main/java/org/mian/gitnex/activities/BaseActivity.java
View File

@ -17,10 +17,7 @@ public abstract class BaseActivity extends AppCompatActivity {
final TinyDB tinyDb = new TinyDB(getApplicationContext());
if(tinyDb.getInt("themeId") == 0) {
setTheme(R.style.AppTheme);
}
else if(tinyDb.getInt("themeId") == 1) {
if(tinyDb.getInt("themeId") == 1) {
6543 commented 2020-03-06 18:48:52 +00:00
Outdated
Review
Copy Link

can you test for == 1 and else set default theme?

can you test for == 1 and else set default theme?
mmarif commented 2020-03-06 20:04:12 +00:00
Outdated
Review
Copy Link

Yes, that will work too.

Yes, that will work too.
setTheme(R.style.AppThemeLight);
}
else {

7
app/src/main/java/org/mian/gitnex/adapters/RepoStargazersAdapter.java
View File

@ -114,13 +114,10 @@ public class RepoStargazersAdapter extends BaseAdapter {
viewHolder.memberName.setTypeface(myTypeface);
}
if(tinyDb.getInt("themeId") == 0) { // dark
viewHolder.memberName.setTextColor(mCtx.getResources().getColor(R.color.white));
}
else if(tinyDb.getInt("themeId") == 1) { //light
if(tinyDb.getInt("themeId") == 1) { //light
6543 commented 2020-03-06 18:53:03 +00:00
Outdated
Review
Copy Link

same as first comment - why not make if (is light) [else if (is other theme - not here jet)] else default -> dark theme

same as first comment - why not make if (is light) [else if (is other theme - not here jet)] else default -> dark theme
mmarif commented 2020-03-06 20:04:25 +00:00
Outdated
Review
Copy Link

Yup, you are right.

Yup, you are right.
viewHolder.memberName.setTextColor(mCtx.getResources().getColor(R.color.lightThemeTextColor));
}
else {
else { // dark
viewHolder.memberName.setTextColor(mCtx.getResources().getColor(R.color.white));
}

7
app/src/main/java/org/mian/gitnex/adapters/RepoWatchersAdapter.java
View File

@ -114,13 +114,10 @@ public class RepoWatchersAdapter extends BaseAdapter {
viewHolder.memberName.setTypeface(myTypeface);
}
if(tinyDb.getInt("themeId") == 0) { // dark
viewHolder.memberName.setTextColor(mCtx.getResources().getColor(R.color.white));
}
else if(tinyDb.getInt("themeId") == 1) { //light
if(tinyDb.getInt("themeId") == 1) { //light
viewHolder.memberName.setTextColor(mCtx.getResources().getColor(R.color.lightThemeTextColor));
}
else {
else { // dark
viewHolder.memberName.setTextColor(mCtx.getResources().getColor(R.color.white));
}

7
app/src/main/java/org/mian/gitnex/adapters/TeamMembersByOrgAdapter.java
View File

@ -115,13 +115,10 @@ public class TeamMembersByOrgAdapter extends BaseAdapter {
viewHolder.memberName.setTypeface(myTypeface);
}
if(tinyDb.getInt("themeId") == 0) { // dark
viewHolder.memberName.setTextColor(mCtx.getResources().getColor(R.color.white));
}
else if(tinyDb.getInt("themeId") == 1) { //light
if(tinyDb.getInt("themeId") == 1) { //light
viewHolder.memberName.setTextColor(mCtx.getResources().getColor(R.color.lightThemeTextColor));
}
else {
else { // dark
viewHolder.memberName.setTextColor(mCtx.getResources().getColor(R.color.white));
}