Crowdin [2020-03-11] #277

@6543 weird. Maybe Gitea permission issue? Here are the things to fix: file is `values-fa/strings.xml` Line 65, 66, 67 (see the screenshot for details) Line 154, 166 and 167 has broken string in values-fa/strings.xml. %1$s is broken.

Screenshot_20200312_190547.png

24 KiB

6543 commented

2020-03-13 02:50:11 +00:00

@mmarif this is a "pending" comment you have to finish the review

mmarif requested changes 2020-03-13 12:31:36 +00:00

Dismissed

app/src/main/res/values-fa/strings.xml

						
				@ -92,0 +63,4 @@

				    <string name="navigation_drawer_close">بستن کشوی ناوبری</string>

				    <string name="logo">ورود به گیتی</string>

				    <string name="urlInfoTooltip">1. پروتوکل صحیح را انتخاب کنید (http یا https)

				2. URL گیتی را وارد کنید. مثلا: try.gitea.io

mmarif commented

2020-03-11 19:40:14 +00:00

2., 3. and 4. is missing staring break line -> \n2.

2., 3. and 4. is missing staring break line -> `\n2.`

app/src/main/res/values-fa/strings.xml

						
				@ -163,3 +155,1 @@

				    <string name="milestoneDateEmpty">Please choose due date</string>

				    <string name="milestoneOpenIssues">Open issues : %1$d</string>

				    <string name="milestoneClosedIssues">Closed issues : %1$d</string>

				    <string name="collaboratorsNameToast">مشارکت کننده : %1$s</string>

mmarif commented

2020-03-11 19:31:25 +00:00

%1$s is broken here. It will crash the app.

app/src/main/res/values-fa/strings.xml

						
				@ -166,0 +164,4 @@

				    <string name="milestoneCreated">نقطه عطف با موفقیت ساخته شد</string>

				    <string name="milestoneCreatedError">مشکلی پیش آمده. لطفا دوباره تلاش کنید</string>

				    <string name="milestoneDateEmpty">لطفا تاریخ مقرر را انتخاب کنید</string>

				    <string name="milestoneOpenIssues">مسائل باز : %1$d</string>

mmarif commented

2020-03-11 19:31:44 +00:00

Same as above(broken string)

app/src/main/res/values-fa/strings.xml Outdated

						
				@ -166,0 +165,4 @@

				    <string name="milestoneCreatedError">مشکلی پیش آمده. لطفا دوباره تلاش کنید</string>

				    <string name="milestoneDateEmpty">لطفا تاریخ مقرر را انتخاب کنید</string>

				    <string name="milestoneOpenIssues">مسائل باز : %1$d</string>

				    <string name="milestoneClosedIssues">مسائل بسته : %1$d</string>

mmarif commented

2020-03-11 19:31:55 +00:00

Same as above(broken string)

mmarif commented

2020-03-13 12:36:31 +00:00

this is a “pending” comment you have to finish the review

Just a thought, if adding code comments/review the Request Changes button should be visible to let the user know to submit the comments.

> this is a “pending” comment you have to finish the review Just a thought, if adding code comments/review the `Request Changes` button should be visible to let the user know to submit the comments.

mmarif added

LGTM-done

and removed

LGTM-need

labels 2020-03-13 19:51:00 +00:00

mmarif referenced this issue from a commit

2020-03-13 19:51:35 +00:00

Crowdin [2020-03-11] (#277) update update from crowdin Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/277

mmarif closed this pull request

2020-03-13 19:51:38 +00:00

mmarif deleted branch crowdin_2020-03-11

2020-03-13 19:51:51 +00:00