gitnex/GitNex
gitnex/GitNex
Archived
14
58
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

Handle reserved names & patterns on repo creation #315

Merged
mmarif merged 4 commits from 312-handle-reserved-names-patterns into master 2020-03-29 18:57:25 +00:00
Conversation 1 Commits 4 Files Changed 2 +19 -6
6543 commented 2020-03-29 15:10:51 +00:00
Member
Copy Link

close #312

close #312
6543 added this to the 2.5.0 milestone 2020-03-29 15:10:51 +00:00
6543 added the
Enhancement
WIP
 labels 2020-03-29 15:10:51 +00:00
6543 self-assigned this 2020-03-29 15:10:51 +00:00
6543 added
LGTM-need
 and removed
WIP
 labels 2020-03-29 15:54:11 +00:00
mmarif reviewed 2020-03-29 16:33:54 +00:00
Dismissed
app/src/main/res/values/strings.xml Outdated
@ -102,6 +102,8 @@
<string name="repoNameErrorEmpty">Repository name is empty</string>
<string name="repoNameErrorInvalid">Repository name is not valid. [a&#8211;z A&#8211;Z 0&#8211;9 &#8211; _]</string>
<string name="repoNameErroReservedName">Repository name is reserved</string>
mmarif commented 2020-03-29 16:30:54 +00:00
Owner

repoNameErroReservedName > repoNameErrorReservedName

r is missing in Error

repoNameErroReservedName > repoNameErrorReservedName r is missing in Error
app/src/main/res/values/strings.xml Outdated
@ -103,2 +103,4 @@
<string name="repoNameErrorEmpty">Repository name is empty</string>
<string name="repoNameErrorInvalid">Repository name is not valid. [a&#8211;z A&#8211;Z 0&#8211;9 &#8211; _]</string>
<string name="repoNameErroReservedName">Repository name is reserved</string>
<string name="repoNameErroReservedPatterns">Repository name contains reserved patterns</string>
mmarif commented 2020-03-29 16:31:51 +00:00
Owner

repoNameErroReservedPatterns

Same here.

Also the string would look better:

Repository name contains reserved keywords

repoNameErroReservedPatterns Same here. Also the string would look better: > Repository name contains reserved keywords
6543 commented 2020-03-29 17:05:23 +00:00
Author
Member
Copy Link

done

done
mmarif approved these changes 2020-03-29 18:56:29 +00:00
Dismissed
mmarif closed this pull request 2020-03-29 18:57:23 +00:00
mmarif deleted branch 312-handle-reserved-names-patterns 2020-03-29 18:57:55 +00:00
6543 added
LGTM-done
 and removed
LGTM-need
 labels 2020-03-31 22:38:47 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Priority-high

   
Accepting-merge-requests

   
API

   
API-dependency

   
Backport

   
Blocked

   
Brainstorming

   
Breaking

Breaking change

  
Bug

   
Changelog

   
CI

   
Cleanup

   
Confirmed

   
Discussion

   
Documentation

   
Duplicate

   
Enhancement

   
External-dependecy

   
F-droid

   
Feature

   
Google-play

   
Improvement

   
Invalid

   
Investigate

   
LGTM-done

legitimation approved

  
LGTM-need

one approval required

  
Long-term

   
Major-release

   
Minor-release

   
Needs-cleanup

   
Needs-feedback

   
Needs-help

   
Priority-critical

   
Priority-low

   
Priority-medium

   
Question

   
Ready

Ready for testing

  
Refactor

   
Regression

   
Release

   
Repository

[Repository] Issues and PRs related to the app repo

  
Security

   
Suggestion

   
Support

   
Testing

   
Translation

   
UI/UX

   
Upstream

   
Website

[Website] Issues and PRs related to the app website

  
WIP
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
Milestone
Clear milestone
No items
No Milestone
2.5.0
Assignees
Clear assignees
No Assignees
6543
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#315
No description provided.
Delete Branch "312-handle-reserved-names-patterns"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?