Adjusting proportions of issue labels. #325

Merged
mmarif merged 3 commits from :style-changes into master 2020-03-31 18:53:42 +00:00
Member
No description provided.
Author
Member
No description provided.
Owner

Can you apply the same to labels fragment screen and see how it look like because of new width(25).

My other concern is font size(30 is small) for smaller screen. The label will become too small. If it's fine there I have no issue with it.

Can you apply the same to labels fragment screen and see how it look like because of new width(25). My other concern is font size(30 is small) for smaller screen. The label will become too small. If it's fine there I have no issue with it.
Author
Member

Can you apply the same to labels fragment screen [...]

I still dont get it. Which fragment do you mean?

> Can you apply the same to labels fragment screen [...] I still dont get it. Which fragment do you mean?
Owner
This file, https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/adapters/LabelsAdapter.java Repository Labels tab.
Author
Member

Ah, okay.

Ah, okay.
Author
Member

When applying same size to adapter:

When applying same size to adapter:
118 KiB
Author
Member

When increasing size in adapter:

When increasing size in adapter:
127 KiB
Author
Member

Should i increase the font size?

Should i increase the font size?
Owner

My suggestions:

  • Keep the width as is
  • keep the height as is
  • Font size keep between 32 to 36
  • For round cornors 10 is fine
My suggestions: - Keep the width as is - keep the height as is - Font size keep between 32 to 36 - For round cornors 10 is fine
Owner

Also apply to adapter.

Also apply to adapter.
Author
Member

I don't think that keeping width and height will look good with a small font size, but i can make a screenshot.

I don't think that keeping width and height will look good with a small font size, but i can make a screenshot.
Author
Member

This were the proportions we started with (font size = 32). I think those labels are a little bit to big, they don't fit the overall text size.

This were the proportions we started with (font size = 32). I think those labels are a little bit to big, they don't fit the overall text size.
Author
Member

For reference (screenshot of official github app):

For reference (screenshot of official github app):
Owner

Yea, smaller looks better.

Can you apply the changes to adapter(all changes you made). Want to try.

Yea, smaller looks better. Can you apply the changes to adapter(all changes you made). Want to try.
Author
Member

22010d953a Done.

22010d953af7d91da19175d9e7ed1647e87f7592 Done.
Author
Member
No description provided.
481 KiB
opyale changed title from Adjusting proportions of issue labels. to WIP: Adjusting proportions of issue labels. 2020-03-31 18:46:47 +00:00
Owner

Looks good.

Looks good.
mmarif added the
Enhancement
label 2020-03-31 18:52:18 +00:00
mmarif added this to the 2.5.0 milestone 2020-03-31 18:52:20 +00:00
opyale changed title from WIP: Adjusting proportions of issue labels. to Adjusting proportions of issue labels. 2020-03-31 18:52:41 +00:00
mmarif approved these changes 2020-03-31 18:52:48 +00:00
Dismissed
Author
Member

Thanks.

Thanks.
mmarif closed this pull request 2020-03-31 18:53:41 +00:00
opyale deleted branch style-changes 2020-03-31 18:54:24 +00:00
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#325
No description provided.