Adjusting proportions of issue labels. #325
No reviewers
Labels
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
No Milestone
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitnex/GitNex#325
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch ":style-changes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Can you apply the same to labels fragment screen and see how it look like because of new width(25).
My other concern is font size(30 is small) for smaller screen. The label will become too small. If it's fine there I have no issue with it.
I still dont get it. Which fragment do you mean?
This file, https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/java/org/mian/gitnex/adapters/LabelsAdapter.java
Repository Labels tab.
Ah, okay.
When applying same size to adapter:
When increasing size in adapter:
Should i increase the font size?
My suggestions:
Also apply to adapter.
I don't think that keeping width and height will look good with a small font size, but i can make a screenshot.
This were the proportions we started with (font size = 32). I think those labels are a little bit to big, they don't fit the overall text size.
For reference (screenshot of official github app):
Yea, smaller looks better.
Can you apply the changes to adapter(all changes you made). Want to try.
22010d953a
Done.Adjusting proportions of issue labels.to WIP: Adjusting proportions of issue labels.Looks good.
WIP: Adjusting proportions of issue labels.to Adjusting proportions of issue labels.Thanks.