Small design changes #327

opyale · 2020-03-31T03:15:33Z

opyale commented

2020-03-31 03:15:33 +00:00

No description provided.

mmarif reviewed 2020-03-31 05:45:33 +00:00

Dismissed

app/src/main/res/layout/branches_list.xml Outdated

						
				@ -24,4 +25,3 @@

				        <TextView

				            android:id="@+id/branchCommitAuthor"

				            android:layout_marginTop="10dp"

mmarif commented

2020-03-31 05:41:25 +00:00

Please keep this

app/src/main/res/layout/branches_list.xml Outdated

						
				@ -18,17 +18,17 @@

				            android:id="@+id/branchName"

				            android:layout_width="match_parent"

				            android:layout_height="wrap_content"

				            android:fontFamily="monospace"

mmarif commented

2020-03-31 05:45:23 +00:00

Not so sure of this change. @6543 what you think?

It will not take effect if font is changed.

Not so sure of this change. @6543 what you think? It will not take effect if font is changed.

app/src/main/res/layout/branches_list.xml Outdated

						
				@ -29,3 +29,3 @@

				            android:layout_height="wrap_content"

				            android:textIsSelectable="true"

				            android:textColor="?attr/primaryTextColor"

				            android:textIsSelectable="true"

mmarif commented

2020-03-31 05:41:56 +00:00

What's the change here?

6543 commented

2020-03-31 11:41:49 +00:00

I'm for removing this diff too

mmarif added the

Improvement

label 2020-03-31 05:46:11 +00:00

mmarif changed title from ~~Small design changes.~~ to Small design changes

2020-03-31 05:46:31 +00:00

opyale commented

2020-03-31 14:53:27 +00:00

Removed changes of branches_list.xml

mmarif added this to the 2.5.0 milestone 2020-03-31 15:25:29 +00:00

mmarif approved these changes 2020-03-31 15:26:00 +00:00

Dismissed

mmarif added the

LGTM-done

label 2020-03-31 15:28:39 +00:00

6543 commented

2020-03-31 17:48:31 +00:00

@anonTree1417 pleace resolfe confict

the file app/src/main/res/layout/labels_list.xml moved to app/src/main/res/layout/list_labels.xml

@anonTree1417 pleace resolfe confict the file `app/src/main/res/layout/labels_list.xml` moved to `app/src/main/res/layout/list_labels.xml`

6543 commented

2020-03-31 17:53:01 +00:00

@anonTree1417 just execute this:

git checkout -f master; git pull; git checkout -f add-styling; git merge --no-ff master

oder in deutsch: merge den aktuellen masterbranch in dinen feature branch

@anonTree1417 just execute this: `git checkout -f master; git pull; git checkout -f add-styling; git merge --no-ff master` oder in deutsch: merge den aktuellen masterbranch in dinen feature branch

6543 approved these changes 2020-03-31 17:55:13 +00:00

Dismissed

mmarif referenced this issue from a commit

2020-03-31 18:49:40 +00:00

Small design changes (#327) Merge remote-tracking branch 'remotes/main/master' into add-styling Restoring branches_list.xml Small design changes. Co-authored-by: anonTree1417 <example@example.com> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/327 Reviewed-by: M M Arif <mmarif@swatian.com> Reviewed-by: 6543 <6543@noreply.gitea.io>

mmarif closed this pull request

2020-03-31 18:49:43 +00:00

opyale deleted branch add-styling

2020-03-31 18:50:58 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers