Share comment of an issue #348

mmarif · 2020-04-03T15:23:39Z

mmarif commented

2020-04-03 15:23:39 +00:00

Closes #339

mmarif added this to the 2.5.0 milestone 2020-04-03 15:23:39 +00:00

mmarif added the

Enhancement

label 2020-04-03 15:23:39 +00:00

mmarif self-assigned this 2020-04-03 15:23:39 +00:00

mmarif added the

LGTM-need

label 2020-04-03 15:24:51 +00:00

6543 reviewed 2020-04-03 16:08:00 +00:00

Dismissed

app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java

						
				@ -107,0 +127,4 @@

									}

									// get comment Url

									String commentUrl = instanceUrlWithProtocol + "/" + repoFullName + "/issues/" + tinyDb.getString("issueNumber") + "#issuecomment-" + commendId.getText();

6543 commented

2020-04-03 16:08:00 +00:00

you have to check if it is a pull if so replace /issues/ with /pulls/ or do we have access to the coment object?
if we have acces just use html_url property

you have to check if it is a pull if so replace `/issues/` with `/pulls/` or do we have access to the coment object? if we have acces just use `html_url` property

mmarif commented

2020-04-03 16:12:48 +00:00

Spot on. Good catch. I will change it to html_url.

mmarif commented

2020-04-03 16:22:29 +00:00

6eb41978e0 should fix this.

https://gitea.com/gitnex/GitNex/commit/6eb41978e08d9c7647e1ec4edf6a2c28815230b6 should fix this.

6543 reviewed 2020-04-03 16:38:02 +00:00

Dismissed

app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java

						
				@ -107,0 +121,4 @@

								commentShare.setOnClickListener(ediComment -> {

									// get url of repo

6543 commented

2020-04-03 16:38:02 +00:00

you can delete L124 to L130 they are not used anymore

6543 approved these changes 2020-04-03 16:47:30 +00:00

Dismissed

6543 added

LGTM-done

and removed

LGTM-need

labels 2020-04-03 16:47:42 +00:00

mmarif referenced this issue from a commit

2020-04-03 16:48:23 +00:00

Share comment of an issue (#348) cleanup Use html_url to fix issue/pr separation Share comment of an issue Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/348 Reviewed-by: 6543 <6543@noreply.gitea.io>

mmarif closed this pull request

2020-04-03 16:48:24 +00:00

mmarif deleted branch 339-share-single-comment

2020-04-03 16:48:33 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

Priority-high

Accepting-merge-requests

No Milestone

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#348