gitnex/GitNex
gitnex/GitNex
Archived
14
58
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

[Doc] update issue-template add pull-template #359

Merged
mmarif merged 7 commits from 6543/GitNex:issue-pull-templates into master 2020-04-06 09:38:10 +00:00
Conversation 4 Commits 7 Files Changed 4 +35 -14
6543 commented 2020-04-05 14:18:18 +00:00
Member
Copy Link
  • Update issue_template
  • make link from contributing to the code-standards
  • Add pull-template
* Update issue_template * make link from contributing to the code-standards * Add pull-template
6543 added the
Documentation
LGTM-need
 labels 2020-04-05 14:18:18 +00:00
mmarif requested changes 2020-04-05 14:31:15 +00:00
Dismissed
.gitea/issue_template.md Outdated
@ -0,0 +1,22 @@
#### Description - describe the bug / feature / suggestion in brief :
#### Expected behaviour - describe what should be the expected result :
mmarif commented 2020-04-05 14:25:59 +00:00
Owner

behaviour - describe can remove extra space after behaviour? :)

`behaviour - describe` can remove extra space after behaviour? :)
.gitea/issue_template.md Outdated
@ -0,0 +8,4 @@
#### Gitea setup :
* Version:
mmarif commented 2020-04-05 14:27:14 +00:00
Owner

Need space after Version

Need space after `Version`
.gitea/issue_template.md Outdated
@ -0,0 +16,4 @@
#### Android version :
#### Screenshots - if any:
mmarif commented 2020-04-05 14:27:34 +00:00
Owner

Need space after any

Need space after `any`
.gitea/pull_request_template.md Outdated
@ -0,0 +2,4 @@
1. Make sure you are targeting the `master` branch, pull requests on release branches are only allowed for bug fixes.
2. Read contributing guidelines: [CONTRIBUTING.md](https://gitea.com/GitNex/GitNex/src/branch/master/CONTRIBUTING.md)
4. Please follow the [Code-Standards](https://gitea.com/gitnex/GitNex/wiki/Code-Standards)
mmarif commented 2020-04-05 14:28:17 +00:00
Owner

Numbering is wrong, 3 is missing.

Numbering is wrong, 3 is missing.
.gitea/pull_request_template.md Outdated
@ -0,0 +3,4 @@
1. Make sure you are targeting the `master` branch, pull requests on release branches are only allowed for bug fixes.
2. Read contributing guidelines: [CONTRIBUTING.md](https://gitea.com/GitNex/GitNex/src/branch/master/CONTRIBUTING.md)
4. Please follow the [Code-Standards](https://gitea.com/gitnex/GitNex/wiki/Code-Standards)
5. Describe what your pull request does and which issue you're targeting (if any)
mmarif commented 2020-04-05 14:29:44 +00:00
Owner

Describe what your pull request does and which issue you're targeting (if any)

Change to

Describe what your pull request does and which issue you're targeting (create one if does not exist)

Describe what your pull request does and which issue you're targeting (if any) Change to Describe what your pull request does and which issue you're targeting (create one if does not exist)
CONTRIBUTING.md Outdated
@ -8,2 +8,4 @@
Please ask if you are not sure about the scope of work to be submitted to avoid waste of time spent on the work.
**Code Standards**
Please follow the code standards, this will help other developers to understand your code too.
mmarif commented 2020-04-05 14:30:57 +00:00
Owner

Are these 3 lines? if so double space is missing at the end.

Are these 3 lines? if so double space is missing at the end.
mmarif commented 2020-04-05 14:32:29 +00:00
Owner
Copy Link

@6543 the templates has moved to .gitea dir?

@6543 the templates has moved to `.gitea` dir?
👍 1
6543 commented 2020-04-05 15:32:08 +00:00
Author
Member
Copy Link

@mmarif done and yes i moved "issue_template.md" to .gitea folder since this is the repo specific config dir for gitea (other locations are only for compatibelety)

@mmarif done and yes i moved "issue_template.md" to .gitea folder since this is the repo specific config dir for gitea (other locations are only for compatibelety)
:gitea: 1
mmarif requested changes 2020-04-05 15:37:39 +00:00
Dismissed
.gitea/issue_template.md Outdated
@ -0,0 +8,4 @@
#### Gitea setup :
* Version:
mmarif commented 2020-04-05 15:36:57 +00:00
Owner

Two minor things, space between version and colon Version: to Version :

Two minor things, space between version and colon `Version:` to `Version :`
.gitea/issue_template.md Outdated
@ -0,0 +16,4 @@
#### Android version :
#### Screenshots - if any:
mmarif commented 2020-04-05 15:37:15 +00:00
Owner

if any: to if any :

`if any: ` to `if any : `
mmarif commented 2020-04-05 15:39:02 +00:00
Owner
Copy Link

Few minor fixes and we are good.

Few minor fixes and we are good.
6543 commented 2020-04-05 19:31:00 +00:00
Author
Member
Copy Link

@mmarif done

@mmarif done
mmarif approved these changes 2020-04-06 09:37:26 +00:00
Dismissed
mmarif added
LGTM-done
 and removed
LGTM-need
 labels 2020-04-06 09:37:45 +00:00
mmarif closed this pull request 2020-04-06 09:38:10 +00:00
6543 deleted branch issue-pull-templates 2020-04-06 14:52:08 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Priority-high

   
Accepting-merge-requests

   
API

   
API-dependency

   
Backport

   
Blocked

   
Brainstorming

   
Breaking

Breaking change

  
Bug

   
Changelog

   
CI

   
Cleanup

   
Confirmed

   
Discussion

   
Documentation

   
Duplicate

   
Enhancement

   
External-dependecy

   
F-droid

   
Feature

   
Google-play

   
Improvement

   
Invalid

   
Investigate

   
LGTM-done

legitimation approved

  
LGTM-need

one approval required

  
Long-term

   
Major-release

   
Minor-release

   
Needs-cleanup

   
Needs-feedback

   
Needs-help

   
Priority-critical

   
Priority-low

   
Priority-medium

   
Question

   
Ready

Ready for testing

  
Refactor

   
Regression

   
Release

   
Repository

[Repository] Issues and PRs related to the app repo

  
Security

   
Suggestion

   
Support

   
Testing

   
Translation

   
UI/UX

   
Upstream

   
Website

[Website] Issues and PRs related to the app website

  
WIP
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#359
No description provided.
Delete Branch "6543/GitNex:issue-pull-templates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?