Extensive code cleanups. #363
No reviewers
Labels
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
No Milestone
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitnex/GitNex#363
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "(deleted):code-cleanup"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Is this done via code reformat?
No, manually.
It would be better via code reformat. Tomorrow if someone(or us) use that, it will be reformat again. So if you use code reformat, it will be once and for all solve this.
There are a few things which I don't like in code reformat, but I don't have choice as it's not provided by idea software.
Maybe there is some other software. I will have a look into that.
This is the project code format file created by AS from project settings. Anything we add should be supported by AS.
https://gitea.com/gitnex/GitNex/src/branch/master/.idea/codeStyles/Project.xml
Of course.
as comments
@ -57,3 +30,1 @@
FontsOverride.setDefaultFont(this, "MONOSPACE", "fonts/roboto.ttf");
FontsOverride.setDefaultFont(this, "SERIF", "fonts/roboto.ttf");
FontsOverride.setDefaultFont(this, "SANS_SERIF", "fonts/roboto.ttf");
switch(tinyDb.getInt("customFontId")) {
can you pick this change to a new pull
@ -58,6 +58,7 @@ import org.mian.gitnex.clients.RetrofitClient;
import org.mian.gitnex.fragments.BottomSheetSingleIssueFragment;
import org.mian.gitnex.helpers.AlertDialogs;
import org.mian.gitnex.helpers.Authorization;
import org.mian.gitnex.helpers.FontsOverride;
can you put this cange to a own pull
yes.
@ -65,3 +60,1 @@
}
else {
Toasty.info(context, context.getString(R.string.filesGenericError));
switch(fileType.getText().toString()) {
can you put this to a new pull
@ -169,3 +168,1 @@
}
else {
holder.fileTypeImage.setImageDrawable(mCtx.getResources().getDrawable(R.drawable.ic_question_mark_24));
switch(currentItem.getType()) {
here too
@opyale this pr is huge!
as on code-commits:
can you move:
tanks!
the rest has to be done at once ... so we dont have merge-conflicts the whole time ...
thanks!
I will do that.
Edit: Bug.
I will close this PR, because most of the issues @6543 adressed were fixed by now.