Extensive code cleanups. #363

Closed
opyale wants to merge 3 commits from (deleted):code-cleanup into master
Member
No description provided.
opyale added the
Long-term
Needs-feedback
Refactor
labels 2020-04-06 11:58:24 +00:00
Owner

Is this done via code reformat?

Is this done via code reformat?
Author
Member

Is this done via code reformat?

No, manually.

> Is this done via code reformat? No, manually.
Owner

It would be better via code reformat. Tomorrow if someone(or us) use that, it will be reformat again. So if you use code reformat, it will be once and for all solve this.

There are a few things which I don't like in code reformat, but I don't have choice as it's not provided by idea software.

It would be better via code reformat. Tomorrow if someone(or us) use that, it will be reformat again. So if you use code reformat, it will be once and for all solve this. There are a few things which I don't like in code reformat, but I don't have choice as it's not provided by idea software.
Author
Member

There are a few things which I don’t like in code reformat, but I don’t have choice as it’s not provided by idea software.

Maybe there is some other software. I will have a look into that.

> There are a few things which I don’t like in code reformat, but I don’t have choice as it’s not provided by idea software. Maybe there is some other software. I will have a look into that.
Owner

This is the project code format file created by AS from project settings. Anything we add should be supported by AS.

https://gitea.com/gitnex/GitNex/src/branch/master/.idea/codeStyles/Project.xml

This is the project code format file created by AS from project settings. Anything we add should be supported by AS. https://gitea.com/gitnex/GitNex/src/branch/master/.idea/codeStyles/Project.xml
Author
Member

Of course.

Of course.
6543 reviewed 2020-04-06 21:51:32 +00:00
Dismissed
6543 left a comment
Member

as comments

as comments
@ -57,3 +30,1 @@
FontsOverride.setDefaultFont(this, "MONOSPACE", "fonts/roboto.ttf");
FontsOverride.setDefaultFont(this, "SERIF", "fonts/roboto.ttf");
FontsOverride.setDefaultFont(this, "SANS_SERIF", "fonts/roboto.ttf");
switch(tinyDb.getInt("customFontId")) {

can you pick this change to a new pull

can you pick this change to a new pull
@ -58,6 +58,7 @@ import org.mian.gitnex.clients.RetrofitClient;
import org.mian.gitnex.fragments.BottomSheetSingleIssueFragment;
import org.mian.gitnex.helpers.AlertDialogs;
import org.mian.gitnex.helpers.Authorization;
import org.mian.gitnex.helpers.FontsOverride;

can you put this cange to a own pull

can you put this cange to a own pull
Author
Member

yes.

yes.
@ -65,3 +60,1 @@
}
else {
Toasty.info(context, context.getString(R.string.filesGenericError));
switch(fileType.getText().toString()) {

can you put this to a new pull

can you put this to a new pull
@ -169,3 +168,1 @@
}
else {
holder.fileTypeImage.setImageDrawable(mCtx.getResources().getDrawable(R.drawable.ic_question_mark_24));
switch(currentItem.getType()) {

here too

here too
Member

@opyale this pr is huge!

as on code-commits:
can you move:

  • all changes with the kind: "if statement -> case select" to a new pull
  • the "helpers.FontsOverride" changes to a own pull

tanks!

the rest has to be done at once ... so we dont have merge-conflicts the whole time ...

@opyale this pr is huge! as on code-commits: can you move: * all changes with the kind: "if statement -> case select" to a new pull * the "helpers.FontsOverride" changes to a own pull tanks! the rest has to be done at once ... so we dont have merge-conflicts the whole time ...
Author
Member

as on code-commits: can you move:

all changes with the kind: “if statement -> case select” to a new pull
the “helpers.FontsOverride” changes to a own pull

thanks!

I will do that.

Edit: Bug.

> as on code-commits: can you move: all changes with the kind: “if statement -> case select” to a new pull the “helpers.FontsOverride” changes to a own pull thanks! I will do that. Edit: Bug.
opyale self-assigned this 2020-04-06 22:39:55 +00:00
opyale added
Invalid
Suggestion
and removed
Needs-feedback
Long-term
labels 2020-04-07 21:24:16 +00:00
Author
Member

I will close this PR, because most of the issues @6543 adressed were fixed by now.

I will close this PR, because most of the issues @6543 adressed were fixed by now.
opyale closed this pull request 2020-04-12 15:36:33 +00:00
6543 deleted branch code-cleanup 2020-04-12 18:56:44 +00:00
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#363
No description provided.