gitnex/GitNex
gitnex/GitNex
Archived
14
58
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

Notifications #383

Closed
opyale wants to merge 38 commits from (deleted):notifications into master
pull from: (deleted):notifications
merge into: gitnex:master
Conversation 5 Commits 38 Files Changed 18 +910 -9
opyale commented 2020-04-07 22:32:43 +00:00
Member
Copy Link

Closes #5

Help is very much appreciated in the following topics:

  • Implementing a BottomSheetFragment for the notifications list (some progress was already made)
  • Reformatting code (at the very end of the pr)
  • Completing contentDescription in ImageViews and strings.xml
  • Hiding Notifications in Drawer if current version of Gitea does not meet requirements
  • Implementing 'load more' in notifications list.
  • Implementing a FAB in notifications fragment to switch between seen and unseen notifications. (Preferred icon: ic_watchers)
  • Implementing a solution (onItemClickListener) where the user is being redirected to the notifications source (issue, pr).
  • etc.

This work is already done and represents the basis:

  • Implementing the notifications API
  • Implementing a WorkManager to display and poll for new notifications
  • Added option in settings to customize the polling delay.
  • Added a NotificationFragment with corresponding NotificationsAdapter.
  • Version check to prevent polling if current version does not meet requirements
  • Created basic and a non-setup BottomSheetNotificationsFragment

I would be very grateful if you, @mmarif and @6543 could help me. Working together on notifications would make much more fun.

Closes #5 Help is very much appreciated in the following topics: - [ ] Implementing a BottomSheetFragment for the notifications list (some progress was already made) - [ ] Reformatting code (at the very end of the pr) - [ ] Completing contentDescription in ImageViews and strings.xml - [ ] Hiding Notifications in Drawer if current version of Gitea does not meet requirements - [ ] Implementing 'load more' in notifications list. - [ ] Implementing a FAB in notifications fragment to switch between seen and unseen notifications. (Preferred icon: ic_watchers) - [ ] Implementing a solution (onItemClickListener) where the user is being redirected to the notifications source (issue, pr). - [ ] etc. This work is already done and represents the basis: - [x] Implementing the notifications API - [x] Implementing a WorkManager to display and poll for new notifications - [x] Added option in settings to customize the polling delay. - [x] Added a NotificationFragment with corresponding NotificationsAdapter. - [x] Version check to prevent polling if current version does not meet requirements - [x] Created basic and a non-setup BottomSheetNotificationsFragment I would be very grateful if you, @mmarif and @6543 could help me. Working together on notifications would make much more fun.
opyale added the
Enhancement
API
Long-term
WIP
 labels 2020-04-07 22:32:43 +00:00
opyale self-assigned this 2020-04-07 22:32:44 +00:00
opyale changed title from Notifications. to [WIP] Notifications. 2020-04-07 22:35:36 +00:00
6543 requested changes 2020-04-07 22:37:01 +00:00
Dismissed
6543 commented 2020-04-07 23:47:44 +00:00
Member
Copy Link

Would be nice if you can add a general NotificationView and make notifications accessable first ... this should go into this pull.

the notification checker for the background can be done in a second pull ...

Would be nice if you can add a general NotificationView and make notifications accessable first ... this should go into this pull. the notification checker for the background can be done in a second pull ...
opyale commented 2020-04-08 04:16:55 +00:00
Author
Member
Copy Link

... this should go into this pull.

@6543 I dont want to be mean (don't understand me wrong), but please dont tell me what i have to do (sounds harsh, im sorry). I am the kind of person who just looks how far he gets.

> ... this should go into this pull. @6543 I dont want to be mean (don't understand me wrong), but please dont tell me what i have to do (sounds harsh, im sorry). I am the kind of person who just looks how far he gets.
opyale commented 2020-04-08 04:21:43 +00:00
Author
Member
Copy Link

@mmarif
@6543

Finally! I've come surprisingly far. Maybe we will even make it to the next release?

@mmarif @6543 Finally! I've come surprisingly far. Maybe we will even make it to the next release?
6543 commented 2020-04-11 00:08:20 +00:00
Member
Copy Link

Before we forget: Notification API will come with v1.12 release officialy first

so we have to disable the whole function if we log into an gitea instance less than 1.12

Before we forget: Notification API will come with v1.12 release officialy first so we have to disable the whole function if we log into an gitea instance less than 1.12
👍 1
mmarif added
Feature
 and removed
API
Enhancement
 labels 2020-04-13 08:06:14 +00:00
6543 changed title from [WIP] Notifications. to Notifications 2020-04-14 14:36:14 +00:00
opyale requested review from 6543 2020-04-14 15:16:44 +00:00
mmarif requested changes 2020-04-14 20:19:11 +00:00
Dismissed
app/build.gradle Outdated
@ -86,2 +87,4 @@
implementation "com.mikepenz:fastadapter-commons:$fastadapter"
implementation "com.mikepenz:fastadapter-extensions:$fastadapter"
implementation "androidx.work:work-runtime:$work_version"
implementation "androidx.work:work-runtime-ktx:$work_version"
mmarif commented 2020-04-14 20:19:01 +00:00
Owner

Haven't got time to look at this yet. But saw the gradle file. We don't need the kotlin library.

You can safely remove this, androidx.work:work-runtime-ktx:$work_version

Haven't got time to look at this yet. But saw the gradle file. We don't need the kotlin library. You can safely remove this, `androidx.work:work-runtime-ktx:$work_version`
opyale marked this conversation as resolved
6543 commented 2020-04-24 11:49:43 +00:00
Member
Copy Link

Noticed: display issue number would be usefull

Noticed: display issue number would be usefull
opyale added 21 commits 2020-05-28 08:53:44 +00:00
Clear cache, configure cache size (#482) 
decrease the compression to have better results

Move cache size outside of maxsize method. fix progress bar alignment for files

Add cache size to picasso

Use getAbsolutePath

Merge branch 'app-cache' of gitea.com:gitnex/GitNex into app-cache

Few imprvoements

Merge branch 'master' into app-cache

small improvement

Implement configure cache size and clear it

Co-authored-by: 6543 <6543@noreply.gitea.io>
Reviewed-on: #482
Reviewed-by: opyale <opyale@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
ab8a5ed505
Adding deprecation dialog. (#492) 
Additional improvements.

Final improvements.

Adding deprecation dialog.

Reviewed-on: #492
Reviewed-by: M M Arif <mmarif@swatian.com>
Some checks failed
continuous-integration/drone/push Build is failing
Details
4e6057171b
Small layout adjustments and correcting typos.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
56d8cd0fac
Merge pull request 'Small layout adjustments and correcting typos.' (#493) from opyale/GitNex:settings-design-typo-adj into master 
Reviewed-on: #493
Reviewed-by: M M Arif <mmarif@swatian.com>
All checks were successful
continuous-integration/drone/push Build is passing
Details
29756511f3
Add corners to popup dialogs
All checks were successful
continuous-integration/drone/pr Build is passing
Details
a4afa5fbc2
Merge pull request 'Add corners to popup dialogs' (#495) from ui-enhancements into master 
Reviewed-on: #495
Reviewed-by: opyale <opyale@noreply.gitea.io>
All checks were successful
continuous-integration/drone/push Build is passing
Details
7f0689524f
Refactor Version Checks (#472) 
Merge branch 'master' into refactor-versionCheck

Merge branch 'master' into refactor-versionCheck

Revert "test CI"

This reverts commit b56eff0920.

test CI

Reformat LoginActivity.java

cleanup

migrate

Working + Tests

add first UnitTest

wip ...

enum2class

Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: #472
Reviewed-by: M M Arif <mmarif@swatian.com>
All checks were successful
continuous-integration/drone/push Build is passing
Details
3de4dd9463
Adding additional functionality.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
408fd9627b
Merge pull request 'Adding additional functionality to build upload.' (#497) from opyale/GitNex:ci-upload-reloaded into master 
Reviewed-on: #497
Reviewed-by: 6543 <6543@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
dd92ef9732
Minor improvements concerning CI. (#498) 
Minor improvements concerning CI

Reviewed-on: #498
Reviewed-by: 6543 <6543@noreply.gitea.io>
All checks were successful
continuous-integration/drone/push Build is passing
Details
0f38d81cd0
Add/Remove new member to team (#483) 
Search as user type, fix datalist.

Code Format

Fix users search theme

add and remove user from team

Add interface and user search and check for being team member or not

bottom sheet menu and few refactors

Co-authored-by: 6543 <6543@noreply.gitea.io>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: #483
Reviewed-by: 6543 <6543@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
7bfdfa3223
[BugFix] Version Compare (#500) 
BugFix of Version

add new TestCase

Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: #500
Reviewed-by: M M Arif <mmarif@swatian.com>
Some checks failed
continuous-integration/drone/push Build is failing
Details
ad7c3696d5
Check Issue Subscription and display button based on that (#445) 
update string names

Update strings

Merge branch 'master' into imprufe-issue-subscription-checking

switch icon as per @mmarif

Migrate to new Version Check & disable IssueSubscription function for gitea < 1.12.0

Merge branch 'master' into imprufe-issue-subscription-checking

Merge branch 'master' into imprufe-issue-subscription-checking

Merge branch 'master' into imprufe-issue-subscription-checking

refactor  & use dismiss()

realy check If issue is subscribed

add 200 http Status check and handle it

Rename WatchRepository to WatchInfo & add checkIssueWatchStatus

Co-authored-by: M M Arif <mmarif@swatian.com>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: #445
Reviewed-by: M M Arif <mmarif@swatian.com>
Some checks failed
continuous-integration/drone/push Build is failing
Details
e83b9eb736
New file saving (#502) 
New file saving

Reviewed-on: #502
Reviewed-by: 6543 <6543@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
1b213783bc
Delete branch after merge (#496) 
delete branch API call

Add fork repo info for branch

Check if pr is mergeable, show message if not.

Use checkbox instead of button

make ripple effects work for buttons with enable/disable

introduce viewbinding

Co-authored-by: 6543 <6543@noreply.gitea.io>
Reviewed-on: #496
Reviewed-by: 6543 <6543@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
d06f5353c6
Update Crowdin 2020-05-21 (#503) 
Update Crowdin 2020-05-21

Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: #503
Reviewed-by: opyale <opyale@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
dc168a732b
Enhance profile screen
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6a6bbef63d
Merge pull request 'Enhance profile screen' (#505) from enhance-profile into master 
Reviewed-on: #505
Reviewed-by: opyale <opyale@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
9541ef7dbc
Decreasing upload time to 3 minutes, increasing attempts and removing proxy. (#504) 
CI: Decreasing upload time to 3 minutes, increasing attempts and removing proxy.

Reviewed-on: #504
Reviewed-by: 6543 <6543@noreply.gitea.io>
All checks were successful
continuous-integration/drone/push Build is passing
Details
6b3ac84113
Milestones filter(open/close) + refactor (#506) 
remove strings

translation: generic but with contecxt

Merge branch 'milestones-filter' of gitea.com:gitnex/GitNex into milestones-filter

Clean up strings

Merge branch 'master' into milestones-filter

clean up and add missing parts

enhance and refactor milestone, added filter for closed and open ms

change to viewbinding

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: 6543 <6543@noreply.gitea.io>
Reviewed-on: #506
Reviewed-by: 6543 <6543@noreply.gitea.io>
All checks were successful
continuous-integration/drone/push Build is passing
Details
b30e2da387
Merge branch 'master' of https://gitea.com/gitnex/GitNex into notifications 
 Conflicts:
	app/src/main/java/org/mian/gitnex/activities/SettingsSecurityActivity.java
	app/src/main/res/layout/activity_settings_security.xml
	app/src/main/res/values/strings.xml
Some checks failed
continuous-integration/drone/pr Build is failing
Details
a72db89413
opyale added 1 commit 2020-05-28 08:59:54 +00:00
Fixing merge issues because of VersionCheck.
Some checks failed
continuous-integration/drone/pr Build is failing
Details
942de34a7c
opyale added 1 commit 2020-05-28 09:11:17 +00:00
Reformatting.
Some checks failed
continuous-integration/drone/pr Build is failing
Details
57450deb3a
opyale added 1 commit 2020-05-28 09:15:42 +00:00
Changing logo of notification.
Some checks failed
continuous-integration/drone/pr Build is failing
Details
28b79e2085
opyale added 3 commits 2020-05-29 22:02:59 +00:00
[CI] Use enviroment variables again (#511) 
[CI] Hopefully fixing upload now.

Reviewed-on: #511
Reviewed-by: 6543 <6543@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
6654b6fb48
Fix org repos layout bug, cleanup layouts and adapters (#514) 
Merge branch 'extra-space' into fix-extra-space

# Conflicts:
#	app/src/main/res/layout/list_repositories.xml

fix margins and clean up

Adjusting margin to be consistent.

remove association

Fix org repos layout bug, cleanup layouts and adapters

Co-authored-by: opyale <opyale@noreply.gitea.io>
Reviewed-on: #514
Reviewed-by: opyale <opyale@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
014b06cc46
Merge branch 'master' into notifications
Some checks failed
continuous-integration/drone/pr Build is failing
Details
5ff51c4f1c
opyale added 4 commits 2020-06-01 16:13:34 +00:00
Improve single issue UI (#518) 
Merge branch 'master' into single-issue-ui

Add progressbar, match the ui to other ui for views(lines etc). And other refactors.

Reviewed-on: #518
Reviewed-by: opyale <opyale@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
6721b09de9
Prepare release 3.0.0 rc1
Some checks failed
continuous-integration/drone/pr Build is failing
Details
bf26a44376
Merge pull request 'Prepare release 3.0.0 rc1' (#520) from prepare-release into master 
Reviewed-on: #520
Some checks failed
continuous-integration/drone/push Build is failing
Details
8b1c79c0c3
Merge branch 'master' into notifications
Some checks failed
continuous-integration/drone/pr Build is failing
Details
6311fad082
opyale closed this pull request 2020-06-04 21:09:07 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Priority-high

   
Accepting-merge-requests

   
API

   
API-dependency

   
Backport

   
Blocked

   
Brainstorming

   
Breaking

Breaking change

  
Bug

   
Changelog

   
CI

   
Cleanup

   
Confirmed

   
Discussion

   
Documentation

   
Duplicate

   
Enhancement

   
External-dependecy

   
F-droid

   
Feature

   
Google-play

   
Improvement

   
Invalid

   
Investigate

   
LGTM-done

legitimation approved

  
LGTM-need

one approval required

  
Long-term

   
Major-release

   
Minor-release

   
Needs-cleanup

   
Needs-feedback

   
Needs-help

   
Priority-critical

   
Priority-low

   
Priority-medium

   
Question

   
Ready

Ready for testing

  
Refactor

   
Regression

   
Release

   
Repository

[Repository] Issues and PRs related to the app repo

  
Security

   
Suggestion

   
Support

   
Testing

   
Translation

   
UI/UX

   
Upstream

   
Website

[Website] Issues and PRs related to the app website

  
WIP
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
opyale
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#383
No description provided.
Delete Branch "(deleted):notifications"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?