Optimize fragments, add filters, fix search and clean up #439

mmarif · 2020-04-22T16:37:12Z

mmarif commented

2020-04-22 16:37:12 +00:00

A rough PR which fixed few things along the way and added filter for pr and issues(need to redo).

PR filter should work flawlessly and need you guys opinoin on it. If it's fine I can proceed with further fixes and enhacements.

Waiting for your feedback on this.

Closes #414 #385

Ref issue #278

Edit: I will update this post to add the related issues to be closed/addressed OR please add if you see one.

A rough PR which fixed few things along the way and added filter for pr and issues(need to redo). PR filter should work flawlessly and need you guys opinoin on it. If it's fine I can proceed with further fixes and enhacements. Waiting for your feedback on this. Closes #414 #385 Ref issue #278 **Edit: I will update this post to add the related issues to be closed/addressed OR please add if you see one.**

mmarif added the

Enhancement

Needs-feedback

labels 2020-04-22 16:37:12 +00:00

mmarif changed title from ~~Fix searchs, add filters and clean up~~ to Fix search, add filters and clean up

2020-04-22 16:37:24 +00:00

opyale commented

2020-04-22 23:08:05 +00:00

There are multiple progress bars when issues are being loaded.

Screenshot_1587596689.png

31 KiB

opyale commented

2020-04-22 23:10:48 +00:00

This is not a big problem, but in issues the list is empty while the progress bar spins. The opposite is true when pull requests are loading.

Screenshot_1587596935.png

164 KiB

opyale commented

2020-04-22 23:19:34 +00:00

It would be nice too, if we would have some kind of indication, whether we are currently looking at closed or open issues/pull requests. My idea would be to switch to a red filter icon (tint) when viewing closed items.

The color values i used in the screenshot are:

R: 175

G: 66

B: 66

Edit: Made color values a little bit brighter than in the screenshot.

It would be nice too, if we would have some kind of indication, whether we are currently looking at closed or open issues/pull requests. My idea would be to switch to a red filter icon (tint) when viewing closed items. The color values i used in the screenshot are: R: 175 G: 66 B: 66 Edit: Made color values a little bit brighter than in the screenshot.

grafik.png

116 KiB

mmarif commented

2020-04-23 05:36:47 +00:00

There are multiple progress bars when issues are being loaded.

I have only tested on issues using fastadapter. But it is not the focus right now as if PR works as I woulk like it to, I refactor issues to it too.

This is not a big problem, but in issues the list is empty while the progress bar spins. The opposite is true when pull requests are loading.

This need to be addressed, I will try to reproduce on my side.

It would be nice too, if we would have some kind of indication.

Yes, that's what I asked yesterday in the chat but good to know that you have posted a idea. I will try with that, just need to take care of the color in dark theme too.

> There are multiple progress bars when issues are being loaded. I have only tested on issues using fastadapter. But it is not the focus right now as if PR works as I woulk like it to, I refactor issues to it too. > This is not a big problem, but in issues the list is empty while the progress bar spins. The opposite is true when pull requests are loading. This need to be addressed, I will try to reproduce on my side. > It would be nice too, if we would have some kind of indication. Yes, that's what I asked yesterday in the chat but good to know that you have posted a idea. I will try with that, just need to take care of the color in dark theme too.

mmarif added the

Refactor

WIP

labels 2020-04-23 05:42:36 +00:00

mmarif changed title from ~~Fix search, add filters and clean up~~ to Optimize fragments, add filters, fix search and clean up

2020-04-23 05:45:00 +00:00

mmarif commented

2020-04-23 07:27:51 +00:00

@opyale this commit has addressed your points. 3074c477b0

Aside that, I have worked on PR screen at the moment and focus is on that. Once all done on PR screen and we are going to accept these changes. I will refactor issues too in this same PR.

I will remove fastadapter from issues and later from commits, which means no more use of the library. Less space for the app.

Just need thorough testing on PR screen to address all the issues and make sure it works, which can then lead us to refactor issues.

@opyale this commit has addressed your points. https://gitea.com/gitnex/GitNex/commit/3074c477b097a534c0340326a0b30e89a04db72a Aside that, I have worked on PR screen at the moment and focus is on that. Once all done on PR screen and we are going to accept these changes. I will refactor issues too in this same PR. I will remove fastadapter from issues and later from commits, which means no more use of the library. Less space for the app. Just need thorough testing on PR screen to address all the issues and make sure it works, which can then lead us to refactor issues.

Screenshot_20200423_121820.png

60 KiB

👍 1

opyale commented

2020-04-23 07:49:56 +00:00

@mmarif This looks nice so far. The only bug i encountered was that if you swipe to another fragment after you've selected 'closed' on issues/prs and swipe back you will get a green filter icon though the content is still made up of closed views.

opyale commented

2020-04-23 07:55:15 +00:00

@mmarif And there is another bug: The color of the filter icon doesnt change when calling for some closed issues.

mmarif commented

2020-04-23 08:03:24 +00:00

The only bug i encountered was that if you swipe to another fragment after you’ve selected ‘closed’ on issues/prs and swipe back you will get a green filter icon though the content is still made up of closed views.

Nice catch. Swipe even crash the app for me. Will fix that.

And there is another bug: The color of the filter icon doesnt change when calling for some closed issues.

Issues will be done later.

> The only bug i encountered was that if you swipe to another fragment after you’ve selected ‘closed’ on issues/prs and swipe back you will get a green filter icon though the content is still made up of closed views. Nice catch. Swipe even crash the app for me. Will fix that. > And there is another bug: The color of the filter icon doesnt change when calling for some closed issues. Issues will be done later.

mmarif commented

2020-04-23 08:13:14 +00:00

Fixed the swipe issue. c3e1cf48b0

Fixed the swipe issue. https://gitea.com/gitnex/GitNex/commit/c3e1cf48b0a6d6e43de7b67b6135ab0c47569151

👍 1

mmarif added the

Feature

UI/UX

labels 2020-04-23 08:23:34 +00:00

opyale commented

2020-04-23 08:32:38 +00:00

@mmarif Works fine now. Are you planning on fixing "issues" in this pr?