Refactor commits #452

mmarif · 2020-04-24T23:04:17Z

mmarif commented

2020-04-24 23:04:17 +00:00

Closes #440

Right now it will crash for whatever reason of using ?attr/ which is really annoying.

I had this issue last time, can't remember how I fixed it.

If you remove the custom attr from list_commits.xml, it will work. Atleast it's the case on my side.

Edit: fixed the crash.

Closes #440 Right now it will crash for whatever reason of using `?attr/` which is really annoying. I had this issue last time, can't remember how I fixed it. If you remove the custom attr from list_commits.xml, it will work. Atleast it's the case on my side. **Edit: fixed the crash.**

mmarif added this to the 3.0.0 milestone 2020-04-24 23:04:17 +00:00

mmarif added the

Refactor

label 2020-04-24 23:04:17 +00:00

mmarif self-assigned this 2020-04-24 23:04:17 +00:00

mmarif added the

Needs-cleanup

label 2020-04-25 07:15:57 +00:00

mmarif added

LGTM-need

Improvement

and removed

Needs-cleanup

labels 2020-04-26 09:35:58 +00:00

6543 reviewed 2020-04-26 13:45:21 +00:00

Dismissed

app/src/main/java/org/mian/gitnex/activities/CommitsActivity.java Outdated

						
				@ -99,2 +92,2 @@

				        fastItemAdapter = new FastItemAdapter<>();

				        fastItemAdapter.withSelectable(true);

				        // if gitea is 1.12 or higher use the new limit (resultLimitNewGiteaInstances)

				        if(VersionCheck.compareVersion("1.12.0", tinyDb.getString("giteaVersion")) < 1) {

6543 commented

2020-04-26 13:45:21 +00:00

= 1 - yes I know ... refactor income

>= 1 - yes I know ... refactor income

mmarif commented

2020-04-26 14:51:25 +00:00

You mean this < 1 should be = 1?

In that case I have do it in pr and issue also.

You mean this `< 1` should be `= 1`? In that case I have do it in pr and issue also.

6543 commented

2020-04-26 17:35:39 +00:00

     * 0 = less
     * 1 = same
     * 2 = more

``` * 0 = less * 1 = same * 2 = more ```

mmarif commented

2020-04-26 19:00:22 +00:00

Fixed by 6e8160514c

Fixed by https://gitea.com/gitnex/GitNex/commit/6e8160514c90f338ed007d63362566b59fff5e17

6543 requested changes 2020-04-26 13:47:36 +00:00

Dismissed

6543 left a comment

one nit

6543 approved these changes 2020-04-26 21:20:45 +00:00

Dismissed

6543 commented

2020-04-26 21:20:53 +00:00

@mmarif -> 5807faed81

@mmarif -> 5807faed81138e48887813d95199c3f401aec469

6543 added

LGTM-done

and removed

LGTM-need

labels 2020-04-26 21:22:06 +00:00

opyale commented

2020-04-26 21:47:57 +00:00

@mmarif

Right now it will crash for whatever reason of using ?attr/ which is really annoying.

I know this may be too late, but i think youre passing the wrong context to the adapter when using getApplicationContext().

new CommitsAdapter(getApplicationContext())

Try passing CommitsActivity.this instead. It should work fine.

@mmarif > Right now it will crash for whatever reason of using ?attr/ which is really annoying. I know this may be too late, but i think youre passing the wrong context to the adapter when using getApplicationContext(). ``` new CommitsAdapter(getApplicationContext()) ``` Try passing ``CommitsActivity.this`` instead. It should work fine.

mmarif commented

2020-04-26 22:53:17 +00:00

I know this may be too late, but i think youre passing the wrong context to the adapter when using getApplicationContext().

Yes, that's true I was passing the wrong context. Sometime just too many things to take care of. 😄

> I know this may be too late, but i think youre passing the wrong context to the adapter when using getApplicationContext(). Yes, that's true I was passing the wrong context. Sometime just too many things to take care of. :smile:

mmarif commented

2020-04-26 22:54:41 +00:00

@mmarif -> 5807faed81

I saw you used < in somewhere, I guess in the mainactivity. That should also be changed?

> @mmarif -> 5807faed81 I saw you used `<` in somewhere, I guess in the mainactivity. That should also be changed?

6543 commented

2020-04-26 22:58:33 +00:00

@mmarif THIS is a other task - I'll look at all version checks in my refactor - just give me some time - I have a longer and longer ToDo list :(

this here is ready so I'll merge 🚀

@mmarif THIS is a other task - I'll look at all version checks in my refactor - just give me some time - I have a longer and longer ToDo list :( this here is ready so I'll merge :rocket:

6543 referenced this issue from a commit

2020-04-26 22:59:11 +00:00

Refactor commits (#452) code reformat check for same gitea version change link to button `view in browser` add search by commit hash Fix crash for custom attr caused by context and clean up Refactor commits, remove fastadapter Co-authored-by: 6543 <6543@noreply.gitea.io> Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/452 Reviewed-by: 6543 <6543@noreply.gitea.io>

6543 merged commit 195bfc8fe2 into master

2020-04-26 22:59:12 +00:00

6543 deleted branch 440-refactor-commits

2020-04-26 22:59:20 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers