Refactor Context #469

Merged
mmarif merged 5 commits from fix-refactor-context into master 2020-04-28 13:47:32 +00:00
Member

as title

as title
6543 changed title from [WIP] fix-refactor-context to Fix & Refactor context in LoginActifety 2020-04-28 10:28:30 +00:00
6543 changed title from Fix & Refactor context in LoginActifety to Refactor Context 2020-04-28 10:42:54 +00:00
6543 added the
WIP
Refactor
labels 2020-04-28 10:43:14 +00:00
6543 added
LGTM-need
and removed
WIP
labels 2020-04-28 12:02:11 +00:00
mmarif requested changes 2020-04-28 12:13:58 +00:00
Dismissed
@ -47,11 +48,12 @@ public class AddCollaboratorToRepositoryActivity extends BaseActivity {
@Override
public void onCreate(Bundle savedInstanceState) {
appCtx = getApplicationContext();

This should be below super in all places. We don't need this at runtime.

This should be below super in all places. We don't need this at runtime.
Author
Member

done

done
6543 marked this conversation as resolved
6543 requested review from mmarif 2020-04-28 12:26:10 +00:00
Owner

@6543 can fix the conflicts.

@6543 can fix the conflicts.
Author
Member

just pushed while you create the comment 😅

just pushed while you create the comment :sweat_smile:
mmarif approved these changes 2020-04-28 12:53:06 +00:00
Dismissed
6543 requested review from opyale 2020-04-28 13:10:02 +00:00
opyale approved these changes 2020-04-28 13:44:43 +00:00
Dismissed
opyale left a comment
Member

Looks good so far.

Looks good so far.
opyale added
LGTM-done
and removed
LGTM-need
labels 2020-04-28 13:45:10 +00:00
mmarif merged commit c41ab845fd into master 2020-04-28 13:47:28 +00:00
mmarif deleted branch fix-refactor-context 2020-04-28 13:47:39 +00:00
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#469
No description provided.