Refactor Version Checks #472
No reviewers
Labels
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
No Milestone
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitnex/GitNex#472
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "6543/GitNex:refactor-versionCheck"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
as title - finaly a GOOD solution :)
convert enum to class
remove range compare
create constructor for strings (
Version("1.1.2")
)refactor main compare function
UnitTests 🎉
close #489
rename to SemanticVersion
func: equal, less, higher
@ -25,3 +25,3 @@
import org.mian.gitnex.helpers.StaticGlobalVariables;
import org.mian.gitnex.helpers.Toasty;
import org.mian.gitnex.helpers.VersionCheck;
import org.mian.gitnex.helpers.Version;
Version name is too generic here. Can we use something like GiteaVersion or similar?
VersionTest has to be part of the code? in case yes it should not be there. Let me know I can help where to put them.
Also If I am not mistaken MainActivity has version check somewhere?
no and its not :)
well this Version class can handle all kind of semantic Versions not only those from gitea, should I make it more specific?
Let's keep it as is for now.
Works. ?