Milestones filter(open/close) + refactor #506

Merged
mmarif merged 8 commits from milestones-filter into master 2020-05-23 17:54:34 +00:00
Owner

Closes #384

Closes #384
mmarif added this to the 3.0.0 milestone 2020-05-22 16:56:49 +00:00
mmarif added the
Enhancement
Refactor
labels 2020-05-22 16:56:49 +00:00
mmarif self-assigned this 2020-05-22 16:56:49 +00:00
mmarif added 1 commit 2020-05-22 16:56:51 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
5011a9f6fd
change to viewbinding
mmarif added 1 commit 2020-05-22 22:30:30 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
6234ae9a3b
enhance and refactor milestone, added filter for closed and open ms
mmarif added the
LGTM-need
label 2020-05-22 22:30:45 +00:00
mmarif changed title from [WIP] Milestones filter(open/close) + refactor to Milestones filter(open/close) + refactor 2020-05-22 22:31:00 +00:00
mmarif added 1 commit 2020-05-22 22:41:15 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
6c26f12dc3
clean up and add missing parts
6543 added 1 commit 2020-05-23 08:40:53 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
7aeb251dd2
Merge branch 'master' into milestones-filter
6543 reviewed 2020-05-23 08:56:10 +00:00
Dismissed
@ -553,6 +553,8 @@
<string name="strPublic" translatable="false">public</string>
<string name="defaultCopy" translatable="false">Default</string>
<string name="viewInBrowser">View in Browser</string>
<string name="open">Open</string>

we already have this for issues/pulls with the exact same meaning

we already have this for issues/pulls with the exact same meaning
Author
Owner

I think it should be more generic. I will change the issue and pr.

I think it should be more generic. I will change the issue and pr.
mmarif added 2 commits 2020-05-23 11:26:08 +00:00
Member

@mmarif I think this is the wrong way arround, it will delete all related translations & to open vs is open have different translations - I'll push aa commit ...

@mmarif I think this is the wrong way arround, it will delete all related translations & `to open` vs `is open` have different translations - I'll push aa commit ...
Author
Owner

@6543 But it's not used anywhere except for the three bottom sheet so how it will change the end meaning?

@6543 But it's not used anywhere except for the three bottom sheet so how it will change the end meaning?
Member

@mmarif in German language its a question between öffnen and Offen

@mmarif in German language its a question between `öffnen` and `Offen`
Author
Owner

in German language its a question between öffnen and Offen

Yes, I uderstand your point. But What I am saying is I haven't changed anything else except for issues/pr/milestone bottomsheet entries copy(open/closed).

The removed strings are not used anywhere in the app.

You can propse a change via commit if you think it need to be corrected.

> in German language its a question between öffnen and Offen Yes, I uderstand your point. But What I am saying is I haven't changed anything else except for issues/pr/milestone bottomsheet entries copy(open/closed). The removed strings are not used anywhere in the app. You can propse a change via commit if you think it need to be corrected.
6543 added 1 commit 2020-05-23 13:47:32 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
299a466e45
translation: generic but with contecxt
6543 approved these changes 2020-05-23 14:04:15 +00:00
Dismissed
6543 added
LGTM-done
and removed
LGTM-need
labels 2020-05-23 14:04:26 +00:00
Author
Owner

@6543 can you remove the doOpen and doClosed. And then it's ready for merge from my side.

@6543 can you remove the doOpen and doClosed. And then it's ready for merge from my side.
mmarif added 1 commit 2020-05-23 17:54:00 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
1315f75e14
remove strings
mmarif merged commit b30e2da387 into master 2020-05-23 17:54:30 +00:00
mmarif deleted branch milestones-filter 2020-05-23 17:54:48 +00:00
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#506
No description provided.