Fix infined load on Issues/Pulls if they dont exist #507

@mmarif @opyale I would add a new coding rule: on a api call always check the http code since this indicate if it succeeded or not and if there are more than 2 posible codes use switch-case instead of else-if-blocks

https://try.gitea.io/api/swagger#/repository/repoGetAllCommits
-> expected returns are 200, 404 and 409 for example

@mmarif @opyale I would add a new coding rule: on a api call always check the http code since this indicate if it succeeded or not and if there are more than 2 posible codes use switch-case instead of else-if-blocks https://try.gitea.io/api/swagger#/repository/repoGetAllCommits -> expected returns are 200, 404 and 409 for example

6543 changed title from ~~Improve 404 calls~~ to Fix infined load on Issues/Pulls if they dont exist & Refactor

2020-05-23 17:07:29 +00:00

6543 added

Bug

LGTM-need

and removed

Improvement

labels 2020-05-23 17:07:49 +00:00

mmarif commented

2020-05-23 17:39:12 +00:00

I would add a new coding rule: on a api call always check the http code since this indicate if it succeeded or not and if there are more than 2 posible codes use switch-case instead of else-if-blocks

I am fine with it. Just curious, what are the advantages of switch over if?

> I would add a new coding rule: on a api call always check the http code since this indicate if it succeeded or not and if there are more than 2 posible codes use switch-case instead of else-if-blocks I am fine with it. Just curious, what are the advantages of switch over if?

mmarif commented

2020-05-23 17:50:35 +00:00

@6543 This PR with the your commits became very huge and unreadable.

Can we focus on the issue and pr calls in this PR which will fix the inifinite loop issue?

Reformat code: new PR

Change to switch cases: new PR

What you think?

@6543 This PR with the your commits became very huge and unreadable. Can we focus on the issue and pr calls in this PR which will fix the inifinite loop issue? Reformat code: new PR Change to switch cases: new PR What you think?

6543 changed title from ~~Fix infined load on Issues/Pulls if they dont exist & Refactor~~ to Fix infined load on Issues/Pulls if they dont exist

2020-05-23 18:23:29 +00:00

6543 force-pushed fix-404-errors from c0eccbacd4 to 67e9a694e9

2020-05-23 18:25:09 +00:00

Compare

6543 commented

2020-05-23 18:25:51 +00:00

@mmarif removed

6543 added

LGTM-done

and removed

LGTM-need

labels 2020-05-23 18:26:06 +00:00