From 72f0b24a444514782cb976f4aa32c3a7eb4f5be9 Mon Sep 17 00:00:00 2001 From: M M Arif Date: Sat, 23 May 2020 16:40:36 +0500 Subject: [PATCH 1/2] add 404 for pr --- .../gitnex/fragments/PullRequestsFragment.java | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/mian/gitnex/fragments/PullRequestsFragment.java b/app/src/main/java/org/mian/gitnex/fragments/PullRequestsFragment.java index 6a5a9bd..228e0aa 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/PullRequestsFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/PullRequestsFragment.java @@ -183,7 +183,7 @@ public class PullRequestsFragment extends Fragment { @Override public void onResponse(@NonNull Call> call, @NonNull Response> response) { - if(response.isSuccessful()) { + if(response.code() == 200) { assert response.body() != null; if(response.body().size() > 0) { @@ -195,14 +195,26 @@ public class PullRequestsFragment extends Fragment { } else { + prList.clear(); adapter.notifyDataChanged(); noData.setVisibility(View.VISIBLE); + } + mProgressBar.setVisibility(View.GONE); + + } + else if(response.code() == 404) { + + noData.setVisibility(View.VISIBLE); + mProgressBar.setVisibility(View.GONE); + } else { + Log.i(TAG, String.valueOf(response.code())); + } Log.i(TAG, String.valueOf(response.code())); -- 2.40.1 From 67e9a694e9eae39344e0b0ebccf356a1b1fc27b5 Mon Sep 17 00:00:00 2001 From: M M Arif Date: Sat, 23 May 2020 16:43:30 +0500 Subject: [PATCH 2/2] 404 fix for issues --- .../org/mian/gitnex/fragments/IssuesFragment.java | 14 ++++++++++++-- .../gitnex/fragments/PullRequestsFragment.java | 2 +- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/mian/gitnex/fragments/IssuesFragment.java b/app/src/main/java/org/mian/gitnex/fragments/IssuesFragment.java index 2cfbee8..01a216f 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/IssuesFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/IssuesFragment.java @@ -180,7 +180,7 @@ public class IssuesFragment extends Fragment { @Override public void onResponse(@NonNull Call> call, @NonNull Response> response) { - if(response.isSuccessful()) { + if(response.code() == 200) { assert response.body() != null; if(response.body().size() > 0) { @@ -192,11 +192,21 @@ public class IssuesFragment extends Fragment { } else { + issuesList.clear(); adapter.notifyDataChanged(); noDataIssues.setVisibility(View.VISIBLE); + } + mProgressBar.setVisibility(View.GONE); + + } + else if(response.code() == 404) { + + noDataIssues.setVisibility(View.VISIBLE); + mProgressBar.setVisibility(View.GONE); + } else { Log.e(TAG, String.valueOf(response.code())); @@ -227,7 +237,7 @@ public class IssuesFragment extends Fragment { @Override public void onResponse(@NonNull Call> call, @NonNull Response> response) { - if(response.isSuccessful()) { + if(response.code() == 200) { //remove loading view issuesList.remove(issuesList.size() - 1); diff --git a/app/src/main/java/org/mian/gitnex/fragments/PullRequestsFragment.java b/app/src/main/java/org/mian/gitnex/fragments/PullRequestsFragment.java index 228e0aa..6ce0399 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/PullRequestsFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/PullRequestsFragment.java @@ -244,7 +244,7 @@ public class PullRequestsFragment extends Fragment { @Override public void onResponse(@NonNull Call> call, @NonNull Response> response) { - if(response.isSuccessful()) { + if(response.code() == 200) { //remove loading view prList.remove(prList.size() - 1); -- 2.40.1