Add support for non-struct pointers #5

KN4CK3R · 2021-05-02T20:52:49Z

KN4CK3R commented

2021-05-02 20:52:49 +00:00

This PR adds support for pointers to optional fields in forms.

This example fails in the old version:

type TestForm struct {
	Test string `binding:"Url"`
	TestPtr *string `binding:"Url"`
}

empty := ""
form := &TestForm{
	Test: "",
	TestPtr: &empty,
}
_ := RawValidate(form)

The empty Test field is no problem because an empty field is valid url. The empty pointer field throws an error because the regex checks against the wrong field value of "0xc000011dc0". So the memory address is formatted as string and tested. After the change both fields pass because both are treated equal.

Fixes the workaround in https://github.com/go-gitea/gitea/pull/15690

This PR adds support for pointers to optional fields in forms. This example fails in the old version: ```go type TestForm struct { Test string `binding:"Url"` TestPtr *string `binding:"Url"` } empty := "" form := &TestForm{ Test: "", TestPtr: &empty, } _ := RawValidate(form) ``` The empty `Test` field is no problem because an empty field is valid url. The empty pointer field throws an error because the regex checks against the wrong field value of `"0xc000011dc0"`. So the memory address is formatted as string and tested. After the change both fields pass because both are treated equal. Fixes the workaround in https://github.com/go-gitea/gitea/pull/15690

KN4CK3R added 1 commit 2021-05-02 20:52:49 +00:00

Add support for non-struct pointers. 32a2a340af

KN4CK3R reviewed 2021-05-02 20:53:27 +00:00

binding.go Outdated

						
				@ -353,7 +353,22 @@ func validateStruct(errors Errors, obj interface{}) Errors {

							(field.Type.Kind() == reflect.Ptr && !reflect.DeepEqual(zero, fieldValue) &&

								field.Type.Elem().Kind() == reflect.Struct) {

							errors = validateStruct(errors, fieldValue)

							continue