go-chi/session
9
4
Fork 3
Code Issues 1 Pull Requests Actions Activity

Provide function to regenerate RawStore within session #4

Merged
zeripath merged 2 commits from zeripath/session:regenerate-session-function into master 2021-12-18 22:16:15 +00:00
Conversation 2 Commits 2 Files Changed 2 +36 -5
zeripath commented 2021-12-18 15:36:55 +00:00
Owner
Copy Link

There is currently no easy way to regenerate the session id within Sessioner
meaning it is hard to update the session ID early on in a request tree.

RegenerateSession will look in the request scope for the session, grab the session
release, regenerate and then flush the old session before updating the RawStore in the
session.

Signed-off-by: Andrew Thornton art27@cantab.net

There is currently no easy way to regenerate the session id within Sessioner meaning it is hard to update the session ID early on in a request tree. RegenerateSession will look in the request scope for the session, grab the session release, regenerate and then flush the old session before updating the RawStore in the session. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added 1 commit 2021-12-18 15:36:56 +00:00
Provide function to regenerate RawStore within session 
There is currently no easy way to regenerate the session id within Sessioner
meaning it is hard to update the session ID early on in a request tree.

RegenerateSession will look in the request scope for the session, grab the session
release, regenerate and then flush the old session before updating the RawStore in the
session.

Signed-off-by: Andrew Thornton <art27@cantab.net>
All checks were successful
continuous-integration/drone/pr Build is passing
Details
fada65c986
lunny commented 2021-12-18 16:03:18 +00:00
Owner
Copy Link

There is currently no easy way to regenerate the session id within Sessioner
meaning it is hard to update the session ID early on in a request tree.

RegenerateSession will look in the request scope for the session, grab the session
release, regenerate and then flush the old session before updating the RawStore in the
session.

Signed-off-by: Andrew Thornton art27@cantab.net

How about to add a test?

> There is currently no easy way to regenerate the session id within Sessioner > meaning it is hard to update the session ID early on in a request tree. > > RegenerateSession will look in the request scope for the session, grab the session > release, regenerate and then flush the old session before updating the RawStore in the > session. > > Signed-off-by: Andrew Thornton <art27@cantab.net> How about to add a test?
zeripath added 1 commit 2021-12-18 17:02:16 +00:00
add tests 
Signed-off-by: Andrew Thornton <art27@cantab.net>
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e375b87ea5
zeripath commented 2021-12-18 17:02:39 +00:00
Author
Owner
Copy Link

I've added tests and fixed some issues.

I've added tests and fixed some issues.
jolheiser approved these changes 2021-12-18 21:41:48 +00:00
zeripath merged commit e3605d8b28 into master 2021-12-18 22:16:15 +00:00
zeripath deleted branch regenerate-session-function 2021-12-18 22:16:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jolheiser
Labels
Clear labels   
break

   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
break
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: go-chi/session#4
No description provided.
Delete Branch "zeripath/session:regenerate-session-function"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?