goftp/server
goftp/server
10
30
Fork 25
Code Issues 15 Pull Requests 2 Actions Projects 1 Releases 6 Activity

Put a linter check to build pipeline #127

New Issue
Closed
opened 2020-08-05 12:09:52 +00:00 by cenkalti · 8 comments
cenkalti commented 2020-08-05 12:09:52 +00:00
Contributor
Copy Link

I recommend golangci-lint.

I recommend [golangci-lint](https://github.com/golangci/golangci-lint/).
lunny commented 2020-08-05 13:37:05 +00:00
Owner
Copy Link

Could you send a PR?

Could you send a PR?
👍 1
cenkalti commented 2020-08-07 08:24:07 +00:00
Author
Contributor
Copy Link

@lunny I think there is a problem with the drone CI setup. Network requests fail with an error. I couldn't be able to download golangci-lint tool and dependent modules from the container. I have tried with several images and both curl and wget. Can you check what'w wrong please?

Example with ubuntu and curl: https://drone.gitea.com/goftp/server/145/1/3

After some search I have found this issue: https://github.com/moby/moby/issues/2011#issuecomment-252250588 Maybe it is relevant.

@lunny I think there is a problem with the drone CI setup. Network requests fail with an error. I couldn't be able to download `golangci-lint` tool and dependent modules from the container. I have tried with several images and both curl and wget. Can you check what'w wrong please? Example with ubuntu and curl: https://drone.gitea.com/goftp/server/145/1/3 After some search I have found this issue: https://github.com/moby/moby/issues/2011#issuecomment-252250588 Maybe it is relevant.
lunny commented 2020-08-07 11:49:06 +00:00
Owner
Copy Link

We could use go get to download the sources and compile it.

We could use `go get` to download the sources and compile it.
cenkalti commented 2020-08-08 11:00:29 +00:00
Author
Contributor
Copy Link

It also does not work. That's why I think there is a problem with networking in container. See: https://drone.gitea.com/goftp/server/146/1/3

It also does not work. That's why I think there is a problem with networking in container. See: https://drone.gitea.com/goftp/server/146/1/3
lunny commented 2020-08-09 07:19:26 +00:00
Owner
Copy Link

You have to use the go module proxy https://goproxy.cn

You have to use the go module proxy `https://goproxy.cn`
cenkalti commented 2020-08-10 10:22:12 +00:00
Author
Contributor
Copy Link

Why?

Why?
lunny commented 2020-08-10 12:23:25 +00:00
Owner
Copy Link

Because the servers of gitea.com is in China which blocked the google's services.

Because the servers of gitea.com is in China which blocked the google's services.
cenkalti commented 2020-08-11 08:39:58 +00:00
Author
Contributor
Copy Link

It is working with goproxy.cn now. Can you merge please? I'll send another PR addressing the linter issues.

It is working with goproxy.cn now. Can you merge please? I'll send another PR addressing the linter issues.
lunny closed this issue 2020-08-12 07:20:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
v2
master
v2.0.1
v2.0.0
v2.0.0-beta.5
v2.0.0-beta.4
v0.4.1
v0.4.0
v0.3.4
v0.3.3
v0.3.2
v0.3.1
0.3.0
0.2.2
Labels
Clear labels   
break

   
bug

   
docs

   
duplicate

   
enhancement

   
feature

   
help wanted

   
invalid

   
proposal

   
question

   
testing

   
wontfix
No Label
break
bug
docs
duplicate
enhancement
feature
help wanted
invalid
proposal
question
testing
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: goftp/server#127
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?