Add auth factory, expose driver on conn #108

freman · 2020-03-31T11:28:06Z

freman commented

2020-03-31 11:28:06 +00:00

First-time contributor

A possible solution to #106 that doesn't break backwards compatability.

Means I can define an auth factory that can check with the driver, or even have the auth method in the driver.

type driver struct {
	webdav *gowebdav.Client
}

// CheckPasswd will check user's password
func (d *driver) CheckPasswd(name, pass string) (bool, error) {
	c := gowebdav.NewClient("https://example.com/webdav", name, pass)
	if err := c.Connect(); err != nil {
		return false, err
	}
	d.webdav = c
	return true, nil
}

type authFactory struct{}

func (a *authFactory) NewAuth(c *server.Conn) (server.Auth, error) {
	if d, isa := c.Driver().(*driver); isa {
		return d, nil
	}
	return nil, errors.New("wrong type of driver")
}

only catch is I patched it to use the new 1.13 errors in go out of habit, please feel free to not do that

A possible solution to #106 that doesn't break backwards compatability. Means I can define an auth factory that can check with the driver, or even have the auth method in the driver. ``` type driver struct { webdav *gowebdav.Client } // CheckPasswd will check user's password func (d *driver) CheckPasswd(name, pass string) (bool, error) { c := gowebdav.NewClient("https://example.com/webdav", name, pass) if err := c.Connect(); err != nil { return false, err } d.webdav = c return true, nil } type authFactory struct{} func (a *authFactory) NewAuth(c *server.Conn) (server.Auth, error) { if d, isa := c.Driver().(*driver); isa { return d, nil } return nil, errors.New("wrong type of driver") } ``` only catch is I patched it to use the new 1.13 errors in go out of habit, please feel free to not do that

freman commented

2020-03-31 11:51:28 +00:00

First-time contributor

Hmmmm might need to add something like a

type Closer interface{
	Close()
}

and add a check in conn.Close()

func (conn *Conn) Close() {
	if c, isa := conn.driver.(Closer); isa {
		c.Close()
	}
	conn.conn.Close()
	conn.closed = true
	conn.reqUser = ""
	conn.user = ""
	if conn.dataConn != nil {
		conn.dataConn.Close()
		conn.dataConn = nil
	}
}

Hmmmm might need to add something like a ``` type Closer interface{ Close() } ``` and add a check in conn.Close() ``` func (conn *Conn) Close() { if c, isa := conn.driver.(Closer); isa { c.Close() } conn.conn.Close() conn.closed = true conn.reqUser = "" conn.user = "" if conn.dataConn != nil { conn.dataConn.Close() conn.dataConn = nil } } ```

lunny added this to the 0.4 milestone 2020-04-18 03:48:43 +00:00

lunny added the

feature

label 2020-04-18 03:49:13 +00:00

lunny modified the milestone from 0.4 to 0.6

2020-07-07 16:05:02 +00:00

lunny commented

2020-07-07 16:17:54 +00:00

#119 closed this.

https://gitea.com/goftp/server/pulls/119 closed this.

lunny closed this pull request

2020-12-01 06:21:04 +00:00