goftp/server
goftp/server
10
30
Fork 25
Code Issues 15 Pull Requests 2 Actions Projects 1 Releases 6 Activity

Adjust behaviour of RNFR #111

Closed
freman wants to merge 5 commits from freman/goftp-server:rnfr-tweak into master
pull from: freman/goftp-server:rnfr-tweak
merge into: goftp:master
Conversation 3 Commits 5 Files Changed 1 +5
freman commented 2020-04-18 13:27:54 +00:00
First-time contributor
Copy Link

A fix for #109

An alternate fix would be to implement optional interfaces on the drivers for commands and let people chose to implement them or not

A fix for #109 An alternate fix would be to implement optional interfaces on the drivers for commands and let people chose to implement them or not
lunny reviewed 2020-04-19 03:11:14 +00:00
Dismissed
cmd.go Outdated
@ -845,6 +845,11 @@ func (cmd commandRnfr) RequireAuth() bool {
}
func (cmd commandRnfr) Execute(conn *Conn, param string) {
_, err := conn.Driver().Stat(param)
lunny commented 2020-04-19 03:11:14 +00:00
Owner
Copy Link

_, err := conn.Driver().Stat(conn.buildPath(param))

_, err := conn.Driver().Stat(conn.buildPath(param))
lunny commented 2020-04-19 03:11:27 +00:00
Owner
Copy Link

CI failed.

CI failed.
freman commented 2020-04-22 01:00:57 +00:00
Author
First-time contributor
Copy Link

I fixed the thing I broke, I don't think it's failing for anything I broke any more.

I fixed the thing I broke, I don't think it's failing for anything I broke any more.
lunny added this to the 0.6 milestone 2020-07-07 16:11:22 +00:00
lunny commented 2020-12-04 11:35:51 +00:00
Owner
Copy Link

Since we begin to v2, please send to branch v2.

Since we begin to v2, please send to branch v2.
lunny closed this pull request 2020-12-04 11:35:51 +00:00
lunny removed this from the 0.6 milestone 2020-12-04 11:38:46 +00:00
Some checks are pending
continuous-integration/drone/pr Build is failing
Details
checks / check and test (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
break

   
bug

   
docs

   
duplicate

   
enhancement

   
feature

   
help wanted

   
invalid

   
proposal

   
question

   
testing

   
wontfix
No Label
break
bug
docs
duplicate
enhancement
feature
help wanted
invalid
proposal
question
testing
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: goftp/server#111
No description provided.
Delete Branch "freman/goftp-server:rnfr-tweak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?