golang/sync
1
0
Fork 0
mirror of https://github.com/golang/sync synced 2020-06-03 17:03:44 +00:00
Code Issues Releases Wiki Activity
27 Commits 1 Branch 0 Tags 95 KiB
Go 100%
Go to file
徐志强 43a5402ce7 semaphore: unblock waiters when the front waiter cancels 
When `Release`, if the remaining tokens are not enough for the front waiter, no waiters will be notified.

So if the canceled waiter is the front one, it should try to notify following waiters if there are remaining tokens.

I found this bug when implementing a cancelable rwmutex based on semaphore:

https://github.com/zhiqiangxu/util/blob/master/mutex/crwmutex.go

This bug can be verified by this test:

https://github.com/zhiqiangxu/util/blob/master/mutex/crwmutex_test.go#L43

Change-Id: Id8564976bd375a82c4fbc6cb08b0bb83118a346c
GitHub-Last-Rev: 29b6ff26bf
GitHub-Pull-Request: golang/sync#10
Reviewed-on: https://go-review.googlesource.com/c/sync/+/223418
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
2020-03-17 01:50:54 +00:00
errgroup all: remove x/net/context in favour of context 2018-11-08 01:04:31 +00:00
semaphore semaphore: unblock waiters when the front waiter cancels 2020-03-17 01:50:54 +00:00
singleflight singleflight: fix duplicate deleting key when Forget called 2019-04-12 18:36:30 +00:00
syncmap syncmap: use type alias for Map 2019-09-11 18:51:00 +00:00
AUTHORS initial commit 2015-10-30 14:31:46 +11:00
codereview.cfg .: add codereview.cfg 2016-12-06 01:46:32 +00:00
CONTRIBUTING.md CONTRIBUTING.md: remove note about not accepting Pull Requests 2018-03-14 18:01:46 +00:00
CONTRIBUTORS initial commit 2015-10-30 14:31:46 +11:00
go.mod all: add a go.mod file 2019-02-27 15:59:43 +00:00
LICENSE initial commit 2015-10-30 14:31:46 +11:00
PATENTS initial commit 2015-10-30 14:31:46 +11:00
README.md README: switch to Markdown, add better links 2017-09-27 05:41:12 +00:00

README.md

Go Sync

This repository provides Go concurrency primitives in addition to the ones provided by the language and "sync" and "sync/atomic" packages.

Download/Install

The easiest way to install is to run go get -u golang.org/x/sync. You can also manually git clone the repository to $GOPATH/src/golang.org/x/sync.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.

The main issue tracker for the sync repository is located at https://github.com/golang/go/issues. Prefix your issue with "x/sync:" in the subject line, so it is easy to find.