jolheiser/sip
jolheiser/sip
3
4
Fork 1
Code Issues 5 Pull Requests Releases 6 Activity

Add attachment removal and change message #36

Merged
jolheiser merged 1 commits from release-remove into master 2020-09-21 14:19:38 +00:00
Conversation 1 Commits 1 Files Changed 3 +108 -3
jolheiser commented 2020-09-21 03:59:49 +00:00
Owner
Copy Link

Fixes #35

Changes the message to instead tell the user how many files were added/removed from the release.

This PR also adds a way to multi-select attachments to be removed from a release via sip release attach remove since sip release remove will be reserved for removing a release in the future.

Fixes #35 Changes the message to instead tell the user how many files were added/removed from the release. This PR also adds a way to multi-select attachments to be removed from a release via `sip release attach remove` since `sip release remove` will be reserved for removing a release in the future.
🎉 1
jolheiser added the
enhancement
 label 2020-09-21 03:59:49 +00:00
jolheiser added 1 commit 2020-09-21 03:59:50 +00:00
Add attachment removal and change message 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
All checks were successful
continuous-integration/drone/pr Build is passing
Details
b7ff305849
wanderer commented 2020-09-21 08:11:33 +00:00
First-time contributor
Copy Link

just built this myself, works like a charm, removed the release attachment no problem ?

just built this myself, works like a charm, removed the release attachment no problem ?
👍 1
jolheiser merged commit 0bbe2e35ff into master 2020-09-21 14:19:38 +00:00
jolheiser deleted branch release-remove 2020-09-21 14:19:44 +00:00
jolheiser added this to the 0.5.1 milestone 2020-09-21 14:19:52 +00:00
jolheiser reopened this pull request 2020-09-21 14:21:15 +00:00
jolheiser closed this pull request 2020-09-21 14:21:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
build

Changes to builds

  
docs

Documentation updates

  
duplicate

This issue or pull request already exists

  
enhancement

Enhancement of a feature

  
feature

New feature

  
invalid

Something is wrong

  
question

More information is needed

  
skip-changelog

Skip the changelog

  
wontfix

This won't be fixed

No Label
bug
build
docs
duplicate
enhancement
feature
invalid
question
skip-changelog
wontfix
Milestone
Clear milestone
No items
No Milestone
0.5.1
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jolheiser/sip#36
No description provided.
Delete Branch "release-remove"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?